Change in ovirt-engine[master]: core: [db] removing unsued InsertVds SP
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: [db] removing unsued InsertVds SP
......................................................................
core: [db] removing unsued InsertVds SP
This patch removes the unused InsertVds SP.
Change-Id: Ie6f019efdabb66d295ef5968203a193668655a6d
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/vds_sp.sql
1 file changed, 0 insertions(+), 65 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20695
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6f019efdabb66d295ef5968203a193668655a6d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: core: add missing mock of config value in ManageGlusterServi...
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: add missing mock of config value in ManageGlusterServiceCommandTest
......................................................................
core: add missing mock of config value in ManageGlusterServiceCommandTest
Change-Id: I9effbe64985c90edfe57e9d999c182ed06bb1858
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommandTest.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20735
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9effbe64985c90edfe57e9d999c182ed06bb1858
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: core: Add audit log for export repo image
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add audit log for export repo image
......................................................................
core: Add audit log for export repo image
Adding an audit log when exporting a repository image (same as
importRepoImage)
Bug-Url: https://bugzilla.redhat.com/1021210
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Change-Id: Ifb79102b01b596a1ff74a1a38fdcb7dca71e0c7c
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
4 files changed, 37 insertions(+), 0 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20660
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb79102b01b596a1ff74a1a38fdcb7dca71e0c7c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: core: Change audit log value to be unique
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Change audit log value to be unique
......................................................................
core: Change audit log value to be unique
There is a duplicate value code in the auditLogType file, which can
cause wrong audit log to be presented.
The proposed patch fix them it so it will be unique.
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Change-Id: I81e7074807396541d041a170adeff49949b9d731
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20659
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81e7074807396541d041a170adeff49949b9d731
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: core: Add missing CDA message to AppErrors[1]
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add missing CDA message to AppErrors[1]
......................................................................
core: Add missing CDA message to AppErrors[1]
Adding missing CDA error message of export image to the AppErrors file,
so the client will present the message instead of the enum place
holder ACTION_TYPE_FAILED_DISK_IS_BEING_EXPORTED.
Bug-Url: https://bugzilla.redhat.com/1024887
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Change-Id: I2ca5165d007296778f8a80e07c2e088db82e287f
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20716
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ca5165d007296778f8a80e07c2e088db82e287f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Set uniform width to vNIC entries
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Set uniform width to vNIC entries
......................................................................
webadmin: Set uniform width to vNIC entries
Added a set width for the vNIC entries in the add/edit VM dialog, to
avoid longer vNIC names indenting the other UI fields.
Change-Id: If0695a84aaee747b7020961da3392a60507b2fe6
Bug-Url: https://bugzilla.redhat.com/1023035
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20594
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0695a84aaee747b7020961da3392a60507b2fe6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[ovirt-engine-3.3]: restapi: fix vm link for template's watchdog
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: restapi: fix vm link for template's watchdog
......................................................................
restapi: fix vm link for template's watchdog
Change-Id: Ie84c9809a8cbb0fddf0daf39f22be97a8eadb938
Bug-Url: https://bugzilla.redhat.com/1019211
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateWatchdogsResource.java
2 files changed, 25 insertions(+), 1 deletion(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20708
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie84c9809a8cbb0fddf0daf39f22be97a8eadb938
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: restapi: restapi: Add support for JAXB annotations in JSON #...
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: restapi: Add support for JAXB annotations in JSON #652883
......................................................................
restapi: restapi: Add support for JAXB annotations in JSON #652883
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=652883
Change-Id: Ifd4dd0681df72a37e3090ea00509c0f5ec206b14
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resteasy/json/CustomObjectMapper.java
M backend/manager/modules/restapi/webapp/src/main/resources/META-INF/MANIFEST.MF
3 files changed, 34 insertions(+), 2 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20704
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd4dd0681df72a37e3090ea00509c0f5ec206b14
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: Revert "restapi: Add support for JAXB annotations in JSON"
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: Revert "restapi: Add support for JAXB annotations in JSON"
......................................................................
Revert "restapi: Add support for JAXB annotations in JSON"
same can be done against standard resteasy-jackson-provider
(which we want stick to, cause by using jackson-jaxrs directly, we
lose all resteasy extensions)
This reverts commit e87a70e006b8638b206bad01c02918030b255a0c.
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
Change-Id: I5dfa9732952da951011c859e818daf6166c0436f
---
M backend/manager/modules/restapi/interface/definition/pom.xml
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resteasy/json/CustomObjectMapper.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resteasy/json/JsonProvider.java
M backend/manager/modules/restapi/webapp/src/main/resources/META-INF/MANIFEST.MF
M backend/manager/modules/vdsbroker/pom.xml
M pom.xml
6 files changed, 72 insertions(+), 49 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20703
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5dfa9732952da951011c859e818daf6166c0436f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Only close provider dialog if action succeeds
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Only close provider dialog if action succeeds
......................................................................
webadmin: Only close provider dialog if action succeeds
Give the dialog a chance to display an error message from the backend
before closing.
Change-Id: I8ecf9d1364935a2a9231b44131eca5ca725d6db6
Bug-Url: https://bugzilla.redhat.com/987949
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20568
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ecf9d1364935a2a9231b44131eca5ca725d6db6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years