March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: gluster: improved gluster audit log util
by sanjal＠redhat.com 25 Mar '13

25 Mar '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: improved gluster audit log util ...................................................................... gluster: improved gluster audit log util Create object of AuditLogableBase and set appropriate properties on it instead of overriding methods. Refactoring in AuditLogableBase: - Set vds id inside setVds - New setter for glusterVolume Change-Id: I52212ddb694d727248182d32abc1e1f5a21f76ee Bug-Url: https://bugzilla.redhat.com/916112 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/gluster/GlusterAuditLogUtil.java 2 files changed, 17 insertions(+), 32 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13001 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52212ddb694d727248182d32abc1e1f5a21f76ee Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Snapshot failure should not be retried.
by mlipchuk＠redhat.com 25 Mar '13

25 Mar '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Snapshot failure should not be retried. ...................................................................... core: Snapshot failure should not be retried. When snapshot VDS command throws any exception, engine should end the command with an appropriate audit log which indicates that a restart is required, instead of retrying the VDS command every 10 seconds and flooding the event log. Change-Id: I8f56b025e0c6bbd9c9992ee65007a19c97658790 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/923366 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f56b025e0c6bbd9c9992ee65007a19c97658790 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Show migrating VM on destination host
by ofrenkel＠redhat.com 25 Mar '13

25 Mar '13

Omer Frenkel has submitted this change and it was merged. Change subject: webadmin: Show migrating VM on destination host ...................................................................... webadmin: Show migrating VM on destination host Show a migrating VM both on the source host (status Migrating From) as well as on the destination host (Migrating To). Change-Id: Iae8228e4a6e9e7e91b8224f0ef2764c5e4e25cfa Bug-Url: https://bugzilla.redhat.com/881593 Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M backend/manager/dbscripts/vms_sp.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsRunningOnOrMigratingToVdsQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmsRunningOnOrMigratingToVdsQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsRunningOnOrMigratingToVdsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostVmListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostVmView.java 11 files changed, 187 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae8228e4a6e9e7e91b8224f0ef2764c5e4e25cfa Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated packaging for db utilities
by juan.hernandez＠redhat.com 25 Mar '13

25 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated packaging for db utilities ...................................................................... packaging: Updated packaging for db utilities This patch updates the packaging of various DB utilities within the setup package. Also, it updates the path to these utilities in the upgrade script. Change-Id: I36c4b03637383860b14c9695aab9ee0afe5bf1a5 Bug-Url: https://bugzilla.redhat.com/893459 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M Makefile M backend/manager/tools/dbutils/fkvalidator.sh M packaging/fedora/setup/basedefs.py M packaging/fedora/spec/ovirt-engine.spec.in 4 files changed, 11 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36c4b03637383860b14c9695aab9ee0afe5bf1a5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: use tools new conf.d feature
by juan.hernandez＠redhat.com 25 Mar '13

25 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: use tools new conf.d feature ...................................................................... packaging: use tools new conf.d feature Change-Id: I4849ac3dcefeb22b7aea725b6bd734174d6778e2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/spec/ovirt-engine.spec.in 3 files changed, 38 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4849ac3dcefeb22b7aea725b6bd734174d6778e2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: engine-setup - Fixed memory requirements
by juan.hernandez＠redhat.com 25 Mar '13

25 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: tools: engine-setup - Fixed memory requirements ...................................................................... tools: engine-setup - Fixed memory requirements for running the engine, 4Gb is the minimum, 16Gb is the recomended ammount of RAM. Change-Id: I4f439d41d76497cf5a69224ce257881d4ed23087 Bug-Url: https://bugzilla.redhat.com/921079 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/basedefs.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f439d41d76497cf5a69224ce257881d4ed23087 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: engine-setup - fixed installation messages
by juan.hernandez＠redhat.com 25 Mar '13

25 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: tools: engine-setup - fixed installation messages ...................................................................... tools: engine-setup - fixed installation messages Display instructions for configuring iptables and firewalld only if they're available on the system. Change-Id: I89964bc30c275a29428abef06d07b7a8911ee211 Bug-Url: https://bugzilla.redhat.com/921079 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py 1 file changed, 19 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89964bc30c275a29428abef06d07b7a8911ee211 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: remove unused lock directory
by juan.hernandez＠redhat.com 25 Mar '13

25 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: remove unused lock directory ...................................................................... packaging: remove unused lock directory Change-Id: I8610a41c64d069a283e6ff3a04fa2cf827dd5540 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M backend/manager/conf/engine.conf.defaults.in M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java M packaging/fedora/engine-service.py.in M packaging/fedora/spec/ovirt-engine.spec.in 5 files changed, 0 insertions(+), 16 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13314 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8610a41c64d069a283e6ff3a04fa2cf827dd5540 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: disable cores-per-socket for running VM
by tjelinek＠redhat.com 25 Mar '13

25 Mar '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: disable cores-per-socket for running VM ...................................................................... frontend: disable cores-per-socket for running VM This patch makes the cores per virtual socket list unchangeable for a running VM, just as the total virtual CPUs field and the virtual sockets list are unchangeable for running VM. Change-Id: I552114e2ef7f81c920b091ca19c3811ecf36b2ad Bug-Url: https://bugzilla.redhat.com/922609 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I552114e2ef7f81c920b091ca19c3811ecf36b2ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: add an option of default timezone
by tjelinek＠redhat.com 25 Mar '13

25 Mar '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: add an option of default timezone ...................................................................... frontend: add an option of default timezone This patch adds an empty entry in the timezones list presented in the UI, which represents the selection of the default timezone that is defined in the system. This new empty entry is now selected by default when creating new VM, and when editing a VM that no timezone was defined for it. This patch fix bug 922609: before this patch the first timezone was selected by default when opening the edit dialog of VM with no timezone defined and therefore when pressing 'ok' the system detected a change in the timezone field and tried to update it - even when it wasn't possible. from now on, the empty entry will be selected by default in that case so no change will be detected unless the user actually changed the timezone field. Change-Id: I7f8c80ae783e88740ee907d9ff52c0bd6c40734c Bug-Url: https://bugzilla.redhat.com/922609 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 13 insertions(+), 27 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f8c80ae783e88740ee907d9ff52c0bd6c40734c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0