March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: RemoveDiskCommand: only validate images once
by amureini＠redhat.com 27 Mar '13

27 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveDiskCommand: only validate images once ...................................................................... core: RemoveDiskCommand: only validate images once RemoveDiskCommand.canRemoveVmImageDisk() called ImageHandler.PerformImagesChecks in a loop, for each VM attached to the disk. Since the VM checks have been extracted from ImageHandler.PerformImagesChecks in commit 69b515c3a30b0185f05b3b7d3451806f2b5b86cb, this is no longer required, can the validation can be called a single time. Change-Id: I8c0408db32415785bfe36d144b08a6f6c9f0aefc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java 1 file changed, 18 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c0408db32415785bfe36d144b08a6f6c9f0aefc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:ExportVm.doesStorageDomainhaveSpaceForRequest
by amureini＠redhat.com 27 Mar '13

27 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core:ExportVm.doesStorageDomainhaveSpaceForRequest ...................................................................... core:ExportVm.doesStorageDomainhaveSpaceForRequest Removed ExportVmCommand.doesStorageDomainhaveSpaceForRequest(StorageDomain, long). It's exactly identical to the method it overrides in StorageDomainCommandBase, and is thus redundant. Change-Id: Ia267125106c6465c064719c2718053644b556195 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia267125106c6465c064719c2718053644b556195 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed unused method in MoveOrCopyDisk
by amureini＠redhat.com 27 Mar '13

27 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed unused method in MoveOrCopyDisk ...................................................................... core: Removed unused method in MoveOrCopyDisk Removed MoveOrCopyDiskCommand.doesStorageDomainHaveSpaceForRequest(long), which is not used anywhere in the code. Change-Id: I12e0ed58810bf87342cc06db4b7cec4c527b6ff5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java 2 files changed, 2 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12e0ed58810bf87342cc06db4b7cec4c527b6ff5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove VmRunHandler.getPluggedDisks(VM)
by amureini＠redhat.com 27 Mar '13

27 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove VmRunHandler.getPluggedDisks(VM) ...................................................................... core: Remove VmRunHandler.getPluggedDisks(VM) Removed VmRunHandler.getPluggedDisks(VM) and replaced it with a direct DAO call DiskDao.getAllForVm(vmId, true). This approach has better performance (since all the filtering is done in the database, and there is no roundtrip via Java) and leaves the code easier to understand (there's just less of it). This patch includes: 1. A new method in DiskDAO - getAllForVm(Guid vmId, boolean onlyPlugged), its filtered counterpart, the underlying stored procedure (naturally), and tests for this method. 2. Removing VmRunHandler.getPluggedDisks(VM) 3. Changing all the usages of VmRunHandler (i.e., CreateAllSnapshotsFromVmCommand and VmRunHandler itself). Change-Id: I55052dad87a552df200039e111fd0dd6658f6ae8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/all_disks_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskLunMapDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 11 files changed, 132 insertions(+), 88 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55052dad87a552df200039e111fd0dd6658f6ae8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: removed redundant BigDecimal instantiations
by lhornyak＠redhat.com 27 Mar '13

27 Mar '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: removed redundant BigDecimal instantiations ...................................................................... engine: removed redundant BigDecimal instantiations Since BigDecimal is immutable, new BigDecimal(0) can be replaced bu BigDecimal.ZERO Change-Id: I416da2e5a87cc9a4cec4a762d5da74bddb201298 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I416da2e5a87cc9a4cec4a762d5da74bddb201298 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: remove redundant check from setter in VmTemplate
by lhornyak＠redhat.com 27 Mar '13

27 Mar '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: remove redundant check from setter in VmTemplate ...................................................................... engine: remove redundant check from setter in VmTemplate checking if the status the same or the old value was null is not needed in setters Change-Id: I9fca59c0684afab7c7f1944ec1997b361257c6b0 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fca59c0684afab7c7f1944ec1997b361257c6b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: remove unused logger from Domain
by lhornyak＠redhat.com 27 Mar '13

27 Mar '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: remove unused logger from Domain ...................................................................... engine: remove unused logger from Domain logger was not used, it was removed Change-Id: I50612ed1aa6756e497da70ac58b23294e6efaf35 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/Domain.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Michael Kublin: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50612ed1aa6756e497da70ac58b23294e6efaf35 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: remove unused logger from VmRunHandler
by lhornyak＠redhat.com 27 Mar '13

27 Mar '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: remove unused logger from VmRunHandler ...................................................................... engine: remove unused logger from VmRunHandler logger was not used, it was removed Change-Id: Iad286a26d01341f43e2930e1a2e53e0d411e456a Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Michael Kublin: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13364 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad286a26d01341f43e2930e1a2e53e0d411e456a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: remove unused VmPayload constructor
by lhornyak＠redhat.com 27 Mar '13

27 Mar '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: remove unused VmPayload constructor ...................................................................... engine: remove unused VmPayload constructor VmPayload constructor was never used, removing it also gets rid of a deprecated method call. Change-Id: I4e78d7f6edf4d043098aae936782e2466ee15221 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Michael Kublin: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e78d7f6edf4d043098aae936782e2466ee15221 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: remove SimpleJdbcTemplate
by lhornyak＠redhat.com 27 Mar '13

27 Mar '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: remove SimpleJdbcTemplate ...................................................................... engine: remove SimpleJdbcTemplate Since spring 3.1, the SimpleJdbcTemplate class does the same as JdbcTemplate, therefore wrapping JdbcTemplate is not needed anymore and SimpleJdbcTemplate is deprecated. This patch removes the wrapping SimpleJdbcTemplates from DAO implementations. Change-Id: I8782d8790ee682b64d2b14af8840f90b7b7216a9 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkViewDaoDbFacadeImpl.java 15 files changed, 15 insertions(+), 31 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Michael Kublin: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8782d8790ee682b64d2b14af8840f90b7b7216a9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0