Change in ovirt-reports[master]: packaging: Use engine.conf for local configuration
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: Use engine.conf for local configuration
......................................................................
packaging: Use engine.conf for local configuration
Commit 5a3141 of ovirt-engine moved the local configuration from
/etc/sysconfig/ovirt-engine to /etc/ovirt-engine/engine.conf so the
reports application needs to be modified accordingly.
Change-Id: I824a61772325b4d29ceceb95933309e16f0d2435
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M packaging/ovirt-engine-reports-setup.py
1 file changed, 13 insertions(+), 14 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12614
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I824a61772325b4d29ceceb95933309e16f0d2435
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: engine: Vds initializyng- query improvements
by mkublin@redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Vds initializyng- query improvements
......................................................................
engine: Vds initializyng- query improvements
The following patch is doing a following:
1. Remove duplicate query for vds, in order to retrieve it name
2. Replaced query in loop: from getVds() to getVdsDynamic().
getVdsDynamic() query is faster, and retrirves data only from one single table
3. Fixing error log mesage
Change-Id: Iea601133e62927bc2808feb2f56efd9fb0e675d0
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
1 file changed, 18 insertions(+), 16 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12813
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea601133e62927bc2808feb2f56efd9fb0e675d0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: engine: IrsBroker - code clean up
by mkublin@redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: IrsBroker - code clean up
......................................................................
engine: IrsBroker - code clean up
Code is cleaned. Change is obvious.
Change-Id: I3818a9ec43df939f293630853a99348811aa7127
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
1 file changed, 4 insertions(+), 6 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12814
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3818a9ec43df939f293630853a99348811aa7127
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: prevent VM creation from Template while removing its d...
by mkublin@redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: prevent VM creation from Template while removing its disks
......................................................................
core: prevent VM creation from Template while removing its disks
In what seems to be a hack, we set a flag for not checking template
images in some commands. the problem is that the template images might
be locked for a good reason - like in case the images are really being
removed.
This patch prevents it from happening for addVmFromTemplateCommand: when
removing a disk we now take exclusive lock for that disk for the whole
execution of the command (RemoveDiskCommand). at AddVmFromTemplate we
now take shared lock for each of the template's disks - thus it won't
be possible to acquire the locks if one of the disks is being removed.
Change-Id: I8736751bbfea927072b2ade91ee3d9511e266501
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 46 insertions(+), 38 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13016
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8736751bbfea927072b2ade91ee3d9511e266501
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-host-deploy[master]: doc: pki: update environment documentation
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: doc: pki: update environment documentation
......................................................................
doc: pki: update environment documentation
Change-Id: Id7c8fde4165ec85940d2f05ea53570f63813f011
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M README.environment
1 file changed, 12 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13047
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7c8fde4165ec85940d2f05ea53570f63813f011
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: host-deploy: do not use flood prevention mechanism
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: host-deploy: do not use flood prevention mechanism
......................................................................
host-deploy: do not use flood prevention mechanism
All messages are important, random drop of messages makes user
interaction uncleared.
This is a revert of I653e.
Change-Id: Idd818aad013a6947d27b9e64acc81bf86705be35
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13029
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd818aad013a6947d27b9e64acc81bf86705be35
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: packaging: fix /etc/ovirt-engine/engine.conf.d permissions
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: fix /etc/ovirt-engine/engine.conf.d permissions
......................................................................
packaging: fix /etc/ovirt-engine/engine.conf.d permissions
Change-Id: I9ecc451c4cf64c33724fb94e472b5135c10efc5f
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12796
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ecc451c4cf64c33724fb94e472b5135c10efc5f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: Failed install DB during oVirt-setup...
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Failed install DB during oVirt-setup...
......................................................................
core: Failed install DB during oVirt-setup...
Failed install DB during oVirt-setup not on clean server
This patch adds a utility encodingvalidator.sh that can be used to
validate that template1 database encoding is UTF8
If template1 database has any other encoding, giving this utility the -f
flag will fix the problem.
Since we were not able to reproduce the BZ, it was agreed that supplying
this utility and calling it from the installer in the
pre-install/upgrade step is sufficient to resolve this problem.
Change-Id: I74dd62ec2c0f96d719b15848da4e08d8f6cc5068
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
A backend/manager/tools/dbutils/encodingvalidator.sh
1 file changed, 119 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74dd62ec2c0f96d719b15848da4e08d8f6cc5068
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: engine: connectStorageServer is not sent for inactive domain...
by mkublin@redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: connectStorageServer is not sent for inactive domains before connectStoragePool
......................................................................
engine: connectStorageServer is not sent for inactive domains before connectStoragePool
During start up of host a host was not conneted to InActive domains.
This is wrong, because of host can actually see InActive domains, so connect should be sent to all
Active, Uknown and InActive domains
Change-Id: Ibb3710bb83ef81485715577ae939014ffcae693f
Bug-Url: https://bugzilla.redhat.com/917576
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/dbscripts/storages_san_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePooServerCommandBase.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDAOTest.java
5 files changed, 15 insertions(+), 14 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12805
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb3710bb83ef81485715577ae939014ffcae693f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: engine: Guaranteed memory not propagated to export storage
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Guaranteed memory not propagated to export storage
......................................................................
engine: Guaranteed memory not propagated to export storage
Min. allocated memory value for VM template not stored in export
storage domain fixed.
Storing of min. allocated memory value for VM template extracted
to common code base shared with VM export (XML transfer format).
Change-Id: Idc06026d1dc92236fe2a25c3bde25023ad4d5861
Signed-off-by: Libor Spevak <lspevak(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
4 files changed, 11 insertions(+), 10 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc06026d1dc92236fe2a25c3bde25023ad4d5861
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com>
Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 8 months