March 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: engine: Allow Import/Snapshot Duplicate MAC Address

by msalem＠redhat.com

Muli Salem has submitted this change and it was merged. Change subject: engine: Allow Import/Snapshot Duplicate MAC Address ...................................................................... engine: Allow Import/Snapshot Duplicate MAC Address This patch, allows importing/previewing a VM with a network interface with an existing MAC address, even though the AllowDuplicateMacAddresses flag is false. Instead of failing the command, we simply unplug the network interface. When user tries to plug in the interface, we will fail the action unless the above flag is true. Change-Id: I269157b37426942331002c33a22fa354ba0cf39e Bug-Url: https://bugzilla.redhat.com/873338 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 10 files changed, 104 insertions(+), 42 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I269157b37426942331002c33a22fa354ba0cf39e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Validate Dup MAC Addresses upon Iface Plug

by msalem＠redhat.com

Muli Salem has submitted this change and it was merged. Change subject: engine: Validate Dup MAC Addresses upon Iface Plug ...................................................................... engine: Validate Dup MAC Addresses upon Iface Plug This patch validates that there are no plugged network interfaces with the same MAC address as the network interface that is being plugged. This validation is needed, since when importing or taking a snapshot of VM with a network interface that has a duplicate MAC address, we unplug the network interface and do not fail the action. Change-Id: If1476e8bec112c0c592e5cc16deefcf67076f5dc Bug-Url: https://bugzilla.redhat.com/873338 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/dbscripts/network_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoTest.java 6 files changed, 69 insertions(+), 1 deletion(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1476e8bec112c0c592e5cc16deefcf67076f5dc Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: userportal: auto-connect selected only works once per browse...

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: auto-connect selected only works once per browser session ...................................................................... userportal: auto-connect selected only works once per browser session Steps to Reproduce: 1. Go to the user portal, where the user only has one VM that is up, have the Connect Automatically checkbox selected, and login. 2. Logout and repeat. The console pops up only once in the extended view (with basic view it works as expected). The bug depended on the order of initializing MainTabBasicPresenter and MainTabExtendedPresenter classes. These classes handle unregistering and registering listeners for auto-connect on UserPortalModelInit event. When the MTExtendedPresenter was loaded first, the MTBasicPresenter unregistered its listeners, so the auto-connect logic could't be invoked (the auto-connection occured when user clicked on "basic" tab). There was a flaw in ConnectAutomaticManager. It tried to auto-connect to a machine, that was strictly in up state, which is correct for basic view. For extended view, however, the feature must also work when there is a single running machine (that cannot be strictly in the up state [can be also powering up, rebooting...]). This patch changes this behavior of ConnectAutomaticallyManager - now it auto-connects to the machine, which is running. Change-Id: If93181166d2e3f63c0074594cb94002802499414 Bug-Url: https://bugzilla.redhat.com/867134 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/MainTabBasicPresenter.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/utils/ConnectAutomaticallyManager.java 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If93181166d2e3f63c0074594cb94002802499414 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: userportal: don't pass ctrl+alt+delete for win>7

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: don't pass ctrl+alt+delete for win>7 ...................................................................... userportal: don't pass ctrl+alt+delete for win>7 Don't pass the ctrl+alt+del for win 7 or newer client. This has already been implemented, but on the level of ConsolePopupPresenterWidget which is not enogh - it was executed only after opening the consonle popup. But if the user pressed the connect button, without opening the the console popup, the ctrl+alt+delete was passed to the guest. This patch moves this logic to SpiceConsoleModel. Change-Id: I09c45cb30577e84830b6e82d79d2bb7ef7455b1b Bug-Url: https://bugzilla.redhat.com/918650 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/console/ConsolePopupPresenterWidget.java 3 files changed, 49 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09c45cb30577e84830b6e82d79d2bb7ef7455b1b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: pki: preserve template files during upgrade

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: pki: preserve template files during upgrade ...................................................................... pki: preserve template files during upgrade In the past, pki template files were installed as %config but were modified by both install and users now we install a template of these files as %config. Keep publish these files are %ghost. Change-Id: I88e83b79a5a35060e41ff8356f31fffd5219f6ad Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88e83b79a5a35060e41ff8356f31fffd5219f6ad Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[engine_3.2]: packaging: ovirt-engine-3.2.1-1

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: ovirt-engine-3.2.1-1 ...................................................................... packaging: ovirt-engine-3.2.1-1 update version file to 3.2.1-1 Change-Id: I06d151fc2f2b3770457fd33bafc4cde8266cfaad Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Ofer Schreiber: Verified -- To view, visit http://gerrit.ovirt.org/13012 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06d151fc2f2b3770457fd33bafc4cde8266cfaad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: build: set tools log4j log location by build configuration

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: build: set tools log4j log location by build configuration ...................................................................... build: set tools log4j log location by build configuration Change-Id: I65efe71c3c0a4241e51ed3eaa4c6b51b000ff993 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile R backend/manager/tools/src/main/conf/engine-config-log4j.xml.in R backend/manager/tools/src/main/conf/engine-manage-domains-log4j.xml.in R backend/manager/tools/src/main/conf/engine-notifier-log4j.xml.in 5 files changed, 9 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65efe71c3c0a4241e51ed3eaa4c6b51b000ff993 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: build: always clean maven output before build

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: build: always clean maven output before build ...................................................................... build: always clean maven output before build If snapshots (timestamp) are used then we get more than one artifact if make clean is not run. This confuses: X=`find "$(MAVEN_OUTPUT_DIR)" -name 'engine-server-ear-$(POM_VERSION)*'.ear` && unzip -o "$$X" -d "$(DESTDIR)$(PKG_EAR_DIR)" Change-Id: I6db059914f94bfab95cf444a0485a8f73a2719f3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6db059914f94bfab95cf444a0485a8f73a2719f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Removing useless null check

by mkublin＠redhat.com

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing useless null check ...................................................................... engine: Removing useless null check The following check is useless, but causing for failure of find bugs Change-Id: Ia0e5ba1b9bc0484edafe9a5a88f6f5b599e3202f Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0e5ba1b9bc0484edafe9a5a88f6f5b599e3202f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: use conf.d notation in shell utilities

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: use conf.d notation in shell utilities ...................................................................... packaging: use conf.d notation in shell utilities Change-Id: Icb03986e385cf786fa191095ad7fcc443d2f1199 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-prolog.sh.in 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb03986e385cf786fa191095ad7fcc443d2f1199 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

11 years, 8 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits March 2013