Change in ovirt-engine[master]: webadmin: VmGuideModel - remove redundant code
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: VmGuideModel - remove redundant code
......................................................................
webadmin: VmGuideModel - remove redundant code
Removing no longer needed code from VmGuideModel
(add disk logic is already in DiskModel).
Change-Id: I387558c053f02e14465fda1e3518fd0c9d683d4f
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java
1 file changed, 6 insertions(+), 149 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12581
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I387558c053f02e14465fda1e3518fd0c9d683d4f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: disable everyone for login
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: disable everyone for login
......................................................................
core: disable everyone for login
If the "everyone" has assignd a role which contains login,
from this point everyone is allowed to log in.
In this specific bug the NetworkUser has been assigned to
everyone which contained the login. This caused that everyone
was allowed to log in. This issue did not happened the first time
so this patch solves it in a more generic way - ignores the
everyone when checking if the user is allowed to log in.
Change-Id: I7bba37a450efdd9e3475470e4ed8f49347c51a2e
Bug-Url: https://bugzilla.redhat.com/916328
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/dbscripts/multi_level_administration_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java
5 files changed, 12 insertions(+), 9 deletions(-)
Approvals:
Tomas Jelinek: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12830
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bba37a450efdd9e3475470e4ed8f49347c51a2e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: removing deprecated GetDiskConfigurationListQuery
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: removing deprecated GetDiskConfigurationListQuery
......................................................................
core: removing deprecated GetDiskConfigurationListQuery
GetDiskConfigurationListQuery is not used anymore by client:
Therefore, removing the following:
* GetDiskConfigurationListQuery
* GetDiskConfigurationListQueryTest
* DiskConfigurationList ConfigValue.
Change-Id: I8d750e63454096e4da0f7c4efdf229f7f06ac169
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskConfigurationListQuery.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDiskConfigurationListQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
5 files changed, 1 insertion(+), 175 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12580
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d750e63454096e4da0f7c4efdf229f7f06ac169
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: webadmin: DiskModel - naming convention cleanup
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: DiskModel - naming convention cleanup
......................................................................
webadmin: DiskModel - naming convention cleanup
DiskModel:
* Renamed variable names (Java conventions).
* Reorganized variables getters/setters (and remove redundant).
* Removed redundant call to deprecated GetDiskPresetList.
(removed GetDiskPresetList from AsyncDataProvider).
Change-Id: Iac9d635a411a0f7d54cc0e316ac831f0823df3d0
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java
6 files changed, 314 insertions(+), 495 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac9d635a411a0f7d54cc0e316ac831f0823df3d0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: tools: don't rely on Connection.isValid()
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: tools: don't rely on Connection.isValid()
......................................................................
tools: don't rely on Connection.isValid()
Patch 9f856a6234566a2ab648ef580fa102192ec43b10 refactored
StandaloneDataSource.checkConnection() to use Connection.isValid() in
order to avoid a FindBugs warning on an unused function result.
Apparently, this approach is problematic since the PostgreSQL JDBC
driver we're using does not implement isValid().
This patch reverts 9f856a6234566a2ab648ef580fa102192ec43b10 and proposes
a different way to avoid the FindBugs warning.
Change-Id: Ic4f1fe6a9981c6fe8764a803eda4de5d51cc2b6e
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java
1 file changed, 20 insertions(+), 4 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4f1fe6a9981c6fe8764a803eda4de5d51cc2b6e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core, restapi: Alias for registered disk
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core,restapi: Alias for registered disk
......................................................................
core,restapi: Alias for registered disk
Change-Id I82de498fd9a8e25ed9e1dc5776f2fdf0c35b46da introduced a new
operation, registering an unregistered disk (i.e., a disk that exists on
the storage domain but not in the engine's database).
Since disk aliases are an engine concept, the registered disk did not
have an alias, which is not a legal state in the engine.
This patch allows passing an alias when registering a disk, and
auto-generates an alias ("RegisteredDisk_{YYYY-MM-DD_hh-mm-ss}") if
it is not passed.
Change-Id: I6ab17da94ff7ff16852efb3a374148dacf1135f8
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RegisterDiskCommandTest.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResourceTest.java
6 files changed, 80 insertions(+), 12 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12565
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ab17da94ff7ff16852efb3a374148dacf1135f8
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Chris Morrissey <cmorriss(a)netapp.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: webadmin: Move enums to localized file
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Move enums to localized file
......................................................................
webadmin: Move enums to localized file
The MigrationSupport enums ware located in the wrong file and so could
not be localized.
Moved the enums to the correct file
Deleted redundant method from UnitVmModel
Change-Id: I87edacf6b3aa2180f1e8721b8f342ca04a648e3f
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
7 files changed, 11 insertions(+), 15 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12808
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87edacf6b3aa2180f1e8721b8f342ca04a648e3f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 8 months
Change in ovirt-engine-sdk-java[master]: sdk: release 1.0.0.5-1
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: release 1.0.0.5-1
......................................................................
sdk: release 1.0.0.5-1
- use explicit classloader for JAXBContext
- implement support for (user defined) session authentication
- implement generic JAXBElement generation
- to DataCenterStorageDomain added Disks sub-collection
- to StorageDomain added Disks sub-collection
- to host added display.address property
- to vms.add() added overload for creating vm from snapshot
Change-Id: Ieacf28f105ac07548bcc91d21426721a5a3a7755
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12822
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieacf28f105ac07548bcc91d21426721a5a3a7755
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 8 months
Change in ovirt-engine-sdk-java[master]: sdk: cleanup
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: cleanup
......................................................................
sdk: cleanup
Change-Id: I8b2aaff5a6b7a21234e1fe329fd1d9a46f7eeaa2
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/utils/SerializationHelper.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12821
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b2aaff5a6b7a21234e1fe329fd1d9a46f7eeaa2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 8 months
Change in ovirt-engine-sdk-java[master]: sdk: code assumes the implicit use of the current classloade...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: code assumes the implicit use of the current classloader
......................................................................
sdk: code assumes the implicit use of the current classloader
We should instead use the classloader containing the ovirt packages.
Change-Id: I651e7c0c87d8d45cb341d7e5eace87bd5e835ea4
Signed-off-by: Babak Mozaffari <bmozaffa(a)redhat.com>
---
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/utils/SerializationHelper.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12801
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I651e7c0c87d8d45cb341d7e5eace87bd5e835ea4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Babak Mozaffari <babak.mozaffari(a)gmail.com>
Gerrit-Reviewer: Babak Mozaffari <babak.mozaffari(a)gmail.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 8 months