Change in ovirt-host-deploy[master]: core: reduce the use of lists
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: reduce the use of lists
......................................................................
core: reduce the use of lists
Change-Id: I20ea91d7020596b4bf49b620e4a789a3a94eaf5f
Reported-By: Antoni Segura Puimedon <asegurap(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/plugins/ovirt-host-deploy/core/misc.py
M src/plugins/ovirt-host-deploy/core/offlinepackager.py
M src/plugins/ovirt-host-deploy/gluster/packages.py
M src/plugins/ovirt-host-deploy/vdsm/bridge.py
M src/plugins/ovirt-host-deploy/vdsm/packages.py
5 files changed, 8 insertions(+), 8 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17498
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20ea91d7020596b4bf49b620e4a789a3a94eaf5f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: backend: ExportRepoImageParameters default constructor
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: backend: ExportRepoImageParameters default constructor
......................................................................
backend: ExportRepoImageParameters default constructor
This fixes a weird serialization/deserialization issue that resulted
in destinationDomainId to be null.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=987986
Change-Id: I63556883c8d81ce3914feac5a76d102d3964c678
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ExportRepoImageParameters.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17342
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63556883c8d81ce3914feac5a76d102d3964c678
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in otopi[master]: core: pyflakes-0.7.2 compatibility
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: pyflakes-0.7.2 compatibility
......................................................................
core: pyflakes-0.7.2 compatibility
it does not execute __init__.py or not use builtins?
Change-Id: I21816fdba8b3734854659944262f52833af4786c
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/otopi/common.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17497
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21816fdba8b3734854659944262f52833af4786c
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 3 months
Change in otopi[master]: core: reduce the use of lists
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: reduce the use of lists
......................................................................
core: reduce the use of lists
apparently the default object initialization is happening once per
process execution, so must be avoided.
also reduce other usages.
Change-Id: I33078e67c7235f9cdd7e82e1ec2714a5f90426b2
Reported-By: Antoni Segura Puimedon <asegurap(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/otopi/filetransaction.py
M src/otopi/miniyum.py
M src/otopi/plugin.py
M src/otopi/transaction.py
M src/plugins/otopi/dialog/cli.py
M src/plugins/otopi/network/hostname.py
M src/plugins/otopi/packagers/yumpackager.py
M src/plugins/otopi/services/openrc.py
M src/plugins/otopi/services/rhel.py
M src/plugins/otopi/services/systemd.py
10 files changed, 20 insertions(+), 19 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17496
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I33078e67c7235f9cdd7e82e1ec2714a5f90426b2
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: host-deploy: InstallVdsCommand: remove redundant case
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: host-deploy: InstallVdsCommand: remove redundant case
......................................................................
host-deploy: InstallVdsCommand: remove redundant case
switch is going over all cases, in case of 'default' we actually have
internal error.
having case without break with logic within is not best practice for
procedural programming as there are two entries into single block.
for now just remove that case.
Change-Id: I45a7294e582ed24159d749be069533fb5f44f855
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45a7294e582ed24159d749be069533fb5f44f855
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-engine[master]: host-deploy: sync node upgrade to vds deploy
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: host-deploy: sync node upgrade to vds deploy
......................................................................
host-deploy: sync node upgrade to vds deploy
during the move to network processing within engine, the node upgrade
and vds deploy became out of sync, it could have been easily been solved
by adding handleError(e, VDSStatus.InstallFailed) at exception handler,
however better to sync the two.
Change-Id: Ie1c2733597f0d7408dd0b863b42412b479dfcd15
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java
2 files changed, 34 insertions(+), 39 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17415
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1c2733597f0d7408dd0b863b42412b479dfcd15
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-engine[master]: host-deploy: InstallVdsCommand: reformat to consistent forma...
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: host-deploy: InstallVdsCommand: reformat to consistent format
......................................................................
host-deploy: InstallVdsCommand: reformat to consistent format
Change-Id: I5281201002b8e786e486f606a48e2f069d49a6df
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
1 file changed, 103 insertions(+), 76 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17413
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5281201002b8e786e486f606a48e2f069d49a6df
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-engine[master]: host-deploy: ssh: use apache commons Hex instead of j2se
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: host-deploy: ssh: use apache commons Hex instead of j2se
......................................................................
host-deploy: ssh: use apache commons Hex instead of j2se
although javax.xml.bind.DatatypeConverter is part of j2se[1], it is missing
from jboss rhev environment.
java.lang.NoClassDefFoundError: javax/xml/bind/DatatypeConverter
at org.ovirt.engine.core.utils.ssh.SSHClient._validateDigest(SSHClient.java:97) [utils.jar:]
at org.ovirt.engine.core.utils.ssh.SSHClient.sendFile(SSHClient.java:625) [utils.jar:]
at org.ovirt.engine.core.utils.ssh.SSHDialog.sendFile(SSHDialog.java:361) [utils.jar:]
resolution is to use apache commons Hex to decode hex instead.
[1] http://docs.oracle.com/javase/7/docs/api/javax/xml/bind/DatatypeConverter...
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=987891
Change-Id: Ie57b334d152da9e20ce556f801d48b836378fa7b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17412
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie57b334d152da9e20ce556f801d48b836378fa7b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-engine[master]: HostGeneralModel: improve "node has upgrade" logic
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: HostGeneralModel: improve "node has upgrade" logic
......................................................................
HostGeneralModel: improve "node has upgrade" logic
This patch will add a validation to compare Node iso version against
ISOs available in oVirt Engine. If ISOs on Engine are higher,
then show to users that we have new upgrade available.
Change-Id: I49c74d3d0d92c74848e0c175095610b6e6b5a88e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=911347
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
1 file changed, 29 insertions(+), 10 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16089
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I49c74d3d0d92c74848e0c175095610b6e6b5a88e
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-engine[master]: restapi: Add Test for adding VmPool via REST
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Add Test for adding VmPool via REST
......................................................................
restapi: Add Test for adding VmPool via REST
Change-Id: I3f91f937bd6302af7f9f96fe7b3c7dfd614c2437
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResourceTest.java
1 file changed, 131 insertions(+), 0 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14560
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f91f937bd6302af7f9f96fe7b3c7dfd614c2437
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months