Change in ovirt-engine[master]: restapi: Apply template on VmPool creation using REST API
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Apply template on VmPool creation using REST API
......................................................................
restapi: Apply template on VmPool creation using REST API
The BackendVmPoolsResource.mapToVM method ignored the supplied template.
Now it maps the VmTemplate to VmStatic and supplies it to VM that has
client-supplied changes applied to it.
Change-Id: Ibe3939662562aadaee68ae423beb824c3487b01e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=948775
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java
1 file changed, 8 insertions(+), 6 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13639
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe3939662562aadaee68ae423beb824c3487b01e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-dwh[master]: packaging: setup: fixed password handling for configuration
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: fixed password handling for configuration
......................................................................
packaging: setup: fixed password handling for configuration
Current implementation parses database configuration file
and takes the engine password as it appears in the config.
The file includes " characters which leads to problems for
dwh.
New implementation removes " chars before configuring own
service file.
Change-Id: I8f92fae08d86fbc1536a9bdc139ae8df1147e0d1
Bug-Url: https://bugzilla.redhat.com/990124
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/ovirt-engine-dwh-setup.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17479
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f92fae08d86fbc1536a9bdc139ae8df1147e0d1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 3 months
Change in ovirt-iso-uploader[ovirt-iso-uploader-3.2]: upload: nfs: set correct umask while renaming
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: upload: nfs: set correct umask while renaming
......................................................................
upload: nfs: set correct umask while renaming
set the correct umask while renaming the temporary
file to destination file. Avoid to have incorrect
access bits on systems with not standard umask
(like 077)
(cherry picked from c97c0f0a0c8617042698665ec98a39ad89938647)
Change-Id: I5b7401f91e5fb4ce604ff17209e7c1260dd57503
Bug-Url: https://bugzilla.redhat.com/990144
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/__main__.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Alex Lourie: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/17485
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b7401f91e5fb4ce604ff17209e7c1260dd57503
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: ovirt-iso-uploader-3.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: restapi: Display type is not inherited correctly from templa...
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Display type is not inherited correctly from templates
......................................................................
restapi: Display type is not inherited correctly from templates
In API, default display type is applied to a new VM when created from a
template with a different display type.
Fixed by correcting corresponding mapper class.
Change-Id: I61b410f258afb529d7309d0f68f223d4984c0514
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=986668
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61b410f258afb529d7309d0f68f223d4984c0514
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-iso-uploader[master]: upload: nfs: set correct umask while renaming
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: upload: nfs: set correct umask while renaming
......................................................................
upload: nfs: set correct umask while renaming
set the correct umask while renaming the temporary
file to destination file. Avoid to have incorrect
access bits on systems with not standard umask
(like 077)
Change-Id: I5b7401f91e5fb4ce604ff17209e7c1260dd57503
Bug-Url: https://bugzilla.redhat.com/988146
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/__main__.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Alex Lourie: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/17411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b7401f91e5fb4ce604ff17209e7c1260dd57503
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: API: Adding mapping between host and action parameters and u...
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: API: Adding mapping between host and action parameters and using username field
......................................................................
API: Adding mapping between host and action parameters and using username field
Using username field when specified. When both password and rootPassword
are specified, prefer the rootPassword for backward compatibility.
Using HostMapper for mapping action and host objects to operation's parameters
in update, install, approve host actions.
Change-Id: Ifc7f6ba85ed6a5a790b3cc0acce3f5d6eb305789
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
4 files changed, 64 insertions(+), 41 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17194
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc7f6ba85ed6a5a790b3cc0acce3f5d6eb305789
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 3 months
Change in ovirt-scheduler-proxy[master]: added clean target
by lhornyak@redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: added clean target
......................................................................
added clean target
removes pyc files from source
Change-Id: I51567dcfcaff0b597d1fabd6bb48dae27fd6e9eb
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M Makefile
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51567dcfcaff0b597d1fabd6bb48dae27fd6e9eb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-scheduler-proxy
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
11 years, 3 months
Change in ovirt-host-deploy[master]: openstack: neutron: convert keys to strings
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: openstack: neutron: convert keys to strings
......................................................................
openstack: neutron: convert keys to strings
engine sends integers instead of strings for configuration, make sure
these are converted to strings.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=989915
Change-Id: I8dc4d250f9d143d5b56af74a7df680970b4cf107
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/plugins/ovirt-host-deploy/openstack/neutron.py
M src/plugins/ovirt-host-deploy/openstack/neutron_linuxbridge.py
M src/plugins/ovirt-host-deploy/openstack/neutron_openvswitch.py
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
Meni Yakove: Verified
--
To view, visit http://gerrit.ovirt.org/17457
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8dc4d250f9d143d5b56af74a7df680970b4cf107
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: restapi : error translation is broken (#987848)
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi : error translation is broken (#987848)
......................................................................
restapi : error translation is broken (#987848)
backend error translation is broken
Actual results:
[var action run, var type vm, vm cannot ...]
Expected results:
translated error according to apperrors properties
Change-Id: I365e02c03ef7c8412fdf634e41e7d8ad61b0d804
Bug-Url: https://bugzilla.redhat.com/987848
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17323
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I365e02c03ef7c8412fdf634e41e7d8ad61b0d804
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core: Change misleading audit log message.
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Change misleading audit log message.
......................................................................
core: Change misleading audit log message.
SYSTEM_CHANGE_STORAGE_POOL_STATUS_NO_HOST_FOR_SPM is called when
An spm is non responsive and and fencing it fails.
Changing text to: "Fencing failed on Storage Pool Manager ${VdsName}
for Data Center ${StoragePoolName}. Setting status to Non-Operational."
Change-Id: Ib3653ed1ac9dae8779c2abfe788d4aafaa48ed28
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=954301
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17407
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3653ed1ac9dae8779c2abfe788d4aafaa48ed28
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: liron aravot <liron.aravot(a)gmail.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
11 years, 3 months