Change in ovirt-engine[master]: core: Cluster parameters override - OVF
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Cluster parameters override - OVF
......................................................................
core: Cluster parameters override - OVF
This feature allows to configure the 'emulated machine' and 'cpu model'
parameters for each VM separately instead of relying on the cluster default.
Change-Id: Ib772f8674ffb5297fbdce25f2fcf1121851a9def
Bug-Url: https://bugzilla.redhat.com/838487
Feature-page: http://www.ovirt.org/Features/Cluster_parameters_override
Signed-off-by: Eldan Shachar <eshachar(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
3 files changed, 24 insertions(+), 0 deletions(-)
Approvals:
Eldan Shachar: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32547
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib772f8674ffb5297fbdce25f2fcf1121851a9def
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: Cluster parameters override - fields\db
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Cluster parameters override - fields\db
......................................................................
core: Cluster parameters override - fields\db
This feature allows to configure the 'emulated machine' and 'cpu model'
parameters for each VM separately instead of relying on the cluster default.
Change-Id: I64d829aa6a68b1c97fb59d2a7a21351a00c92c40
Bug-Url: https://bugzilla.redhat.com/838487
Feature-page: http://www.ovirt.org/Features/Cluster_parameters_override
Signed-off-by: Eldan Shachar <eshachar(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/InstanceType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidI18NExtraName.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDaoDbFacade.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CustomInstanceType.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_06_0540_add_cluster_parameters_override_to_vm.sql
M packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql
M packaging/dbscripts/vm_templates_sp.sql
M packaging/dbscripts/vms_sp.sql
23 files changed, 302 insertions(+), 28 deletions(-)
Approvals:
Eldan Shachar: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32546
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64d829aa6a68b1c97fb59d2a7a21351a00c92c40
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: Revert "core: Store iSCSI Target Address instead of IP Addre...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: Revert "core: Store iSCSI Target Address instead of IP Address in DB"
......................................................................
Revert "core: Store iSCSI Target Address instead of IP Address in DB"
This reverts commit c6c9bdb239042ca0ab4543d154d5144740ba4379.
The idea of working with the original address we get from the user
instead of the IP address we get from VDSM works fine in case that the
iscsi server has only one NIC. When it has more than one (Multipath, for
example) the VDSM sends all the addresses it discovered, and we override
all of them with the original address we got from the user. This makes
the login to all of the other targets fail (except for the first one).
Thus, working with the original address is not possible.
Change-Id: I3974820e9039f05aa716752330c1b2ec13591137
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1086310
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DiscoverSendTargetsVDSCommand.java
1 file changed, 1 insertion(+), 11 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit http://gerrit.ovirt.org/35291
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3974820e9039f05aa716752330c1b2ec13591137
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-engine[ovirt-engine-3.5]: core: Create PairQueryable ID without UUID serialization
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Create PairQueryable ID without UUID serialization
......................................................................
core: Create PairQueryable ID without UUID serialization
As it turns out, serializing a UUID is a resource-consuming operation,
and is not in fact required to compute a unique ID for a PairQueryable
object. The mechanism is therefore swapped for a more efficient one,
while maintaining the form of the serialized ID (in case it is needed
somewhere, though that does not seem to be the case).
The new ID is represented by a new class PairQueryableId which isn't
but a Pair of objects - the corresponding IDs of the PairQueryable
members. PairQueryableId.toString() maintains the serialized form
previously returned from getQueryableId(): "ID1.ID2" (as opposed to
the standard Pair serialization).
Change-Id: Ibf0776567c5ef7f20830c70617dc69806cce3a6b
Bug-Url: https://bugzilla.redhat.com/1123396
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/Pair.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PairQueryable.java
2 files changed, 28 insertions(+), 5 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Moti Asayag: Looks good to me, but someone else must approve
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/35265
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf0776567c5ef7f20830c70617dc69806cce3a6b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.5]: engine: Invalid locale found in configuration ''
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Invalid locale found in configuration ''
......................................................................
engine: Invalid locale found in configuration ''
- Fixed info message warning showing up in log. This was due
to missing entry in database, and missing check for blank.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165073
Change-Id: Icae51fdd5427069281ac3d2147af797813228edb
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/UnsupportedLocaleHelper.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
2 files changed, 13 insertions(+), 8 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Eli Mesika: Looks good to me, but someone else must approve
Alexander Wels: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35267
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icae51fdd5427069281ac3d2147af797813228edb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: don't check for null serverity, forbid it.
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: core: don't check for null serverity, forbid it.
......................................................................
core: don't check for null serverity, forbid it.
we can controll that null severity of AuditLogType will not exist,
which is better than checking if it's null.
Change-Id: Ic44fb1683bacfa1c0f992ad4f272c3bb56526836
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
2 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30041
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic44fb1683bacfa1c0f992ad4f272c3bb56526836
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: restapi: display indication if vm is in run-once
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: display indication if vm is in run-once
......................................................................
restapi: display indication if vm is in run-once
Added a field to the VM REST query to indicate if the
vm is running in run-once mode.
Change-Id: I69a502a196aed2382acc35302004ea3b7cd89909
Bug-Url: https://bugzilla.redhat.com/1158357
Signed-off-by: Eldan Shachar <eshachar(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Eldan Shachar: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35261
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69a502a196aed2382acc35302004ea3b7cd89909
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: Proper reports SSO token
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: userportal,webadmin: Proper reports SSO token
......................................................................
userportal,webadmin: Proper reports SSO token
- Pass the right SSO token to the reports server when
loading the webadmin/userportal when already logged in.
Change-Id: I137a8c03815e9cf9e154bd21f11345383d64485f
Bug-Url: https://bugzilla.redhat.com/1164788
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Shirly Radco: Verified
Alexander Wels: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35268
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I137a8c03815e9cf9e154bd21f11345383d64485f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-guest-agent[ovirt-3.5]: sudoers: Fix of typo ovirt-shutdown-wrapper{s, }
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: sudoers: Fix of typo ovirt-shutdown-wrapper{s,}
......................................................................
sudoers: Fix of typo ovirt-shutdown-wrapper{s,}
Change-Id: I9247c6c2048a1f20f048c8232d2c18698a414073
Bug-Url: https://bugzilla.redhat.com/1155921
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
(cherry picked from commit e0e6e452f29730ea8c4a2dc889787e09e71c6bc7)
---
M scripts/sudoers.ovirt-guest-agent
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35282
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9247c6c2048a1f20f048c8232d2c18698a414073
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years
Change in ovirt-engine[master]: aaa: Adding auth and principal records on session
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: Adding auth and principal records on session
......................................................................
aaa: Adding auth and principal records on session
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1163147
Change-Id: Ide92b3832d5007be88465b09a7683bc1034aa6c1
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java
2 files changed, 20 insertions(+), 2 deletions(-)
Approvals:
Yair Zaslavsky: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35169
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide92b3832d5007be88465b09a7683bc1034aa6c1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years