November 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Create PairQueryable ID without UUID serialization
by lvernia＠redhat.com 18 Nov '14

18 Nov '14

Lior Vernia has submitted this change and it was merged. Change subject: core: Create PairQueryable ID without UUID serialization ...................................................................... core: Create PairQueryable ID without UUID serialization As it turns out, serializing a UUID is a resource-consuming operation, and is not in fact required to compute a unique ID for a PairQueryable object. The mechanism is therefore swapped for a more efficient one, while maintaining the form of the serialized ID (in case it is needed somewhere, though that does not seem to be the case). The new ID is represented by a new class PairQueryableId which isn't but a Pair of objects - the corresponding IDs of the PairQueryable members. PairQueryableId.toString() maintains the serialized form previously returned from getQueryableId(): "ID1.ID2" (as opposed to the standard Pair serialization). Change-Id: Ibf0776567c5ef7f20830c70617dc69806cce3a6b Bug-Url: https://bugzilla.redhat.com/1123396 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/Pair.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PairQueryable.java 2 files changed, 29 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, but someone else must approve Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/35198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf0776567c5ef7f20830c70617dc69806cce3a6b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: fix pep8 issues
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: setup: fix pep8 issues ...................................................................... packaging: setup: fix pep8 issues broken by I34b5c4ab5 Change-Id: I2ab030e8fdde5456e25e236b0174cbdc1a52b0dd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/image_upload.py 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Vered Volansky: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ab030e8fdde5456e25e236b0174cbdc1a52b0dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: mla: deny access to specific ID for users in user level API
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: mla: deny access to specific ID for users in user level API ...................................................................... mla: deny access to specific ID for users in user level API User who don't have manipulate_permission action group should not see users in system, even he shouldn't access them directly by their ID's. Change-Id: I90ec94fd0194680548e159f5d9bc010f5c233b91 Bug-Url: https://bugzilla.redhat.com/1160443 Signed-off-by: Ondra Machacek <machacek.ondra(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDbUserByUserIdQuery.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java M packaging/dbscripts/user_sp.sql 4 files changed, 21 insertions(+), 4 deletions(-) Approvals: Ondřej Macháček: Verified Eli Mesika: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90ec94fd0194680548e159f5d9bc010f5c233b91 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <machacek.ondra(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.ondra(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: Proper reports SSO token
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: userportal,webadmin: Proper reports SSO token ...................................................................... userportal,webadmin: Proper reports SSO token - Pass the right SSO token to the reports server when loading the webadmin/userportal when already logged in. Change-Id: I137a8c03815e9cf9e154bd21f11345383d64485f Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Shirly Radco: Looks good to me, but someone else must approve Alexander Wels: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I137a8c03815e9cf9e154bd21f11345383d64485f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: setup: Changing task cleaner utility to also handle removal ...
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: setup: Changing task cleaner utility to also handle removal of commands ...................................................................... setup: Changing task cleaner utility to also handle removal of commands The task cleaner utility now has the ability to present all commands or commands with running tasks, and to erase commands (or commands with running tasks) Bug-Url: https://bugzilla.redhat.com/1161012 Change-Id: I1d8f83cb7fc1f7fecb4ea68dff5cf0f3c63eeb6b Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/setup/dbutils/taskcleaner.sh M packaging/setup/dbutils/taskcleaner_sp.sql 2 files changed, 88 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d8f83cb7fc1f7fecb4ea68dff5cf0f3c63eeb6b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : CommandBase should not set end status for commands ...
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : CommandBase should not set end status for commands with callback ...................................................................... engine : CommandBase should not set end status for commands with callback When mixing async tasks and async commands if a callback is provided by the command the CommandBase should not set the status of the command. The command should override endSuccessfully and endWithFailure to set the status of the async tasks status to succeeded or failed. Change-Id: I84c05917003376d2f62d3da7acecd889f8cb79e0 Bug-Url: https://bugzilla.redhat.com/1160872 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 2 files changed, 39 insertions(+), 3 deletions(-) Approvals: Greg Padgett: Looks good to me, but someone else must approve Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84c05917003376d2f62d3da7acecd889f8cb79e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: make protocol visible during host edit
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: ui: make protocol visible during host edit ...................................................................... ui: make protocol visible during host edit We would like to see protocol set for a host in edit mode. The protocol is modifable only when a host is moved to maintanance mode. Change-Id: Ie9f6dc3f19ca0df0af4d7acdf7228e6e3c31ac61 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1162229 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9f6dc3f19ca0df0af4d7acdf7228e6e3c31ac61 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: dbscripts: drop index if exists
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: dbscripts: drop index if exists ...................................................................... packaging: dbscripts: drop index if exists drop index if exists using fn_db_create_index. Change-Id: Ibacd60bb90ba6e1213b4f0fcb4844aa36ff60fc7 Bug-Url: https://bugzilla.redhat.com/1155153 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 684206184f5632c151305e4ea429db01c5ca11cf) --- M packaging/dbscripts/upgrade/03_05_0720_index_for_stoarge_domain_id_in_unregistered_ovf_of_entities.sql M packaging/dbscripts/upgrade/03_05_1090_create_index_on_images.sql M packaging/dbscripts/upgrade/03_05_1100_create_index_on_vm_device.sql 3 files changed, 3 insertions(+), 5 deletions(-) Approvals: Yedidyah Bar David: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibacd60bb90ba6e1213b4f0fcb4844aa36ff60fc7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: dbscripts: drop index if exists
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: dbscripts: drop index if exists ...................................................................... packaging: dbscripts: drop index if exists drop index if exists using fn_db_create_index. Change-Id: Ibacd60bb90ba6e1213b4f0fcb4844aa36ff60fc7 Bug-Url: https://bugzilla.redhat.com/1155153 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/dbscripts/upgrade/03_05_0720_index_for_stoarge_domain_id_in_unregistered_ovf_of_entities.sql M packaging/dbscripts/upgrade/03_06_0440_create_index_on_images.sql M packaging/dbscripts/upgrade/03_06_0450_create_index_on_vm_device.sql 3 files changed, 3 insertions(+), 5 deletions(-) Approvals: Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibacd60bb90ba6e1213b4f0fcb4844aa36ff60fc7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Use existing Engine session for REST API integration
by piotr.kliczewski＠gmail.com 18 Nov '14

18 Nov '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Use existing Engine session for REST API integration ...................................................................... webadmin: Use existing Engine session for REST API integration Before this patch ================= * WebAdmin login triggers creation of separate (logical) Engine session through creation of new (physical) REST session using HTTP basic auth -> REST session is acquired using current WebAdmin user credentials -> REST session ID is provided to all UI plugins * above causes two separate user login operations with same credentials and therefore two "user has logged in" events in Engine server log * acquired (physical) REST session, as well as corresponding (logical) Engine session, are _NOT_ closed upon WebAdmin logout, even though these sessions were created with WebAdmin user credentials After this patch ================ * WebAdmin login _DOES NOT_ trigger creation of separate (logical) Engine session; instead, it reuses existing Engine user session -> REST session is still acquired, but instead of HTTP basic auth credentials, we're passing existing Engine session auth token to associate REST session with current user's Engine session -> REST session ID is provided to all UI plugins * above ensures single user login operation upon WebAdmin login * since acquired REST session maps to existing Engine session, WebAdmin user logout makes that REST session unusable, even if the REST session itself is still alive We use Prefer:new-auth to ensure that new REST session is created on each WebAdmin login. Important note for UI plugin developers ======================================= REST session ID passed to UI plugins via "RestApiSessionAcquired" hook, also represented by JSESSIONID cookie for /api, will become unusable after WebAdmin logout. Since UI plugins are active (invoked by the infra) only while the user is authenticated, this shouldn't impact UI plugins that use provided REST session (cookie) to talk directly with Engine. Change-Id: Ic3905b3b5834a0f7327321e93064274df0d1db65 Bug-Url: https://bugzilla.redhat.com/1161734 Bug-Url: https://bugzilla.redhat.com/1161730 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/FrontendLoginHandler.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java 5 files changed, 93 insertions(+), 69 deletions(-) Approvals: Alon Bar-Lev: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3905b3b5834a0f7327321e93064274df0d1db65 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0