Change in ovirt-engine[ovirt-engine-3.4]: webadmin: disks tab - fix type selection after sign out
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: disks tab - fix type selection after sign out
......................................................................
webadmin: disks tab - fix type selection after sign out
MainTabDiskView -> use CommonModelManager singleton instance
instead of saving it as a class member (needed for fixing disk
type selection after signing out).
Change-Id: I11b1489db03608fddf1aa24fa6664f6c3ab5abb3
Bug-Url: https://bugzilla.redhat.com/1073574
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java
1 file changed, 6 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/25695
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I11b1489db03608fddf1aa24fa6664f6c3ab5abb3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: disks - prevent redundant search manipulation
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: disks - prevent redundant search manipulation
......................................................................
webadmin: disks - prevent redundant search manipulation
Ensure that the selected main tab (in commonModel) is DiskListModel.
Change-Id: I0505bbea25e16f7e663689f4baa66df103e8b533
Bug-Url: https://bugzilla.redhat.com/1073574
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/25694
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0505bbea25e16f7e663689f4baa66df103e8b533
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: snapshots sub-tab - ensure model listeners
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: snapshots sub-tab - ensure model listeners
......................................................................
webadmin: snapshots sub-tab - ensure model listeners
VMs -> Snapshots sub-sub:
Ensure model listeners existence after sign out.
Re-adding the listeners in presenter's onUiCommonInit method
as VmSnapshotListModel is being initialized on sign in
(along with the other list models: VmListModel -> initDetailModels).
Change-Id: I006023de74150754d8c79f95b79eb9ad0158b055
Bug-Url: https://bugzilla.redhat.com/1058618
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/AbstractModelBoundTableWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/virtualMachine/SubTabVirtualMachineSnapshotPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineSnapshotView.java
4 files changed, 41 insertions(+), 12 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/25693
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I006023de74150754d8c79f95b79eb9ad0158b055
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: snapshot sub-tab - avoid redundant update
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: snapshot sub-tab - avoid redundant update
......................................................................
webadmin: snapshot sub-tab - avoid redundant update
VmSnapshotListModel -> updateActionAvailability:
avoid update when getItems is null (to prevent an NPE).
Change-Id: If3469c20f2a4caceb96b40bbf542baacbadcf30e
Bug-Url: https://bugzilla.redhat.com/1058618
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/25692
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3469c20f2a4caceb96b40bbf542baacbadcf30e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: move constant strings in ovf to OvfProperties
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: move constant strings in ovf to OvfProperties
......................................................................
core: move constant strings in ovf to OvfProperties
Most of the Strings which are part of the OVF files appear explicitly
in both the reader and writer classes. It is wrong because they have to
be the same in both places. So in this patch I move many Strings like
that to the OvfProperties class as constants and the OVF readers and
writers now reference those constants.
Change-Id: Idc40102b107d510e04f10f45f0b7e4838fd4c706
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
7 files changed, 136 insertions(+), 93 deletions(-)
Approvals:
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25679
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc40102b107d510e04f10f45f0b7e4838fd4c706
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: export & import highly available parameters
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: export & import highly available parameters
......................................................................
core: export & import highly available parameters
The 'auto startup' and 'priority' attributes of VM/Template were not
copied on export & import operations. Now they are.
Change-Id: I194b70181cf4ab0420044a22dd8a382766d9019d
Bug-Url: https://bugzilla.redhat.com/1057048
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
5 files changed, 21 insertions(+), 9 deletions(-)
Approvals:
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I194b70181cf4ab0420044a22dd8a382766d9019d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.3]: packaging: engine-backup: ignore also 'CREATE PROCEDURAL LAN...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: engine-backup: ignore also 'CREATE PROCEDURAL LANGUAGE'
......................................................................
packaging: engine-backup: ignore also 'CREATE PROCEDURAL LANGUAGE'
When checking if a database is empty, ignore also 'CREATE PROCEDURAL
LANGUAGE', which is created by default in postgresl 8, in addition
to 'CREATE EXTENSION IF NOT EXISTS plpgsql' which is done in version 9.
Bug-Url: https://bugzilla.redhat.com/1066654
Bug-Url: https://bugzilla.redhat.com/1069131
Change-Id: Ib3772e27d0800792e97ae976f6c40484bd048fb6
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/bin/engine-backup.sh
1 file changed, 20 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/25729
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3772e27d0800792e97ae976f6c40484bd048fb6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: core: preserve custom db users permissions on...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: preserve custom db users permissions on...
......................................................................
core: preserve custom db users permissions on...
preserve custom db users permissions on upgrade
Up to this patch if custom users were added and assign privileges on DB
objects those privileges were removed when the db was updated or
refreshed.
This patch backups the privileges assigned to custom users and apply
them after the database was upgraded or refreshed.
Change-Id: If4ac85dc943fcb6a8f656a8ebeb172023e71c1ec
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073471
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/dbfunctions.sh
M packaging/dbscripts/refreshStoredProcedures.sh
2 files changed, 16 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25709
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4ac85dc943fcb6a8f656a8ebeb172023e71c1ec
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: packaging: engine-backup: ignore also 'CREATE PROCEDURAL LAN...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: engine-backup: ignore also 'CREATE PROCEDURAL LANGUAGE'
......................................................................
packaging: engine-backup: ignore also 'CREATE PROCEDURAL LANGUAGE'
When checking if a database is empty, ignore also 'CREATE PROCEDURAL
LANGUAGE', which is created by default in postgresl 8, in addition
to 'CREATE EXTENSION IF NOT EXISTS plpgsql' which is done in version 9.
Bug-Url: https://bugzilla.redhat.com/1066654
Bug-Url: https://bugzilla.redhat.com/1069131
Change-Id: Ib3772e27d0800792e97ae976f6c40484bd048fb6
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/bin/engine-backup.sh
1 file changed, 20 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/25728
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3772e27d0800792e97ae976f6c40484bd048fb6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Not able to push more than one external...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Not able to push more than one external...
......................................................................
core: Not able to push more than one external...
Not able to push more than one external event in 30 second using REST API
This patch enables to add external events with flood rate below 30 if
specified in the POST message.
For example :
<event>
<description>1</description>
<severity>normal</severity>
<origin>CUSTOMER1</origin>
<custom_id>1</custom_id>
<flood_rate>1</flood_rate>
</event>
if the following is sent:
<event>
<description>1</description>
<severity>normal</severity>
<origin>CUSTOMER1</origin>
<custom_id>1</custom_id>
</event>
a default flood rate of 30 sec is used.
Change-Id: I91526e2a744cc6de413091fd1605bf7f08c46735
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1071840
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
Ramesh N: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I91526e2a744cc6de413091fd1605bf7f08c46735
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months