March 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: Make FSMLoggerAdapter compatible with Python 2.6

by gpadgett＠redhat.com

Greg Padgett has submitted this change and it was merged. Change subject: Make FSMLoggerAdapter compatible with Python 2.6 ...................................................................... Make FSMLoggerAdapter compatible with Python 2.6 Python 2.6 does not use new style classes in the logging subsystem, but the super call requires the parent to be a new style class. This patch updates the code to use the old way of calling parent's constructor. Change-Id: Ia02a3b7174554f174ad84ec1e22f565e62b69c32 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit caedc15e8b7f2e3bb79f22e715df0858f34b9379) --- M ovirt_hosted_engine_ha/lib/fsm/machine.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Verified Greg Padgett: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia02a3b7174554f174ad84ec1e22f565e62b69c32 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.1 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: On new disk creation update wipe after delete on s...

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: On new disk creation update wipe after delete on storage change ...................................................................... webadmin: On new disk creation update wipe after delete on storage change In new disk dialog the wipe after delete property determined by the default storage domain that was selected, since a data center can now consist of storage domain of different storage types, the wipe after delete property should be update upon change in the storage domain to reflect the correct behavior that fits the selected storage domain type Change-Id: Icefd405217fd7498d911809ca02f0f7cf7b42f24 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1063935 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icefd405217fd7498d911809ca02f0f7cf7b42f24 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: DialogBoxWithKeyHandlers - remove ONKEYPRESS event

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: DialogBoxWithKeyHandlers - remove ONKEYPRESS event ...................................................................... webadmin: DialogBoxWithKeyHandlers - remove ONKEYPRESS event DialogBoxWithKeyHandlers -> onPreviewNativeEvent: remove ONKEYPRESS event as onKeyPress might be called twice (due to ONKEYDOWN event). Which causes double execution of OK command when pressing enter key in Network dialog. Change-Id: If63ae06dfed4956ca672c32045dbdaa16301cd45 Bug-Url: https://bugzilla.redhat.com/1058652 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/DialogBoxWithKeyHandlers.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/25236 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If63ae06dfed4956ca672c32045dbdaa16301cd45 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-hosted-engine-ha[master]: Make FSMLoggerAdapter compatible with Python 2.6

by msivak＠redhat.com

Martin Sivák has submitted this change and it was merged. Change subject: Make FSMLoggerAdapter compatible with Python 2.6 ...................................................................... Make FSMLoggerAdapter compatible with Python 2.6 Python 2.6 does not use new style classes in the logging subsystem, but the super call requires the parent to be a new style class. This patch updates the code to use the old way of calling parent's constructor. Change-Id: Ia02a3b7174554f174ad84ec1e22f565e62b69c32 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/fsm/machine.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved Jiří Moskovčák: Looks good to me, but someone else must approve Greg Padgett: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia02a3b7174554f174ad84ec1e22f565e62b69c32 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: pki: ca private key perms

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: pki: ca private key perms ...................................................................... packaging: pki: ca private key perms Change-Id: I66451545cf7875d4671924ffdf4e578035357d92 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/pki-create-ca.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66451545cf7875d4671924ffdf4e578035357d92 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <simone.tiraboschi(a)gmail.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: core, engine: Fix HotPlugCpuSupported config value

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core, engine: Fix HotPlugCpuSupported config value ...................................................................... core, engine: Fix HotPlugCpuSupported config value The 'HotPlugCpuSupported' configuration value was not present in the database and another unused property called HotPlugCpuEnable contained syntax errors that prevented it from being read by the JSON parser. This patch removes the unused property and adds the correct one, fixing the syntax errors that were present. Change-Id: I3ef5b2e39b2067239721a65b031d247ace3b0c2c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1069802 Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ef5b2e39b2067239721a65b031d247ace3b0c2c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Allow CPU family change for cluster with hosts

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: Allow CPU family change for cluster with hosts ...................................................................... core: Allow CPU family change for cluster with hosts Allows changing CPU family for cluster which has all hosts in Maintenance. Currently this was allowed only for empty cluster. Change-Id: I7d5e53f15e917e84ed0bb99fa646a6d5bb866f8c Bug-Url: https://bugzilla.redhat.com/1057232 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 18 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d5e53f15e917e84ed0bb99fa646a6d5bb866f8c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Fix audit log messages for auth results

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: Fix audit log messages for auth results ...................................................................... core: Fix audit log messages for auth results Adds audit log messages for all authention results that didn't have audit log messages assigned. Change-Id: I0fa17e2ea206195813b258101a367396399543eb Bug-Url: https://bugzilla.redhat.com/1059550 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/AuthenticationResult.java 4 files changed, 107 insertions(+), 24 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fa17e2ea206195813b258101a367396399543eb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: don't load disks for templates on search

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: don't load disks for templates on search ...................................................................... core: don't load disks for templates on search When searching for templates, the search loads all the disks for each template. this is not necessary as disks are a different collection that need to be fetched upon request, also the disks are not used currently by the search initiators, and it make the templates search slow for systems with many templates. this patch removes the disks population on templates search. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1070265 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1064907 Change-Id: Ia83a3117f2c65bbb17972095cf3271eb39449cd6 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesByStoragePoolIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java 4 files changed, 23 insertions(+), 11 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Itamar Heim: Verified Omer Frenkel: Verified Arik Hadas: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia83a3117f2c65bbb17972095cf3271eb39449cd6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 8 months

1
0
0 / 0

Change in ovirt-dwh[master]: packaging: setup: allow setting package names via environment

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: allow setting package names via environment ...................................................................... packaging: setup: allow setting package names via environment Change-Id: If18c481e824c3840c4f45f296af8aff63b83bdfe Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/dwhconstants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/distro-rpm/packages.py 2 files changed, 30 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If18c481e824c3840c4f45f296af8aff63b83bdfe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

10 years, 8 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits March 2014