Change in ovirt-engine[master]: core: Allow CPU family change for cluster with hosts
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Allow CPU family change for cluster with hosts
......................................................................
core: Allow CPU family change for cluster with hosts
Allows changing CPU family for cluster which has all hosts in
Maintenance. Currently this was allowed only for empty cluster.
Change-Id: I7d5e53f15e917e84ed0bb99fa646a6d5bb866f8c
Bug-Url: https://bugzilla.redhat.com/1057232
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 18 insertions(+), 4 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25180
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d5e53f15e917e84ed0bb99fa646a6d5bb866f8c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: engine: Fix a possible NPE when the user removes stale polic...
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: engine: Fix a possible NPE when the user removes stale policy unit
......................................................................
engine: Fix a possible NPE when the user removes stale policy unit
When the external scheduler is in use and some plugin disappears,
the plugin is still visible (in disabled form) in the Manage
Policy Units dialog. If the user tries to remove it it has to
work correctly and not raise NPE.
Change-Id: I5fa617af3363ec1d71cf8f0a25af43be4b141067
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1065914
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
1 file changed, 16 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Verified
Jiří Moskovčák: Looks good to me, but someone else must approve
Gilad Chaplik: Looks good to me, approved
Kobi Ianko: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/24953
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5fa617af3363ec1d71cf8f0a25af43be4b141067
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: Ensure NonOperational state is saved
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Ensure NonOperational state is saved
......................................................................
core: Ensure NonOperational state is saved
A specific scenario in VdsUpdateRuntimeInfo does not save the NonOperational status
to the database. This causes the host to get stuck in an unassigned status.
Change-Id: I8e4c5d3dc49f48bf46609c91f13dededb43b630f
Bug-Url: https://bugzilla.redhat.com/962180
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Liran Zelkha: Verified
--
To view, visit http://gerrit.ovirt.org/24969
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e4c5d3dc49f48bf46609c91f13dededb43b630f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: webadmin: On new disk creation update wipe after delete on s...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: On new disk creation update wipe after delete on storage change
......................................................................
webadmin: On new disk creation update wipe after delete on storage change
In new disk dialog the wipe after delete property determined by the default
storage domain that was selected, since a data center can now consist of
storage domain of different storage types, the wipe after delete property
should be update upon change in the storage domain to reflect the correct
behavior that fits the selected storage domain type
Change-Id: Icefd405217fd7498d911809ca02f0f7cf7b42f24
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1063935
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25246
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icefd405217fd7498d911809ca02f0f7cf7b42f24
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-reports[master]: reports: edited ic query-all_clusters_with_hosts
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: edited ic query-all_clusters_with_hosts
......................................................................
reports: edited ic query-all_clusters_with_hosts
I edited the, all_clusters_with_hosts, input control query,
so it will be more readable and added comments.
Change-Id: I016b6152a4cb32625020b93c5adc081372d3fe1f
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/cluster_ic/all_clusters_with_hosts/P_Cluster_ID.xml
1 file changed, 138 insertions(+), 45 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25244
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I016b6152a4cb32625020b93c5adc081372d3fe1f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: fixing typo
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: fixing typo
......................................................................
webadmin: fixing typo
"shceduling" -> "scheduling"
Change-Id: I616b711893403f733c6fa7ce8e166657841e4612
Bug-Url: https://bugzilla.redhat.com/1067450
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Sivák: Verified; Looks good to me, but someone else must approve
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I616b711893403f733c6fa7ce8e166657841e4612
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: Fix audit log messages for auth results
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Fix audit log messages for auth results
......................................................................
core: Fix audit log messages for auth results
Adds audit log messages for all authention results that didn't have
audit log messages assigned.
Change-Id: I0fa17e2ea206195813b258101a367396399543eb
Bug-Url: https://bugzilla.redhat.com/1059550
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/AuthenticationResult.java
3 files changed, 93 insertions(+), 29 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24729
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0fa17e2ea206195813b258101a367396399543eb
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-reports[master]: reports: br1 reports - added comments to queries
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: br1 reports - added comments to queries
......................................................................
reports: br1 reports - added comments to queries
Changed the code structure so it will be more readable
and added commets.
Change-Id: Ic842bb23ffe7f240ee20bfbe0144d30d7695e1a0
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/Reports/Inventory/Hosts_Inventory_files/Hosts_Inventory_jrxml.data
M packaging/ovirt-reports/resources/Reports/Inventory/Hosts_Inventory_files/full details br1.jrxml.data
2 files changed, 691 insertions(+), 584 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/24897
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic842bb23ffe7f240ee20bfbe0144d30d7695e1a0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 8 months
Change in ovirt-reports[master]: packaging: rename 50-ovirt-engine-reports.conf.in->20-ovirt-...
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: rename 50-ovirt-engine-reports.conf.in->20-ovirt-engine-reports.conf.in
......................................................................
packaging: rename 50-ovirt-engine-reports.conf.in->20-ovirt-engine-reports.conf.in
Change-Id: I298258c9ad0ed29b0bd1ad68217e16f348a7b124
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M .gitignore
M Makefile
M ovirt-engine-reports.spec.in
R packaging/sys-etc/ovirt-engine/engine.conf.d/20-ovirt-engine-reports.conf.in
4 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25251
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I298258c9ad0ed29b0bd1ad68217e16f348a7b124
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 8 months
Change in ovirt-dwh[master]: db: cleanup: dos2unix
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: db: cleanup: dos2unix
......................................................................
db: cleanup: dos2unix
Change-Id: I11129940f2b364248b8a71ab1215d1db6985e00f
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/dbscripts/common_sp.sql
1 file changed, 595 insertions(+), 595 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25248
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I11129940f2b364248b8a71ab1215d1db6985e00f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 8 months