Change in ovirt-engine[master]: core: avoid deadlock in images
by laravot＠redhat.com
Liron Ar has submitted this change and it was merged.
Change subject: core: avoid deadlock in images
......................................................................
core: avoid deadlock in images
Currently the images table contains a foreign key to itself (quoting from
the table definition) :
...
TABLE "images" CONSTRAINT "image_templates_images" FOREIGN KEY
(it_guid) REFERENCES images(image_guid)
...
The column it_guid in the images table indicates what is the …
[View More]template
that the image is based on.
In postgres versions earlier than 9.3, when executing a update to a row
with a foreign key, a lock on the referenced record is taken which means
that we have a chance for a deadlock in the following scenarios:
1. Simultenous update to the template disks and to the disks of a vm
based on the template.
2. Simultenous update to disks of vms based on the same template.
This issue has been resolved in postgres 9.3
(http://www.postgresql.org/docs/9.3/static/release-9-3.html see
E.5.3.1.1), till we'll enforce usage of that version we can drop that foreign
key constraint which will also align it with the parentid column that we don't
a FK on as well.
Regardless of that, we should remove unneeded updates to images in
different flows.
Change-Id: Ib4939a716cef8901b53a90499201d815a4e3cb58
Bug-Url: https://bugzilla.redhat.com/1077715
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_05_0600_drop_images_fk.sql
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Liron Ar: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28409
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4939a716cef8901b53a90499201d815a4e3cb58
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 11 months
Change in ovirt-hosted-engine-ha[master]: try harder when starting vdsmd
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: try harder when starting vdsmd
......................................................................
try harder when starting vdsmd
I've observed a situation when ha-agent is started too early and
it fails to start vdsmd, but later when vdsmd is started ha-agent
also starts fine. This patch makes agent to wait a while and retry
if the first attempt to start vdsmd fails
Change-Id: …
[View More]I806437b8c5eafd32fb37d0b3f2f59995faa28cdc
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/constants.py.in
M ovirt_hosted_engine_ha/agent/hosted_engine.py
2 files changed, 17 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Jiří Moskovčák: Verified
--
To view, visit http://gerrit.ovirt.org/28432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I806437b8c5eafd32fb37d0b3f2f59995faa28cdc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 11 months
Change in ovirt-live[master]: build: post ovirt-live 3.5.0-alpha2
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: post ovirt-live 3.5.0-alpha2
......................................................................
build: post ovirt-live 3.5.0-alpha2
Change-Id: Ic82b7b4edac95490f3086b94d49b2a4ec4e2501b
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos/Makefile
M centos/kickstart/ovirt-live-base.ks.in
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks …
[View More]good to me, approved
--
To view, visit http://gerrit.ovirt.org/28436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic82b7b4edac95490f3086b94d49b2a4ec4e2501b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
[View Less]
10 years, 11 months
Change in ovirt-live[master]: build: ovirt-live 3.5.0-alpha2
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: ovirt-live 3.5.0-alpha2
......................................................................
build: ovirt-live 3.5.0-alpha2
Change-Id: I8137a05123b412c4bd042272c45f85c53df64e45
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos/Makefile
M centos/kickstart/ovirt-live-base.ks.in
2 files changed, 2 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to …
[View More]me, approved
--
To view, visit http://gerrit.ovirt.org/28435
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8137a05123b412c4bd042272c45f85c53df64e45
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
[View Less]
10 years, 11 months
Change in ovirt-engine[master]: Split of engine-setup-plugin
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Split of engine-setup-plugin
......................................................................
Split of engine-setup-plugin
Move constants and file to the right position to
have the engine plugin as a separate package
without sharing engine specific constants and file with the
base package.
Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
…
[View More]M Makefile
M ovirt-engine.spec.in
M packaging/setup/bin/ovirt-engine-upgrade-check
M packaging/setup/ovirt_engine_setup/config.py.in
M packaging/setup/ovirt_engine_setup/constants.py
A packaging/setup/ovirt_engine_setup/engine/__init__.py
A packaging/setup/ovirt_engine_setup/engine/engineconfig.py.in
A packaging/setup/ovirt_engine_setup/engine/engineconstants.py
A packaging/setup/ovirt_engine_setup/engine/vdcoption.py
A packaging/setup/ovirt_engine_setup/engine_common/__init__.py
R packaging/setup/ovirt_engine_setup/engine_common/database.py
A packaging/setup/ovirt_engine_setup/engine_common/enginecommonconfig.py.in
A packaging/setup/ovirt_engine_setup/engine_common/enginecommonconstants.py
R packaging/setup/ovirt_engine_setup/engine_common/postgres.py
M packaging/setup/plugins/ovirt-engine-common/base/core/__init__.py
D packaging/setup/plugins/ovirt-engine-common/base/core/protocols.py
M packaging/setup/plugins/ovirt-engine-common/base/core/uninstall.py
D packaging/setup/plugins/ovirt-engine-common/base/db/connection.py
M packaging/setup/plugins/ovirt-engine-common/base/system/__init__.py
A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/core/__init__.py
A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/core/protocols.py
R packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/db/__init__.py
A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/db/connection.py
R packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/db/pgpass.py
A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/__init__.py
R packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/apache.py
A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/environment.py
A packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/__init__.py
R packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/engine.py
A packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/__init__.py
A packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/connection.py
M packaging/setup/plugins/ovirt-engine-common/websocket_proxy/core.py
M packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py
R packaging/setup/plugins/ovirt-engine-remove/base/files/__init__.py
R packaging/setup/plugins/ovirt-engine-remove/base/files/simple.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/ca.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/db/clear.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/engine.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/sysctl.py
M packaging/setup/plugins/ovirt-engine-remove/websocket_proxy/misc.py
R packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/__init__.py
R packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py
R packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/engine.py
R packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/misc.py
R packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/pki.py
R packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/protocols.py
R packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/tools.py
R packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/uninstall.py
A packaging/setup/plugins/ovirt-engine-setup/base/system/__init__.py
R packaging/setup/plugins/ovirt-engine-setup/base/system/environment.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/java.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/jboss.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/db/connection.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/provisioning/postgres.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/core.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/cpu.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/firewall.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/sshd.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/storage.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/engine.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/misc.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/root.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/ssl.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/appmode.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/ca.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/database.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/firewall.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/jboss.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/macrange.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/options.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/protocols.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/public_glance_repository.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/tools.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/dialog/titles.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/packages.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/osinfo.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ssh.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/engine.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/memcheck.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/sysctl.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dbvalidations.py
M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py
93 files changed, 2,820 insertions(+), 2,014 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/27647
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6
Gerrit-PatchSet: 42
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 11 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: custom preview dialog - close on success
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: custom preview dialog - close on success
......................................................................
webadmin: custom preview dialog - close on success
Custom preview dialog:
close dialog only on return value success;
i.e. keep dialog open after canDoAction popup
(to allow selection amend).
Change-Id: I7c35c03bd1fdd7b8b2a46c7ff7596d344ab729e0
Bug-Url: https://bugzilla.redhat.com/1102783
Signed-…
[View More]off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/28303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c35c03bd1fdd7b8b2a46c7ff7596d344ab729e0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 11 months
Change in ovirt-engine[ovirt-engine-3.4]: core: block preview of active vm snapshot
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: block preview of active vm snapshot
......................................................................
core: block preview of active vm snapshot
* TryBackToAllSnapshotsOfVmCommand -> canDo:
- Active VM snapshot validation.
* DiskSnapshotsValidator:
- Added canDiskSnapshotsBePreviewed validation.
- Allow custom preview of active VM configuration only
when selecting a subset of snapshot disks.
Change-Id:…
[View More] Iee5d5e6716cec69f36e2e98fa2c1578c53dc2384
Bug-Url: https://bugzilla.redhat.com/1102783
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskSnapshotsValidator.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskSnapshotsValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 155 insertions(+), 17 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/28302
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee5d5e6716cec69f36e2e98fa2c1578c53dc2384
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 11 months
Change in ovirt-engine[master]: core: Adding saveOrUpdate to DbUserDao
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Adding saveOrUpdate to DbUserDao
......................................................................
core: Adding saveOrUpdate to DbUserDao
Change-Id: I4b6add7cbbe0a3055b6eb11ebf67cc77fec4bf53
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/…
[View More]dao/DbUserDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbUserDAOTest.java
M packaging/dbscripts/user_sp.sql
4 files changed, 103 insertions(+), 15 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28429
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b6add7cbbe0a3055b6eb11ebf67cc77fec4bf53
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 11 months
Change in ovirt-engine[master]: userportal, webadmin: Remove redundant scroll bar in VM gener...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal,webadmin: Remove redundant scroll bar in VM general tab
......................................................................
userportal,webadmin: Remove redundant scroll bar in VM general tab
The ProfilesInstanceTypeEditor had the vertical size hardcoded and was wrapped
by a ScrollPanel. This caused the redundant scroll bar in the VM general tab to
appear.
Fixed by removing the ScrollPanel since in all …
[View More]other tabs in the VM dialog the
scrolling is handled by the dialog itself - this change makes the behavior
consistent with the rest of the tabs.
It has been already fixed in http://gerrit.ovirt.org/#/c/26169 but has been
accidentally introduced back in http://gerrit.ovirt.org/#/c/24594 so this
patch removes it again.
Change-Id: I03f31624feaa23b37006310d365d57e717d4bbb0
Bug-Url: https://bugzilla.redhat.com/1047883
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Verified
Greg Sheremeta: Looks good to me, but someone else must approve
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28298
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03f31624feaa23b37006310d365d57e717d4bbb0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 11 months
Change in ovirt-node-plugin-vdsm[node-3.0]: ovirt-node-plugin-vdsm: Bump release to 0.1.2-3
by dougsland＠redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: ovirt-node-plugin-vdsm: Bump release to 0.1.2-3
......................................................................
ovirt-node-plugin-vdsm: Bump release to 0.1.2-3
- engine_page: add exception for ENETUNREACH (BZ#1104009)
- hooks: Adding hooks for ovirt-node-upgrade (BZ#1079087)
- engine_page: remove dep. from ovirt_config_setup.engine (BZ#1102995)
Change-Id: I6496868e2b296ea830194e0617ff52431f329559
…
[View More]Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M ovirt-node-plugin-vdsm.spec.in
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28428
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6496868e2b296ea830194e0617ff52431f329559
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: node-3.0
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
10 years, 11 months