Change in ovirt-engine[ovirt-engine-3.5]: core: missing cmdContext assignment in constructor
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: missing cmdContext assignment in constructor
......................................................................
core: missing cmdContext assignment in constructor
Following Change-Id: I310f5f77fff78b3232ee77fe63791425fd521516
RemoveSnapshotSingleDiskCommandBase constructor should pass
'cmdContext' to the parent class.
The missing context prevents the snapshot removal task from
being set as finished (see related BZ).
Change-Id: I5ce97a22fe994b5278104cc6f436248a0c66f140
Bug-Url: https://bugzilla.redhat.com/1119706
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommandBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Allon Mureinik: Looks good to me, but someone else must approve
Yair Zaslavsky: Looks good to me, approved
Oved Ourfali: Verified
--
To view, visit http://gerrit.ovirt.org/30634
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ce97a22fe994b5278104cc6f436248a0c66f140
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: engine: fixed possible int overflow in getMemSharedPercent
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: fixed possible int overflow in getMemSharedPercent
......................................................................
engine: fixed possible int overflow in getMemSharedPercent
- if there is system with 21TB+ shared memory the int value
will overflow when counting the percentage
Change-Id: I655a5558ff4fc7d7ad90ad5f9c4bd57ae9723838
Bug-Url: https://bugzilla.redhat.com/1093786
Signed-off-by: Jiri Moskovcak <moskovcak(a)gmail.com>
(cherry picked from commit 614fc71d30fd305826bf36cb9c208929606d9588)
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jiří Moskovčák: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30644
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I655a5558ff4fc7d7ad90ad5f9c4bd57ae9723838
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: packaging: do not use /var/tmp for engine
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: packaging: do not use /var/tmp for engine
......................................................................
packaging: do not use /var/tmp for engine
/var/tmp is intended for temporary files.
The engine is a long-running process, and should not keep its files
there. Use /var/lib/ovirt-engine/jboss_runtime instead.
Bug-Url: https://bugzilla.redhat.com/1121401
Change-Id: I88563c8c0d319eb3356b47233a31c82d9e8b84c7
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M Makefile
M packaging/services/ovirt-engine/ovirt-engine.conf.in
M packaging/services/ovirt-engine/ovirt-engine.py
M packaging/services/ovirt-engine/ovirt-engine.xml.in
4 files changed, 15 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/30489
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88563c8c0d319eb3356b47233a31c82d9e8b84c7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: engine: fixed possible int overflow in getMemSharedPercent
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: engine: fixed possible int overflow in getMemSharedPercent
......................................................................
engine: fixed possible int overflow in getMemSharedPercent
- if there is system with 21TB+ shared memory the int value
will overflow when counting the percentage
Change-Id: I655a5558ff4fc7d7ad90ad5f9c4bd57ae9723838
Bug-Url: https://bugzilla.redhat.com/1093786
Signed-off-by: Jiri Moskovcak <moskovcak(a)gmail.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jiří Moskovčák: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30614
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I655a5558ff4fc7d7ad90ad5f9c4bd57ae9723838
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: aaa: NPE when adding permission to datacenter
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: NPE when adding permission to datacenter
......................................................................
aaa: NPE when adding permission to datacenter
Change-Id: I379ffbac3e8323cf575d9d14c860dd03a6b6e686
Topic: AAA
Bug-Url: https://bugzilla.redhat.com/1121406
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
D backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/BasicAuthorizationScheme.java
D backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Principal.java
D backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Scheme.java
D backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/security/auth/BasicAuthorizationSchemeTest.java
D backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/security/auth/PrincipalTest.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilityResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResourceTest.java
11 files changed, 14 insertions(+), 456 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, but someone else must approve
Juan Hernandez: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30527
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I379ffbac3e8323cf575d9d14c860dd03a6b6e686
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: aaa: fixing more context issues
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: fixing more context issues
......................................................................
aaa: fixing more context issues
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720
Change-Id: I793344d07b1a60eac50df81ed3fdca04e5a7851a
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ApproveVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StartVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsPowerDownCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SetStoragePoolStatusCommand.java
9 files changed, 58 insertions(+), 10 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30624
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I793344d07b1a60eac50df81ed3fdca04e5a7851a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: missing cmdContext assignment in constructor
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: missing cmdContext assignment in constructor
......................................................................
core: missing cmdContext assignment in constructor
Following Change-Id: I310f5f77fff78b3232ee77fe63791425fd521516
RemoveSnapshotSingleDiskCommandBase constructor should pass
'cmdContext' to the parent class.
The missing context prevents the snapshot removal task from
being set as finished (see related BZ).
Change-Id: I5ce97a22fe994b5278104cc6f436248a0c66f140
Bug-Url: https://bugzilla.redhat.com/1119706
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommandBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30615
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ce97a22fe994b5278104cc6f436248a0c66f140
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: unlock_entity.sh fails on authentication
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: unlock_entity.sh fails on authentication
......................................................................
core: unlock_entity.sh fails on authentication
The DB was configured in pg_hba.conf with md5
This means that in order to run this utility properly you should set the
PGPASSWORD or PGPASSFILE environment variable.
Example:
\$ PGPASSWORD=xxxxxx ./unlock_entity.sh -t disk -q
I had added this information to the utility help
Change-Id: I6055bec6b91d5eb101e6655ed4eea481a6a082f9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1118191
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/unlock_entity.sh
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Nir Soffer: Looks good to me, but someone else must approve
Eli Mesika: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30568
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6055bec6b91d5eb101e6655ed4eea481a6a082f9
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine-sdk-java[sdk_3.5]: sdk: Improve the README
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Improve the README
......................................................................
sdk: Improve the README
This patch adds some documentation on how to regenerate the SDK to the
README file.
Change-Id: I341c475485cdfd963190e4d04ebbea5520608927
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 354d93b7200825cfb166d9105d4dcc668623faa2)
---
D ovirt-engine-sdk-java/AUTHORS
A ovirt-engine-sdk-java/AUTHORS.md
R ovirt-engine-sdk-java/LICENSE.md
D ovirt-engine-sdk-java/README
A ovirt-engine-sdk-java/README.md
M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in
6 files changed, 146 insertions(+), 13 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30629
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I341c475485cdfd963190e4d04ebbea5520608927
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 8 months
Change in ovirt-engine-sdk-java[master]: sdk: Improve the README
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Improve the README
......................................................................
sdk: Improve the README
This patch adds some documentation on how to regenerate the SDK to the
README file.
Change-Id: I341c475485cdfd963190e4d04ebbea5520608927
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
D ovirt-engine-sdk-java/AUTHORS
A ovirt-engine-sdk-java/AUTHORS.md
R ovirt-engine-sdk-java/LICENSE.md
D ovirt-engine-sdk-java/README
A ovirt-engine-sdk-java/README.md
M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in
6 files changed, 146 insertions(+), 13 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30628
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I341c475485cdfd963190e4d04ebbea5520608927
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 8 months