Change in ovirt-engine[master]: core: Deprecate old storage allocation checks
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Deprecate old storage allocation checks
......................................................................
core: Deprecate old storage allocation checks
Change-Id: I05b49b10438db4a09b841e9ce4d572199cc31266
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Arik Hadas: Looks good to me, but someone else must approve
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/31190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05b49b10438db4a09b841e9ce4d572199cc31266
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: VmHandlerTest - Removed commented-out code
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VmHandlerTest - Removed commented-out code
......................................................................
core: VmHandlerTest - Removed commented-out code
Commented out code has been there for two-years, unrevized.
Removing.
Change-Id: Id577a6473dacfa11f329b74ebd5122802d0a5f15
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java
1 file changed, 0 insertions(+), 204 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31189
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id577a6473dacfa11f329b74ebd5122802d0a5f15
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: engine: allow to fetch all QoS for REST
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: engine: allow to fetch all QoS for REST
......................................................................
engine: allow to fetch all QoS for REST
Added All QoS Dao object & relaxed common and dal.
Change-Id: I1e55d3e7643c42f48c971400b15f6eb92e50ccaa
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllQosByStoragePoolIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QosQueryBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/AllQosBaseDaoFacadeImpl.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/QosBaseDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/StorageQosDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties
M packaging/dbscripts/qos_sp.sql
11 files changed, 113 insertions(+), 9 deletions(-)
Approvals:
Gilad Chaplik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28767
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e55d3e7643c42f48c971400b15f6eb92e50ccaa
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: Fix dbscripts numbering
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Fix dbscripts numbering
......................................................................
core: Fix dbscripts numbering
Change-Id: I2290b26c58cf4b426a79fc554e888cb4caeecd85
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
R packaging/dbscripts/upgrade/03_06_0240_update_disk_bootable_shareable.sql
1 file changed, 0 insertions(+), 0 deletions(-)
Approvals:
Yair Zaslavsky: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31684
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2290b26c58cf4b426a79fc554e888cb4caeecd85
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: handling exception from uuid validation
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: setup: handling exception from uuid validation
......................................................................
packaging: setup: handling exception from uuid validation
Better handling of exception from UUID validation
to provide an easier to read and more consistent error.
Change-Id: I505a4f01d41c218a572f6e42682b57875712f1c0
Bug-Url: https://bugzilla.redhat.com/1125834
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
(cherry picked from commit 459baeb373206cb8b04458993ed18792a9d44488)
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py
1 file changed, 19 insertions(+), 7 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit http://gerrit.ovirt.org/31660
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I505a4f01d41c218a572f6e42682b57875712f1c0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 8 months
Change in ovirt-engine[master]: engine: Forbid Bootable and Shareable Disks
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: engine: Forbid Bootable and Shareable Disks
......................................................................
engine: Forbid Bootable and Shareable Disks
A disk cannot be both bootable and shareable.
Changes have been made in the backend and frontend.
Also, an SQL script was added to packaging/dbscripts/upgrade.
Change-Id: I8e221d6534b71db96d0c58442220d249b305079b
Bug-Url: https://bugzilla.redhat.com/1084103
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
A packaging/dbscripts/upgrade/03_06_0230_update_disk_bootable_shareable.sql
14 files changed, 162 insertions(+), 5 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31142
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e221d6534b71db96d0c58442220d249b305079b
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: packaging: setup: adding local storage domain name to answer...
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: adding local storage domain name to answer file
......................................................................
packaging: setup: adding local storage domain name to answer file
Adding local storage domain name value to
answer file to allow automated AIO setup.
Change-Id: Ic3bdb5b101a4b6b3261cad62c4977b4529e77a15
Bug-Url: https://bugzilla.redhat.com/1125920
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine/constants.py
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit http://gerrit.ovirt.org/31664
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3bdb5b101a4b6b3261cad62c4977b4529e77a15
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 8 months
Change in ovirt-engine[master]: core: ovirt-websocket-proxy fail when missing enforced key/pair
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: core: ovirt-websocket-proxy fail when missing enforced key/pair
......................................................................
core: ovirt-websocket-proxy fail when missing enforced key/pair
This patch makes websocket proxy fail when SSL_ONLY is set to True and
key or certificate file is missing.
Change-Id: I47033df4ea2c12799bb8535e1ef749967c2b4d06
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1116393
---
M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py
1 file changed, 14 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Frank Kobzik: Verified
--
To view, visit http://gerrit.ovirt.org/31638
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47033df4ea2c12799bb8535e1ef749967c2b4d06
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: change the signature of handleVdsMaintenanceTimeout
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: change the signature of handleVdsMaintenanceTimeout
......................................................................
core: change the signature of handleVdsMaintenanceTimeout
VdsEventListener#handleVdsMaintenanceTimeout can get just the ID
of the host and not the whole VDS object.
Change-Id: Iaa4a4815a1bf69ccae33bb37773a2a1a3b99a02e
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/31612
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa4a4815a1bf69ccae33bb37773a2a1a3b99a02e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: cleanup in VURTI
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: cleanup in VURTI
......................................................................
core: cleanup in VURTI
- improve log printings
- call getVdsEventListener to shorten few lines
Change-Id: I4a0b6ab3ee60e96e9863e56d2a7d4b40a585b9fc
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 8 insertions(+), 16 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/31611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a0b6ab3ee60e96e9863e56d2a7d4b40a585b9fc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months