Change in ovirt-log-collector[master]: ux: add --include-sensitive-data
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ux: add --include-sensitive-data
......................................................................
ux: add --include-sensitive-data
Allow to avoid to obfuscate sensitive data like passwords, etc.
Change-Id: I90458180d912db890fd91b16d7fd21e90d1fcec0
Bug-Url: https://bugzilla.redhat.com/1086942
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/__main__.py
M src/engine-log-collector.8
2 files changed, 21 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/31713
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90458180d912db890fd91b16d7fd21e90d1fcec0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: packaging: setup: Adding a dialog to let the user review ipt...
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Adding a dialog to let the user review iptables changes
......................................................................
packaging: setup: Adding a dialog to let the user review iptables changes
Adding a dialog to let the user review iptables changes
before apply them.
Change-Id: I63e0eeb26d925c8c79b9c8e55da64c57ce94a3f6
Bug-Url: https://bugzilla.redhat.com/1109326
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/ovirt_engine_setup/firewall_manager_base.py
M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager_iptables.py
M packaging/setup/plugins/ovirt-engine-setup/base/network/firewall_manager.py
4 files changed, 69 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33085
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63e0eeb26d925c8c79b9c8e55da64c57ce94a3f6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: packaging: setup: keeping NFS ports open in case of preexist...
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: keeping NFS ports open in case of preexisting exports
......................................................................
packaging: setup: keeping NFS ports open in case of preexisting exports
Looking for preexisting NFS exports in order to correctly evaluate
how to configure NFS related rules on the firewall.
Change-Id: Id99ac88af780c6239655676b5290230076d0284b
Bug-Url: https://bugzilla.redhat.com/1109326
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py
1 file changed, 21 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32867
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id99ac88af780c6239655676b5290230076d0284b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-log-collector[ovirt-log-collector-3.5]: sos: add ovirt-enging-reports and jboss runtime config
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: sos: add ovirt-enging-reports and jboss runtime config
......................................................................
sos: add ovirt-enging-reports and jboss runtime config
add to the reports:
/etc/ovirt-engine-reports
|-- ovirt-engine-reports.conf.d
| |-- 10-setup-jboss.conf
| `-- 10-setup-protocols.conf
`-- sso.properties
/var/lib/ovirt-engine-reports/jboss_runtime/config/
|-- ovirt-engine-reportsd_history
| |-- current
| | `-- ovirt-engine-reportsd.v1.xml
| |-- ovirt-engine-reportsd.boot.xml
| |-- ovirt-engine-reportsd.initial.xml
| |-- ovirt-engine-reportsd.last.xml
| `-- snapshot
|-- ovirt-engine-reportsd-logging.properties
`-- ovirt-engine-reportsd.xml
/var/lib/ovirt-engine/jboss_runtime/config/
|-- ovirt-engine_history
| |-- current
| | `-- ovirt-engine.v1.xml
| |-- ovirt-engine.boot.xml
| |-- ovirt-engine.initial.xml
| |-- ovirt-engine.last.xml
| `-- snapshot
|-- ovirt-engine-logging.properties
`-- ovirt-engine.xml
Change-Id: Ib77f272a1246991cebff31ca710885d8798e5ce1
Bug-Url: https://bugzilla.redhat.com/1086942
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit 7e6d6f0be9ca4d278cb16b7508ae00ca8be80a19)
---
M src/sos/plugins/ovirt.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib77f272a1246991cebff31ca710885d8798e5ce1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 6 months
Change in ovirt-log-collector[master]: sos: add ovirt-enging-reports and jboss runtime config
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: sos: add ovirt-enging-reports and jboss runtime config
......................................................................
sos: add ovirt-enging-reports and jboss runtime config
add to the reports:
/etc/ovirt-engine-reports
|-- ovirt-engine-reports.conf.d
| |-- 10-setup-jboss.conf
| `-- 10-setup-protocols.conf
`-- sso.properties
/var/lib/ovirt-engine-reports/jboss_runtime/config/
|-- ovirt-engine-reportsd_history
| |-- current
| | `-- ovirt-engine-reportsd.v1.xml
| |-- ovirt-engine-reportsd.boot.xml
| |-- ovirt-engine-reportsd.initial.xml
| |-- ovirt-engine-reportsd.last.xml
| `-- snapshot
|-- ovirt-engine-reportsd-logging.properties
`-- ovirt-engine-reportsd.xml
/var/lib/ovirt-engine/jboss_runtime/config/
|-- ovirt-engine_history
| |-- current
| | `-- ovirt-engine.v1.xml
| |-- ovirt-engine.boot.xml
| |-- ovirt-engine.initial.xml
| |-- ovirt-engine.last.xml
| `-- snapshot
|-- ovirt-engine-logging.properties
`-- ovirt-engine.xml
Change-Id: Ib77f272a1246991cebff31ca710885d8798e5ce1
Bug-Url: https://bugzilla.redhat.com/1086942
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/sos/plugins/ovirt.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31712
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib77f272a1246991cebff31ca710885d8798e5ce1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Petr Benas <pbenas(a)redhat.com>
Gerrit-Reviewer: Petr Beňas <petrbenas(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-image-uploader[master]: packaging: setup: Making error messages more verbose
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Making error messages more verbose
......................................................................
packaging: setup: Making error messages more verbose
Making error messages a bit more verbose to help the user
pointing out possible problems.
Change-Id: I7b7201b23adbb0ee7c452f9a936644b2b7b52ac4
Bug-Url: https://bugzilla.redhat.com/1146070
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/__main__.py
1 file changed, 32 insertions(+), 11 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit http://gerrit.ovirt.org/33262
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b7201b23adbb0ee7c452f9a936644b2b7b52ac4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-image-uploader
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-iso-uploader[master]: packaging: setup: Making error messages more verbose
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Making error messages more verbose
......................................................................
packaging: setup: Making error messages more verbose
Making error messages a bit more verbose to help the user
pointing out possible problems.
Change-Id: I0a722d37420f4a3c9b0af09dc483cc9d73b4faff
Bug-Url: https://bugzilla.redhat.com/1144836
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/__main__.py
1 file changed, 29 insertions(+), 11 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit http://gerrit.ovirt.org/33263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a722d37420f4a3c9b0af09dc483cc9d73b4faff
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in jenkins[master]: mock: adding fedora 21 config file
by dcaroest@redhat.com
David Caro has submitted this change and it was merged.
Change subject: mock: adding fedora 21 config file
......................................................................
mock: adding fedora 21 config file
Change-Id: I259f1cef33022cece8f4ee6711ca7514d5541da9
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
A mock_configs/fedora-21-x86_64.cfg
1 file changed, 63 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified
David Caro: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33322
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I259f1cef33022cece8f4ee6711ca7514d5541da9
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
10 years, 6 months
Change in ovirt-engine[master]: core: fix AddVmParameters for null diskInfoList
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: fix AddVmParameters for null diskInfoList
......................................................................
core: fix AddVmParameters for null diskInfoList
In change I06f2de3db1b0559af4df04d0d158b10b8460c684:
b7804ad core: cleanup AddVmParameters constructors
the logic in charge to ensure that diskInfoList is never null was
removed.
When a new VM is added from rest-api addVmFromScratch(...) sets
diskInfoList to a null value:
AddVmParameters params = new AddVmParameters(staticVm);
params.setDiskInfoList(mapDisks(vm.getDisks()));
resulting in a NPE:
ERROR [AddVmFromScratchCommand] Error during CanDoActionFailure:
java.lang.NullPointerException
at checkImagesConfiguration(ImagesHandler.java:455) [bll.jar:]
at canDoAction(AddVmFromScratchCommand.java:150) [bll.jar:]
at internalCanDoAction(CommandBase.java:746) [bll.jar:]
Change-Id: I979bd6373e4a1440f88d27e416bd2e116b010891
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmParameters.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Federico Simoncelli: Verified
Omer Frenkel: Looks good to me, approved
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/33294
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I979bd6373e4a1440f88d27e416bd2e116b010891
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-reports[master]: packaging: setup: pep8 fixes
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: pep8 fixes
......................................................................
packaging: setup: pep8 fixes
Change-Id: I46d8bd70a852b0551caf7908e775b9cc161d8556
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/jboss.py
3 files changed, 6 insertions(+), 13 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46d8bd70a852b0551caf7908e775b9cc161d8556
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 6 months