September 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: use last successful proxy in wait-for-status

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: use last successful proxy in wait-for-status ...................................................................... core: use last successful proxy in wait-for-status Power Management proxy selection keep selecting the same proxy first even is it constantly fails This patch changes the waiting for status after stop/start PM action to use the last successful proxy along the wait-for-status loop instead of searching for proxy each time that might be resulted in significant delays in case that the preferred proxy (according to the proxy selection settings_ has some connectivity issues and can not access the PM card. Change-Id: I7684826be6098e952134366ce480ddb1ca3a2c99 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1141514 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java 1 file changed, 27 insertions(+), 25 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7684826be6098e952134366ce480ddb1ca3a2c99 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: core: ExportVMCommand storage allocation checks

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: ExportVMCommand storage allocation checks ...................................................................... core: ExportVMCommand storage allocation checks This patch is a part of a series of patches, adding storage allocation validations to the system when they're missing, and replacing old verification usage with unified, new, correct and tested verification. This patch did this for ExportVmCommand, using only existing validations. Change-Id: Ic65fdc7324babacda2d1d49dc7157f6799b922f2 Bug-Url: https://bugzilla.redhat.com/1053747 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 1 file changed, 23 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/32966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic65fdc7324babacda2d1d49dc7157f6799b922f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: core: allowed to add network label even if Vm using this net...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: allowed to add network label even if Vm using this network is running. ...................................................................... core: allowed to add network label even if Vm using this network is running. ~ Network label was checked to be unchanged in method 'onlyPermittedFieldsChanged'. This is extracted out into new method 'allowedNetworkLabelManipulation' which returns true if network label was not changed, or if former label was not specified (null) and new one is specified (!=null). ~ moved methods out from non static SyncNetworkParametersBuilder. These methods can be used outside from SyncNetworkParametersBuilder, but in that case their owning class have to be instantiated using CommandContext parameter, which is completely unrelated to these four methods. Bug-Url: https://bugzilla.redhat.com/1134009 Change-Id: Ic4e37a36bc8ae1b5614c3c6d218fb13a4e59a021 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 22 insertions(+), 16 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32968 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4e37a36bc8ae1b5614c3c6d218fb13a4e59a021 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: removing default storage type question

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: removing default storage type question ...................................................................... packaging: setup: removing default storage type question Reviewing it, we found that the question is superfluous since almost all the user will choose 'shared'. Change-Id: Ia7e1ac239b4ad37580bc7ce0863734c60efa7cf5 Bug-Url: https://bugzilla.redhat.com/1102021 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py 1 file changed, 2 insertions(+), 21 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/32710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7e1ac239b4ad37580bc7ce0863734c60efa7cf5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: core: changing error severity of illegal search

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: changing error severity of illegal search ...................................................................... core: changing error severity of illegal search WARN message logged versus DEBUG or INFO message with rhevm-shell provided bogus search This patch changes the severity of illegal searches done by the user from WARN to INFO Change-Id: Ic6abcdc24e1538937cc317c2fc13a913cb542786 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1142132 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6abcdc24e1538937cc317c2fc13a913cb542786 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: packaging: setup: use env statement at misc in single_etl

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: use env statement at misc in single_etl ...................................................................... packaging: setup: use env statement at misc in single_etl misc stage runs also if new_database, where self._statement is not set. Change-Id: Iaedbda91fcd055f31069bee7afab75ade5891959 Bug-Url: https://bugzilla.redhat.com/1118350 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit e74d8d8745d034d3549542bdb12f084c6878a5b6) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/single_etl.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaedbda91fcd055f31069bee7afab75ade5891959 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: ImportVmFromConfiguration - @Override

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVmFromConfiguration - @Override ...................................................................... core: ImportVmFromConfiguration - @Override Added missing @Override annotation. Change-Id: I0dfedd47a8378864762167c401a46524b9968f95 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0dfedd47a8378864762167c401a46524b9968f95 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: ImportVmFromConfiguration - modifiers

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVmFromConfiguration - modifiers ...................................................................... core: ImportVmFromConfiguration - modifiers Added static modifiers where possible to fix an IntelliJ IDEA warning. Change-Id: I2ea40b538e5f6ac9020a36204a7ce9f7a64e86a8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ea40b538e5f6ac9020a36204a7ce9f7a64e86a8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.4]: ovirt-iso-uploader: fixing usage of API SDK insecure parameter

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-iso-uploader: fixing usage of API SDK insecure parameter ...................................................................... ovirt-iso-uploader: fixing usage of API SDK insecure parameter Python SDK insecure parameter simply skips hostname validation, it still gives errors if we also pass an unmatching CA cert. Change-Id: Ie72fbef874f595d60e0441a212329dfb07223c16 Bug-Url: https://bugzilla.redhat.com/1142131 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 17 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/32604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie72fbef874f595d60e0441a212329dfb07223c16 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.4 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: engine : VMs pool disappeared after creating a Sub Template ...

by yzaslavs＠redhat.com

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : VMs pool disappeared after creating a Sub Template version ...................................................................... engine : VMs pool disappeared after creating a Sub Template version VMs pool disappeared after creating a Sub Template version with exception constructor not found Change-Id: I7a4833182c3e9302308520a661e1318e366cb04d Bug-Url: https://bugzilla.redhat.com/1138419 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java 1 file changed, 19 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a4833182c3e9302308520a661e1318e366cb04d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits September 2014