September 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: removing default storage type question

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: setup: removing default storage type question ...................................................................... packaging: setup: removing default storage type question Reviewing it, we found that the question is superfluous since almost all the user will choose 'shared'. Change-Id: Ia7e1ac239b4ad37580bc7ce0863734c60efa7cf5 Bug-Url: https://bugzilla.redhat.com/1138249 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py 1 file changed, 1 insertion(+), 19 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/32711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90cde87b8aaf9cc5b76737f2869b8ab25228c444 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: moved methods out from non static SyncNetworkParameter...

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: core: moved methods out from non static SyncNetworkParametersBuilder ...................................................................... core: moved methods out from non static SyncNetworkParametersBuilder These methods can be used outside from SyncNetworkParametersBuilder, but in that case their owning class have to be instantiated using CommandContext parameter, which is completely unrelated to these four methods. Change-Id: I8adb975731d8e3a0367585a65993ec53d538fba3 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 14 insertions(+), 14 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8adb975731d8e3a0367585a65993ec53d538fba3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: ExportVMCommand storage allocation checks

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: ExportVMCommand storage allocation checks ...................................................................... core: ExportVMCommand storage allocation checks This patch is a part of a series of patches, adding storage allocation validations to the system when they're missing, and replacing old verification usage with unified, new, correct and tested verification. This patch does this for ExportVmCommand, using only existing validations. Change-Id: Ic65fdc7324babacda2d1d49dc7157f6799b922f2 Bug-Url: https://bugzilla.redhat.com/1053747 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 1 file changed, 23 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/32897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic65fdc7324babacda2d1d49dc7157f6799b922f2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.5]: ovirt-iso-uploader: fixing usage of API SDK insecure parameter

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-iso-uploader: fixing usage of API SDK insecure parameter ...................................................................... ovirt-iso-uploader: fixing usage of API SDK insecure parameter Python SDK insecure parameter simply skips hostname validation, it still gives errors if we also pass an unmatching CA cert. Change-Id: Ie72fbef874f595d60e0441a212329dfb07223c16 Bug-Url: https://bugzilla.redhat.com/1136768 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 17 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/32596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie72fbef874f595d60e0441a212329dfb07223c16 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix Coverity Scan on getVdsStaticDao method

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix Coverity Scan on getVdsStaticDao method ...................................................................... core: Fix Coverity Scan on getVdsStaticDao method Coverity Scan marked getVdsStaticDao method name as confusing. This patch pulls up this method to AuditLogableBase Change-Id: I69ea5f345e6758939a01997e161cd064a4c1d7f4 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommandTest.java 6 files changed, 6 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liran Zelkha: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32954 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69ea5f345e6758939a01997e161cd064a4c1d7f4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: build: fix jboss deploy location

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: build: fix jboss deploy location ...................................................................... packaging: build: fix jboss deploy location broken by I88563c8c0 Change-Id: Id578f163f355b15743be1685038530047c39bfcc Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id578f163f355b15743be1685038530047c39bfcc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: use last successful proxy in wait-for-status

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: use last successful proxy in wait-for-status ...................................................................... core: use last successful proxy in wait-for-status Power Management proxy selection keep selecting the same proxy first even is it constantly fails This patch changes the waiting for status after stop/start PM action to use the last successful proxy along the wait-for-status loop instead of searching for proxy each time that might be resulted in significant delays in case that the preferred proxy (according to the proxy selection settings_ has some connectivity issues and can not access the PM card. Change-Id: I7684826be6098e952134366ce480ddb1ca3a2c99 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java 1 file changed, 27 insertions(+), 25 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7684826be6098e952134366ce480ddb1ca3a2c99 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: osinfo - add unsupported list of CPUs

by rgolan＠redhat.com

Roy Golan has submitted this change and it was merged. Change subject: core: osinfo - add unsupported list of CPUs ...................................................................... core: osinfo - add unsupported list of CPUs adding a comma separated list of unsupported CPUs to osinfo and 2 verbs to query it: public Map<Pair<Integer, Version>, Set<String>> getUnsupportedCpus(); public boolean isCpuSupported(int osId, Version version, String cpuId); Change-Id: I339b87de7646b813aa634102c26f710b9d5f6f75 Bug-Url: https://bugzilla.redhat.com/1096851 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java M packaging/conf/osinfo-defaults.properties 4 files changed, 89 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32923 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I339b87de7646b813aa634102c26f710b9d5f6f75 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Change cluster command should lock host

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Change cluster command should lock host ...................................................................... core: Change cluster command should lock host This patch adds a missing lock when host cluster is changed. Prior to this change the host was not locked allowing a concurrent removal of the host to occur while the change cluster operation is still running this resulted on a SQL exception while trying to add a line to host SPM mapping table with a host GUID when the host was already removed. Change-Id: I1cd9e237838ce03438d806160d08efc9db0d6cd7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1102729 Signed-off-by: Eli Mesika <emesika(a)redhat.com> (cherry picked from commit abe3413e0e8c7056f764ebfc06e7c43b13371d0e) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cd9e237838ce03438d806160d08efc9db0d6cd7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: aaa: fix coverity issue, default encoding

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: restapi: aaa: fix coverity issue, default encoding ...................................................................... restapi: aaa: fix coverity issue, default encoding Topic: AAA Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: I5de36d41c23d548fb4a6d91902cbd00f358e09c5 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResource.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5de36d41c23d548fb4a6d91902cbd00f358e09c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits September 2014