September 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: engine : CoCo: Set status at end of command execution

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: engine : CoCo: Set status at end of command execution ...................................................................... engine : CoCo: Set status at end of command execution Set status of commands without child commands and commands without command callbacks at the end of command execution Change-Id: Ifc3960568993baf888a3d9f74e7fad4bd0589823 Bug-Url: https://bugzilla.redhat.com/1133041 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32715 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc3960568993baf888a3d9f74e7fad4bd0589823 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: don't allow to create VM with balloon on ppc64

by gchaplik＠redhat.com

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: don't allow to create VM with balloon on ppc64 ...................................................................... engine: don't allow to create VM with balloon on ppc64 Change-Id: Iee077b08a825e65de2cddce85bc88573e89da4ab Bug-Url: https://bugzilla.redhat.com/1127677 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 90 insertions(+), 2 deletions(-) Approvals: Jiří Moskovčák: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee077b08a825e65de2cddce85bc88573e89da4ab Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fixing fencing flow for blocked proxy

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: fixing fencing flow for blocked proxy ...................................................................... core: fixing fencing flow for blocked proxy This patch fixes the following scenario : DC1 with H1 (with PM) and H2 on cluster C1 another host H3 on DC1 cluster C2 When we are blocking the communication with iptables from H2 to H1 PM card and use the default proxy preferences (cluster, dc) a Restart operation will always fail. The fix relies on the return code from the script that was executed by VDSM rather than the proceedProxyReturnValue call that throws an exception and also set the execution result according to that code. In addition a missing initialization of the 'count' variable in the 'for' loop has been added. This BZ depends also in a VDSM fix that makes stop/start operation sync instead of fire-and-forget. Change-Id: I70d35967554c88c943c4653a26642e6e21cc54d2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1129381 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70d35967554c88c943c4653a26642e6e21cc54d2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: snapshot preview - display entities in description

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: snapshot preview - display entities in description ...................................................................... webadmin: snapshot preview - display entities in description VMs -> Snapshots: when previewing a snapshot, display previewed entities under description column (see screenshot). Screenshot: http://i.imgur.com/JlWWZkZ.png Change-Id: I2345339fd61cf273224b565c60745fddb64c6ab3 Bug-Url: https://bugzilla.redhat.com/1126211 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/snapshot/SnapshotsViewColumns.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 7 files changed, 72 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/32754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2345339fd61cf273224b565c60745fddb64c6ab3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: register VM dialog - select first VM

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: register VM dialog - select first VM ...................................................................... webadmin: register VM dialog - select first VM Register VM/Template dialog: select first entity by default. Change-Id: I55411454fedbc97deed2b4a30c759be69e198fc7 Bug-Url: https://bugzilla.redhat.com/1136756 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterEntityPopupView.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/32753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55411454fedbc97deed2b4a30c759be69e198fc7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: RegisterVmInfoPanel - getAppList nullity check

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: RegisterVmInfoPanel - getAppList nullity check ...................................................................... webadmin: RegisterVmInfoPanel - getAppList nullity check RegisterVmInfoPanel -> updateTabsData -> vm.getAppList() might return null on new VMs. Change-Id: I78346b1df26b203e5075385c0c7e67e8bd4c3344 Bug-Url: https://bugzilla.redhat.com/1136756 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmInfoPanel.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/32752 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78346b1df26b203e5075385c0c7e67e8bd4c3344 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: core: explicit warning on live snapshot failure

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: explicit warning on live snapshot failure ...................................................................... core: explicit warning on live snapshot failure On live snapshot failure, added an explicit warning stating that using the created snapshot might cause data inconsistency. Change-Id: Ib91c9d947a90e3b8fdd872bb3996dfb839e7767a Bug-Url: https://bugzilla.redhat.com/1119203 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib91c9d947a90e3b8fdd872bb3996dfb839e7767a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Focus on label widget by default

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Focus on label widget by default ...................................................................... webadmin: Focus on label widget by default Added default focus on the label widget in HostNicPopupView. This required implementing focusInput() in AddRemoveRowWidget, as well as a slight modification in ListModelSuggestBox to make sure suggestion menu positioning happens shortly after the dialog is displayed (without it, the suggestion menu was ill-positioned). Change-Id: I36c9ae0b7ac9d61112ace1829434c9c685b85a22 Bug-Url: https://bugzilla.redhat.com/1134200 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostNicPopupView.java 3 files changed, 27 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36c9ae0b7ac9d61112ace1829434c9c685b85a22 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine-sdk-java[sdk_3.5]: sdk: Prepare for next development iteration

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Prepare for next development iteration ...................................................................... sdk: Prepare for next development iteration In preparation for the next development iteration this patch increases the version number, adds the SNAPSHOT suffix to the maven version and sets the RPM release number to 0.1. Change-Id: I3a87233160acd82106b03e0aaec06722311fe7e1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java/Makefile M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in M ovirt-engine-sdk-java/pom.xml 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a87233160acd82106b03e0aaec06722311fe7e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine-sdk-java[sdk_3.5]: sdk: Release 3.5.0.5

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Release 3.5.0.5 ...................................................................... sdk: Release 3.5.0.5 Change-Id: I9ddf01af7e9645520272f106110fae4af08b2489 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java/Makefile M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in M ovirt-engine-sdk-java/pom.xml 3 files changed, 6 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ddf01af7e9645520272f106110fae4af08b2489 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 7 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits September 2014