September 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: packaging: jsonrpc version update

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: jsonrpc version update ...................................................................... packaging: jsonrpc version update Bug-Url: https://bugzilla.redhat.com/1136876 Change-Id: Ib8bde0cc1e54366be10042085265ef988ae53450 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8bde0cc1e54366be10042085265ef988ae53450 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: cleanup in AddVmFromScratchParameters

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: cleanup in AddVmFromScratchParameters ...................................................................... core: cleanup in AddVmFromScratchParameters - Remove unused network related data - Remove the 'private' prefix from privateDiskInfoList field Change-Id: Iea82daa2f1afc2440ac71732e6896ddcad3c7673 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromScratchParameters.java 1 file changed, 3 insertions(+), 15 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/32639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea82daa2f1afc2440ac71732e6896ddcad3c7673 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Remove redundant header splitters in fixed columns

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Remove redundant header splitters in fixed columns ...................................................................... webadmin: Remove redundant header splitters in fixed columns This was previously fixed in resizable columns, but not in fixed ones. Change-Id: I0090109d3cc2c4a18418fef49eaf09b8a5c52915 Bug-Url: https://bugzilla.redhat.com/1139551 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0090109d3cc2c4a18418fef49eaf09b8a5c52915 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: The text and buttons not aligned in Create VM dialog

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: The text and buttons not aligned in Create VM dialog ...................................................................... webadmin: The text and buttons not aligned in Create VM dialog The http://gerrit.ovirt.org/#/c/30821 enhanced the "Guide Me" dialog so also the bigger text will fit in. The problem with this patch is that it uses the "display: flex" which is not supported by firefox 17 and firefox 17 is the only browser supported by oVirt. So this patch "reverts" this fix and applyes the one proposed here: http://gerrit.ovirt.org/#/c/30861/ which does not look so nice but works also on older browsers. Change-Id: Ifcb74f036476fb8544d1f15d26a0ef92e2eeed46 Bug-Url: https://bugzilla.redhat.com/1135965 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 3 files changed, 12 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcb74f036476fb8544d1f15d26a0ef92e2eeed46 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: core : Invalid action group identifiers in the roles_groups...

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: core : Invalid action group identifiers in the roles_groups table ...................................................................... core : Invalid action group identifiers in the roles_groups table invalid action groups in roles_groups table causes NPE when listing permits using restapi. The roles groups 130 and 131 as listed in roles_groups table are not valid role group ids and are can be safely removed. The ids were erroneosuly ntroduced into the roles_groups table by commit c89b145f12d77a7271d63073d5. The correct action group id for install vds and upgrade oVirtNode is 101(EDIT_HOST_CONFIGURATION) and is already present in the roles_groups table. Change-Id: Ib511e7c3a657c884a92ddee5e7972bd3e7a95497 Bug-Url: https://bugzilla.redhat.com/1139533 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit 11f323c2bca08171f084811baf5d142225ee0e6b) --- A packaging/dbscripts/upgrade/03_05_1040_remove_install_vds_upgrade_ovirt_node_action_group.sql 1 file changed, 38 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib511e7c3a657c884a92ddee5e7972bd3e7a95497 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core : Invalid action group identifiers in the roles_groups...

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: core : Invalid action group identifiers in the roles_groups table ...................................................................... core : Invalid action group identifiers in the roles_groups table invalid action groups in roles_groups table causes NPE when listing permits using restapi. The roles groups 130 and 131 as listed in roles_groups table are not valid role group ids and are can be safely removed. The ids were erroneosuly ntroduced into the roles_groups table by commit c89b145f12d77a7271d63073d5. The correct action group id for install vds and upgrade oVirtNode is 101(EDIT_HOST_CONFIGURATION) and is already present in the roles_groups table. Change-Id: Ib511e7c3a657c884a92ddee5e7972bd3e7a95497 Bug-Url: https://bugzilla.redhat.com/1139533 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_0360_remove_install_vds_upgrade_ovirt_node_action_group.sql 1 file changed, 38 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib511e7c3a657c884a92ddee5e7972bd3e7a95497 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: The scroll bar is not aligned with the Edit Role m...

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: The scroll bar is not aligned with the Edit Role menu box ...................................................................... webadmin: The scroll bar is not aligned with the Edit Role menu box In edit role dialog the permissions tree scroll bar is not aligned with edit role menu box Change-Id: I03e80765cffddd77c95d80ee386bbea4fd16d620 Bug-Url: https://bugzilla.redhat.com/1128449 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03e80765cffddd77c95d80ee386bbea4fd16d620 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: Avoid engine DB password in answerfile if ...

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: setup: Avoid engine DB password in answerfile if providing ...................................................................... packaging: setup: Avoid engine DB password in answerfile if providing If engine-setup is providing the DB the DB password is randomly generated. Avoiding to write it in the answer file, the password will be randomly choosed also replaying that answer file. Change-Id: I3fb9d2c10d3809c68430084f6212eaa191d5ca21 Bug-Url: https://bugzilla.redhat.com/1139211 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py 2 files changed, 11 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/32651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fb9d2c10d3809c68430084f6212eaa191d5ca21 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: style fixes in manage events popup.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: style fixes in manage events popup. ...................................................................... webadmin: style fixes in manage events popup. Change-Id: Ie7b8063d60666bdbcaaeaa7347ff36b7a3ddc369 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133572 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> (cherry picked from commit fc8ccf4ca617cc876eb8df428ee25a7a9a765557) --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/css/NotificationsTree.css 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Looks good to me, approved mooli tayer: Verified -- To view, visit http://gerrit.ovirt.org/32675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7b8063d60666bdbcaaeaa7347ff36b7a3ddc369 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: vm name field is misaligned on "new vm" pop up window

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: vm name field is misaligned on "new vm" pop up window ...................................................................... webadmin: vm name field is misaligned on "new vm" pop up window The mistake happend during the backport. The patch to master branch (http://gerrit.ovirt.org/#/c/31034) contains the configuration of the "nameEditorContent" as "width: 238px", while the backport patch (http://gerrit.ovirt.org/#/c/31159) contains the width: "230px". This patch fixes this backport mistake to make also the 3.5 version 238px width. Change-Id: I05dba94b33a72ae0644b4f543d257efed52a3fb4 Bug-Url: https://bugzilla.redhat.com/1133995 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Alexander Wels: Looks good to me, approved Martin Betak: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05dba94b33a72ae0644b4f543d257efed52a3fb4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits September 2014