Change in ovirt-engine[master]: core: added missing events to event_map
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: added missing events to event_map
......................................................................
core: added missing events to event_map
The VDS_ACTIVATE_MANUAL_HA and CLUSTER_ALERT_HA_RESERVATION_DOWN
were missing from EVENT_MAP table, causing error in the notification mechanism.
Change-Id: I6e5efecc1f9cc9dc8bbcf879d7c172cde82a8dc6
Bug-Url: https://bugzilla.redhat.com/1119285
Signed-off-by: Kobi Ianko <kobi(a)redhat.com>
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_06_0340_add_vds_activate_manual_ha_to_event_map.sql
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Jiří Moskovčák: Verified
mooli tayer: Looks good to me, but someone else must approve
Doron Fediuck: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30680
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e5efecc1f9cc9dc8bbcf879d7c172cde82a8dc6
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-dwh[master]: history: updated runTime from engine db
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: history: updated runTime from engine db
......................................................................
history: updated runTime from engine db
updated context.runTime to get timstmp from engine
db instead of history db, so when on that when
the dbs are on seperate hosts the update date and
delete date when a record is deleted will be in
engine db time as all other records.
Change-Id: I117324fcd5b961e83cb3491f8678c9a856754985
Bug-Url: https://bugzilla.redhat.com/1133608
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M etl_export/src/ovirt_engine_dwh/dailytimekeepingjob_3_5/DailyTimeKeepingJob.java
M etl_export/src/ovirt_engine_dwh/deletetimekeepingjob_3_5/DeleteTimeKeepingJob.java
M etl_export/src/ovirt_engine_dwh/hourlytimekeepingjob_3_5/HourlyTimeKeepingJob.java
M etl_export/src/ovirt_engine_dwh/parallelrun_3_5/ParallelRun.java
M etl_export/src/ovirt_engine_dwh/sampletimekeepingjob_3_5/SampleTimeKeepingJob.java
M etl_export/src/ovirt_engine_dwh/statisticssync_3_5/StatisticsSync.java
M tos_project/process/DailyTimeKeepingJob_3.5.item
M tos_project/process/DailyTimeKeepingJob_3.5.properties
M tos_project/process/DeleteTimeKeepingJob_3.5.item
M tos_project/process/DeleteTimeKeepingJob_3.5.properties
M tos_project/process/HourlyTimeKeepingJob_3.5.item
M tos_project/process/HourlyTimeKeepingJob_3.5.properties
M tos_project/process/ParallelRun_3.5.item
M tos_project/process/ParallelRun_3.5.properties
M tos_project/process/SampleTimeKeepingJob_3.5.item
M tos_project/process/SampleTimeKeepingJob_3.5.properties
M tos_project/process/StatisticsSync_3.5.item
M tos_project/process/StatisticsSync_3.5.properties
18 files changed, 65 insertions(+), 34 deletions(-)
Approvals:
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32240
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I117324fcd5b961e83cb3491f8678c9a856754985
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Consolidated common test of add/update storage connection
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Consolidated common test of add/update storage connection
......................................................................
core: Consolidated common test of add/update storage connection
AddStorageServerConnection and UpdateStorageServerConnection command tests
contained simiar tests, those common tests were extracted to a parent test
class for better readability and easier maintenance
Change-Id: Iad571ca0c5788c375200847e8872706a8dfd7f3e
Bug-Url: https://bugzilla.redhat.com/1129597
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionTestCommon.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java
3 files changed, 148 insertions(+), 195 deletions(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32488
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad571ca0c5788c375200847e8872706a8dfd7f3e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Consolidated similar validations in add/update storage...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Consolidated similar validations in add/update storage connection CDA
......................................................................
core: Consolidated similar validations in add/update storage connection CDA
AddStorageServerConnection & UpdateStorageServerConnection command both
contained a lot of similar validations in the CDA part, all those validations
were extracted to the parent class for better readability and easier
maintenance
Change-Id: Id90cea934e0a9c10c5df435f564530b8658a64bb
Bug-Url: https://bugzilla.redhat.com/1129597
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
3 files changed, 31 insertions(+), 45 deletions(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32487
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id90cea934e0a9c10c5df435f564530b8658a64bb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: changing "Cluster Policy" to "Scheduling Policy"
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: changing "Cluster Policy" to "Scheduling Policy"
......................................................................
webadmin: changing "Cluster Policy" to "Scheduling Policy"
Change-Id: I783489e9b9f71825a5a4ec54847cb002885c3694
Bug-Url: https://bugzilla.redhat.com/1099098
Signed-off-by: Kobi Ianko <kobi(a)redhat.com>
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 26 insertions(+), 26 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30177
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I783489e9b9f71825a5a4ec54847cb002885c3694
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: engine: white space fixes
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: engine: white space fixes
......................................................................
engine: white space fixes
Change-Id: I9e87c564deb97d615b2310c9cdbe2592ead84bde
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
3 files changed, 11 insertions(+), 11 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32483
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e87c564deb97d615b2310c9cdbe2592ead84bde
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[master]: core: Fixing events search with from keyword
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Fixing events search with from keyword
......................................................................
core: Fixing events search with from keyword
using from filter in an event search doesn't work
Restoring support of 'from' clause for event search.
Change-Id: I1c31ae7953fa4921fd912e4a7b94d3081d4e09a1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131030
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32486
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c31ae7953fa4921fd912e4a7b94d3081d4e09a1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[master]: core: Added tests for validation on managed custom mount option
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Added tests for validation on managed custom mount option
......................................................................
core: Added tests for validation on managed custom mount option
Change-Id: I678e116b8a534b69f87be59f9be8813b08cb6910
Bug-Url: https://bugzilla.redhat.com/1129597
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionTestCommon.java
3 files changed, 92 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32373
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I678e116b8a534b69f87be59f9be8813b08cb6910
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: Added validation on managed custom mount option
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Added validation on managed custom mount option
......................................................................
core: Added validation on managed custom mount option
When adding a new NFS/Posix storage server connection, if the custom mount
options contains a managed option (i.e. property that the engine is managing
directly), the command will fail with a CDA
Change-Id: Icc5a74379de55aa81194298be634f689efd331d5
Bug-Url: https://bugzilla.redhat.com/1129597
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 40 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32372
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc5a74379de55aa81194298be634f689efd331d5
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: Consolidated common test of add/update storage connection
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Consolidated common test of add/update storage connection
......................................................................
core: Consolidated common test of add/update storage connection
AddStorageServerConnection and UpdateStorageServerConnection command tests
contained simiar tests, those common tests were extracted to a parent test
class for better readability and easier maintenance
Change-Id: Iad571ca0c5788c375200847e8872706a8dfd7f3e
Bug-Url: https://bugzilla.redhat.com/1129597
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionTestCommon.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java
3 files changed, 148 insertions(+), 195 deletions(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32371
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad571ca0c5788c375200847e8872706a8dfd7f3e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months