Change in ovirt-engine[ovirt-engine-3.5]: core: fixing missing (English) AuditLog values
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: fixing missing (English) AuditLog values
......................................................................
core: fixing missing (English) AuditLog values
Fixing the reported messages in the BZ
A '+' sign marks that issue was addresses and a message was added
a '-' sign marks that issue was not addressed with the reason
UNASSIGNED +
VDS_AUTO_FENCE_STATUS +
VDS_AUTO_FENCE_STATUS_FAILED +
VDS_AUTO_FENCE_FAILED_CALL_FENCE_SPM +
VDS_HIGH_NETWORK_USE - Deprecated
USER_FAILED_REMOVE_VM - Deprecated
USER_RUN_UNLOCK_ENTITY_SCRIPT - Used only from SQL script therefor
should not have severity & message
VDS_NETWORK_MTU_DIFFER_FROM_LOGICAL_NETWORK - Deprecated
VDS_HOST_IN_CONNECTING_STATE - handled in
http://gerrit.ovirt.org/#/c/31886/
STORAGE_ACTIVATE_ASYNC - Deprecated
DWH_STOPPED +
DWH_STARTED +
DWH_ERROR +
USER_REMOVE_AUDIT_LOG +
USER_REMOVE_AUDIT_LOG_FAILED +
USER_CLEAR_ALL_DISMISSED_AUDIT_LOG +
USER_CLEAR_ALL_DISMISSED_AUDIT_LOG_FAILED +
Change-Id: I74a08a8c7d5f18707bf8cbcac5d9d169c5556def
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1119186
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAuditLogByIdCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 15 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32192
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74a08a8c7d5f18707bf8cbcac5d9d169c5556def
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: engine: Add separate validation for multicast MAC address
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Add separate validation for multicast MAC address
......................................................................
engine: Add separate validation for multicast MAC address
Split MAC address format validation into two separate ones:
1. Valid MAC address
2. Unicast MAC address
Change-Id: I4077a14fb61c2e082db9f81f1ded3b25ca98fc3f
Bug-Url: https://bugzilla.redhat.com/1118385
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacRange.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNic.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/MacAddressValidationPatterns.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/MacAddressPatternTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 96 insertions(+), 37 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32196
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4077a14fb61c2e082db9f81f1ded3b25ca98fc3f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: organize the list of command packages
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: organize the list of command packages
......................................................................
core: organize the list of command packages
Minor cleanup in CommandsFactory: organize the list of command packages
such that it will be a bit more readable
Change-Id: I40ef6e6b35c53c43ee4b2baaace239eb9b38889b
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
1 file changed, 21 insertions(+), 17 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/32380
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40ef6e6b35c53c43ee4b2baaace239eb9b38889b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: engine, userportal, webadmin:Remove ACTION_TYPE_FAILED_VM_NOT_...
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine,userportal,webadmin:Remove ACTION_TYPE_FAILED_VM_NOT_EXIST
......................................................................
engine,userportal,webadmin:Remove ACTION_TYPE_FAILED_VM_NOT_EXIST
Prior to this change 2 almost identical messages exist in the code:
* ACTION_TYPE_FAILED_VM_NOT_FOUND
* ACTION_TYPE_FAILED_VM_NOT_EXIST
The change replaces all usages of ACTION_TYPE_FAILED_VM_NOT_EXIST with
ACTION_TYPE_FAILED_VM_NOT_FOUND and removes the definition of the first.
Change-Id: Ib3204225b8cdc870b0292aeb8c71af4c8f13ff10
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CancelMigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetNumberOfCpusCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RebootVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmSlaPolicyCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ReorderVmNicsCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
18 files changed, 22 insertions(+), 30 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32005
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3204225b8cdc870b0292aeb8c71af4c8f13ff10
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: engine : Fix issues with ActionGroup
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine : Fix issues with ActionGroup
......................................................................
engine : Fix issues with ActionGroup
The changes made in 1c23ff57d14b531427d causes
issues in frontend while displaying the list of
permissions in new/edit role dialog
Change-Id: Ie60948707b4d5809b79e5a66c733f4dc96f9596c
Bug-Url: https://bugzilla.redhat.com/1138732
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java
2 files changed, 1 insertion(+), 6 deletions(-)
Approvals:
Ravi Nori: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie60948707b4d5809b79e5a66c733f4dc96f9596c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: Prevent to add OVEHOSTED_NETWORK/bridgeIf to answer file.
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Prevent to add OVEHOSTED_NETWORK/bridgeIf to answer file.
......................................................................
Prevent to add OVEHOSTED_NETWORK/bridgeIf to answer file.
If line added, second host installation use the same interface as
first host, but first and second host can have different interfaces,
so installation of second host failed, because uncorrect bridge interface.
Change-Id: I3a17b3e57439ff054cf0cb8f608de80f8946dd4d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136019
Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com>
(cherry picked from commit 9851d3c6cb40e3e52b52cedce0d778fcad17c3c7)
---
M src/ovirt_hosted_engine_setup/constants.py
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32522
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a17b3e57439ff054cf0cb8f608de80f8946dd4d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-hosted-engine-setup[master]: Prevent to add OVEHOSTED_NETWORK/bridgeIf to answer file.
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Prevent to add OVEHOSTED_NETWORK/bridgeIf to answer file.
......................................................................
Prevent to add OVEHOSTED_NETWORK/bridgeIf to answer file.
If line added, second host installation use the same interface as
first host, but first and second host can have different interfaces,
so installation of second host failed, because uncorrect bridge interface.
Change-Id: I3a17b3e57439ff054cf0cb8f608de80f8946dd4d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136019
Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a17b3e57439ff054cf0cb8f608de80f8946dd4d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Artyom Lukianov <alukiano(a)redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in jenkins[master]: jobs: start dropping fc19 support on master
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: jobs: start dropping fc19 support on master
......................................................................
jobs: start dropping fc19 support on master
oVirt 3.6 won't support fc19 anymore.
Change-Id: Iddc6583be5d6a813b8a355518728523528eab0b6
Related-To: http://lists.ovirt.org/pipermail/devel/2014-August/008519.html
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/yaml/jobs/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_create-rpms.yaml
M jobs/confs/yaml/jobs/ovirt-hosted-engine-setup/ovirt-hosted-engine-setup_create-rpms.yaml
M jobs/confs/yaml/jobs/ovirt-image-uploader/ovirt-image-uploader_create-rpms.yaml
M jobs/confs/yaml/jobs/ovirt-iso-uploader/ovirt-iso-uploader_create-rpms.yaml
M jobs/confs/yaml/jobs/ovirt-log-collector/ovirt-log-collector_create-rpms.yaml
M jobs/confs/yaml/jobs/vdsm/vdsm_install-rpm-sanity.yaml
6 files changed, 120 insertions(+), 17 deletions(-)
Approvals:
David Caro: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31659
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddc6583be5d6a813b8a355518728523528eab0b6
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in jenkins[master]: Using 3.5 nightly repo for fc19 builds
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Using 3.5 nightly repo for fc19 builds
......................................................................
Using 3.5 nightly repo for fc19 builds
Ovirt engine no longer builds for fc19, so for the extensions we need to use the
3.5 nightly repos instead of master.
Change-Id: I7b471d21d6280c94199b3bda38e341dcd08545ca
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/yaml/jobs/ovirt-engine-extension-aaa-ldap/ovirt-engine-extension-aaa-ldap_create-rpms.yaml
M jobs/confs/yaml/jobs/ovirt-engine-extension-aaa-misc/ovirt-engine-extension-aaa-misc_create-rpms.yaml
M jobs/confs/yaml/jobs/ovirt-engine-extension-logger-log4j/ovirt-engine-extension-logger-log4j_create-rpms.yaml
3 files changed, 14 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, but someone else must approve
David Caro: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b471d21d6280c94199b3bda38e341dcd08545ca
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: honouring engine DB parameters from answer...
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: packaging: setup: honouring engine DB parameters from answer file
......................................................................
packaging: setup: honouring engine DB parameters from answer file
Honouring engine DB parameters if present in the answer file.
Change-Id: I9a7f79f3da05d89b34fa2cc4f74ed628fb44e3b4
Bug-Url: https://bugzilla.redhat.com/1133621
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine_common/postgres.py
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
--
To view, visit http://gerrit.ovirt.org/32041
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a7f79f3da05d89b34fa2cc4f74ed628fb44e3b4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months