Change in ovirt-engine[master]: core: NPE when getVMFullList returns no vm information
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: NPE when getVMFullList returns no vm information
......................................................................
core: NPE when getVMFullList returns no vm information
When getVMFullList fetches no information the code fails with NPE.
Bug-Url: https://bugzilla.redhat.com/1135959
Change-Id: Ifa1971f1181489e50877d080aec36ebc6d715f74
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa1971f1181489e50877d080aec36ebc6d715f74
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[master]: webadmin: snapshot custom preview - excluded disks warning
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: snapshot custom preview - excluded disks warning
......................................................................
webadmin: snapshot custom preview - excluded disks warning
Snapshot custom preview dialog:
Display warning when excluding disks from the snapshot
(in order to emphasize that these disks will be removed).
Change-Id: I1fd866d6553d73233f0bb590d47c370d11ddd8f5
Bug-Url: https://bugzilla.redhat.com/1111983
Bug-Url: https://bugzilla.redhat.com/1111984
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCustomPreviewPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCustomPreviewPopupWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PreviewSnapshotModel.java
4 files changed, 57 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/32181
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fd866d6553d73233f0bb590d47c370d11ddd8f5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: cleanup - remove unused method
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: cleanup - remove unused method
......................................................................
core: cleanup - remove unused method
ImportVmCommnad.isDiskExists() is not used, therefore removed.
Change-Id: If71161c26b4718cb7e2981d9c03165abc923fda2
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Arik Hadas: Looks good to me, but someone else must approve
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/32207
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If71161c26b4718cb7e2981d9c03165abc923fda2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: restapi: Control\view Soundcard property
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Control\view Soundcard property
......................................................................
restapi: Control\view Soundcard property
* Added 'soundcard_enabled' property to REST VM/template/vmpool resource
(accessible via 'All-Content' header)
* Added support for property in:
VM/Template/Instance - Add / Update
Pool - Add
* Updated rsdl
* Updated tests
Change-Id: I598cf89b6a5fd4755958cf7b597484c225166460
Bug-Url: https://bugzilla.redhat.com/1021186
Signed-off-by: Eldan Shachar <eshachar(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VmHelper.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateBasedResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesBasedResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
16 files changed, 174 insertions(+), 6 deletions(-)
Approvals:
Eldan Shachar: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32255
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I598cf89b6a5fd4755958cf7b597484c225166460
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: SanStorageModel - ensure discover proposal
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: SanStorageModel - ensure discover proposal
......................................................................
webadmin: SanStorageModel - ensure discover proposal
iSCSI storage dialog:
ensure that 'Discover Targets' panel is expanded when
no targets are available.
Change-Id: I63a7f16020e9a5f4e8669e3441436cf5bb1f996d
Bug-Url: https://bugzilla.redhat.com/1134867
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/32200
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63a7f16020e9a5f4e8669e3441436cf5bb1f996d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: webadmin: import vm dialog - select-box style
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: import vm dialog - select-box style
......................................................................
webadmin: import vm dialog - select-box style
Register VM/Template dialog:
Styling select-box column to accommodate with the standard
'gwt-ListBox' style (see Cluster column in [1]).
[1] Screenshot: http://i.imgur.com/VmASmSJ.png
Change-Id: Ic5c61a3d2b54011f4a007562dbf352c71aad0e6f
Bug-Url: https://bugzilla.redhat.com/1131113
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterEntityPopupView.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/WebAdmin.css
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5c61a3d2b54011f4a007562dbf352c71aad0e6f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: try to start the vm even if other hosts have the same score
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: try to start the vm even if other hosts have the same score
......................................................................
try to start the vm even if other hosts have the same score
if there are hosts with the same best score all should try to start the VM
otherwise we might end up in the situation when every host thinks the others
are better and no one will start the VM
Change-Id: Ib1ab72dfd8c4f07268eabe3e6fdc7a74929d9308
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1119705
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/states.py
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jiří Moskovčák: Verified
--
To view, visit http://gerrit.ovirt.org/31515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1ab72dfd8c4f07268eabe3e6fdc7a74929d9308
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.1
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: engine: Change reorder vNIC action's permissions
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: engine: Change reorder vNIC action's permissions
......................................................................
engine: Change reorder vNIC action's permissions
Changed the aforementioned action to belong to ActionGroup.CREATE_VM
rather than ActionGroup.CONFIGURE_VM_NETWORK, as it's an integral part
of the process of creating a VM (it shouldn't be called in the context
of a pre-existing VM in order to re-arrange its NICs).
This might seem askew - this whole command can (and likely should) be
a part of the Create VM command, if that is changed to receive as a
parameter a list of NICs to create.
Change-Id: Iaef9b2e9ae9258210f48b59d89467247ff9a2468
Bug-Url: https://bugzilla.redhat.com/1134554
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Lior Vernia: Verified
Moti Asayag: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32226
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaef9b2e9ae9258210f48b59d89467247ff9a2468
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: restapi: Avoid permissions in VmBase
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Avoid permissions in VmBase
......................................................................
restapi: Avoid permissions in VmBase
A recent change (commit d2aa338) refactored the XML schema to simplify
the VM and template entities using a shared base type. Unfortunately
this change makes it impossible to generate the Java SDK, as it
generates conflicting get methods for the permissions sub collection.
Changing the Java SDK code generator to avoid this is possible but risky
for 3.5, so this patch changes the XML schema moving the "permissions"
property from the shared base type to the derived VM and template types.
This isn't ideal, but avoids the issue in the generator of the Java SDK.
Change-Id: I5aed6471a4f77a6df41ebd298f35807fbec616e1
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Martin Betak: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32248
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5aed6471a4f77a6df41ebd298f35807fbec616e1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.4]: core: avoid removing a vm also when migratingTo
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: avoid removing a vm also when migratingTo
......................................................................
core: avoid removing a vm also when migratingTo
The fix simplifies the check and states what states we CAN delete the VM
, otherwise fail canDoAction
Change-Id: I6d97fbe84a81a3a4704ed1d80d9b52da752c108a
Bug-Url: https://bugzilla.redhat.com/1136010
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
1 file changed, 11 insertions(+), 5 deletions(-)
Approvals:
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d97fbe84a81a3a4704ed1d80d9b52da752c108a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
