Change in ovirt-iso-uploader[ovirt-iso-uploader-3.5]: ovirt-iso-uploader: Add creation of KVM group
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-iso-uploader: Add creation of KVM group
......................................................................
ovirt-iso-uploader: Add creation of KVM group
Change-Id: I70e2a776059e735d7f50a4961bd99e33566cf163
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1129382
---
M ovirt-iso-uploader.spec.in
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32302
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70e2a776059e735d7f50a4961bd99e33566cf163
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: ovirt-iso-uploader-3.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-iso-uploader[master]: ovirt-iso-uploader: Add creation of KVM group
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-iso-uploader: Add creation of KVM group
......................................................................
ovirt-iso-uploader: Add creation of KVM group
Change-Id: I70e2a776059e735d7f50a4961bd99e33566cf163
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1129382
---
M ovirt-iso-uploader.spec.in
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Lev Veyde: Verified
Sandro Bonazzola: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32295
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70e2a776059e735d7f50a4961bd99e33566cf163
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-image-uploader[ovirt-image-uploader-3.5]: ovirt-image-uploader: Add creation of KVM group
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-image-uploader: Add creation of KVM group
......................................................................
ovirt-image-uploader: Add creation of KVM group
Change-Id: Ib114c06a82abbb6b6bf2c0311c9db8c2e55c62f8
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1111229
---
M ovirt-image-uploader.spec.in
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32301
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib114c06a82abbb6b6bf2c0311c9db8c2e55c62f8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-image-uploader
Gerrit-Branch: ovirt-image-uploader-3.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-image-uploader[master]: ovirt-image-uploader: Add creation of KVM group
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-image-uploader: Add creation of KVM group
......................................................................
ovirt-image-uploader: Add creation of KVM group
Change-Id: Ib114c06a82abbb6b6bf2c0311c9db8c2e55c62f8
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1111229
---
M ovirt-image-uploader.spec.in
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Lev Veyde: Verified
Sandro Bonazzola: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32296
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib114c06a82abbb6b6bf2c0311c9db8c2e55c62f8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-image-uploader
Gerrit-Branch: master
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: cleanup - removed unused methods
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: cleanup - removed unused methods
......................................................................
core: cleanup - removed unused methods
Removed unused methods in StorageDomainCommandBase.
Change-Id: I9e3b962c9fe747e493f2d8fb12ae8f27651ca0c4
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
1 file changed, 0 insertions(+), 27 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e3b962c9fe747e493f2d8fb12ae8f27651ca0c4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: core: improving FenceExecuter code readability
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: improving FenceExecuter code readability
......................................................................
core: improving FenceExecuter code readability
Change-Id: I4c248888b94e51eb90c58dd1803715b9a328ea7e
Signed-off-by: root <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java
1 file changed, 18 insertions(+), 22 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32249
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c248888b94e51eb90c58dd1803715b9a328ea7e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[master]: tools: Make "No transport ..." error more understandable
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: tools: Make "No transport ..." error more understandable
......................................................................
tools: Make "No transport ..." error more understandable
Makes current error message "No transport is enabled, nothing to do"
more understandable to users:
"No transport is enabled, please enable SMTP (using MAIL_SERVER option)
or SNMP (using SNMP_MANAGERS option)."
Change-Id: I8aa720ff3d15ed45ec59035926bd2db8b7f2d020
Bug-Url: https://bugzilla.redhat.com/1136026
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified
mooli tayer: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32241
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8aa720ff3d15ed45ec59035926bd2db8b7f2d020
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-engine[ovirt-engine-3.4]: engine: Use VmDevice.id to identify the vm device instance
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Use VmDevice.id to identify the vm device instance
......................................................................
engine: Use VmDevice.id to identify the vm device instance
The VmDevice.Id is sufficient to identify the existence of
the device within a map, rather using the entire device
which could be modified by other flows in the system (i.e.
update boot sequence).
Change-Id: Id0a976e31e97c1f250e29db9166e60ccba4b4a94
Bug-Url: https://bugzilla.redhat.com/1105842
Bug-Url: https://bugzilla.redhat.com/1136031
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
(cherry picked from commit 06e1857bf4b2a3f8c81c4399c5799e9beb6e67c7)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonVmMixIn.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
5 files changed, 9 insertions(+), 8 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/32275
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0a976e31e97c1f250e29db9166e60ccba4b4a94
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: net_config: use vdscli and setupNetworks
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: net_config: use vdscli and setupNetworks
......................................................................
net_config: use vdscli and setupNetworks
This patch replaces the usage of the vdsm command line interface
with the python vdsm.vdscli and, in the process, switches from
the non-rolling-back (and deprecated) addNetwork API verb to
th rolling-back setupNetworks.
Change-Id: Ic1923870adcb81f4e6bb5c6c1cc819d2e6e49aa2
Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com>
(cherry picked from commit 25962a34d1bf9251cbef2c49199c3e029f722f8f)
---
M src/plugins/ovirt-hosted-engine-setup/network/bridge.py
1 file changed, 59 insertions(+), 86 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32297
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1923870adcb81f4e6bb5c6c1cc819d2e6e49aa2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 7 months
Change in ovirt-hosted-engine-setup[master]: net_config: use vdscli and setupNetworks
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: net_config: use vdscli and setupNetworks
......................................................................
net_config: use vdscli and setupNetworks
This patch replaces the usage of the vdsm command line interface
with the python vdsm.vdscli and, in the process, switches from
the non-rolling-back (and deprecated) addNetwork API verb to
th rolling-back setupNetworks.
Change-Id: Ic1923870adcb81f4e6bb5c6c1cc819d2e6e49aa2
Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/network/bridge.py
1 file changed, 59 insertions(+), 86 deletions(-)
Approvals:
Martin Pavlik: Verified
Sandro Bonazzola: Looks good to me, approved
Antoni Segura Puimedon: Verified
--
To view, visit http://gerrit.ovirt.org/28595
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1923870adcb81f4e6bb5c6c1cc819d2e6e49aa2
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Martin Pavlik <xpavli44(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 7 months