Change in ovirt-engine[ovirt-engine-3.5]: setup: Changing task cleaner utility to also handle removal ...
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: setup: Changing task cleaner utility to also handle removal of commands
......................................................................
setup: Changing task cleaner utility to also handle removal of commands
The task cleaner utility now has the ability to present all commands
or commands with running tasks, and to erase commands (or commands with
running tasks)
Bug-Url: https://bugzilla.redhat.com/1161012
Change-Id: I753c6343496ffe7c70c0c66ed8ab3facbcb533e8
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M packaging/setup/dbutils/taskcleaner.sh
M packaging/setup/dbutils/taskcleaner_sp.sql
2 files changed, 157 insertions(+), 18 deletions(-)
Approvals:
Yair Zaslavsky: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36880
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I753c6343496ffe7c70c0c66ed8ab3facbcb533e8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: common: Change GetConfiguration query not to refresh session
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: common: Change GetConfiguration query not to refresh session
......................................................................
common: Change GetConfiguration query not to refresh session
Bug-Url: https://bugzilla.redhat.com/1168842
Change-Id: I9ec8cb46e3fba206d9e1a93df9f985d5c2477fa8
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetConfigurationValueParameters.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36823
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ec8cb46e3fba206d9e1a93df9f985d5c2477fa8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: webadmin: Configurable Default for Wipe After Delete per Sto...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Configurable Default for Wipe After Delete per Storage Domain
......................................................................
webadmin: Configurable Default for Wipe After Delete per Storage Domain
This patch adds the ability to configure a default value for wipe after
delete (WAD) per storage domain via the UI. This way, each new disk will
get the default value for WAD from its storage domain.
Note that SANWipeAfterDelete will no longer be the WAD default value for
disks, but for storage domains.
Change-Id: Id0bf6a95eb4b33867de86e99f8cb59eec0d1cdd4
Bug-Url: https://bugzilla.redhat.com/1073448
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetStorageDomainDefaultWipeAfterDeleteQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetStorageDomainDefaultWipeAfterDeleteQueryTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStorageDomainDefaultWipeAfterDeleteParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/ImportFcpStorageView.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/ImportIscsiStorageView.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml
13 files changed, 183 insertions(+), 10 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit http://gerrit.ovirt.org/36526
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0bf6a95eb4b33867de86e99f8cb59eec0d1cdd4
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: build: support quotes in BUILD_JAVA_OPTS_MAVEN
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: support quotes in BUILD_JAVA_OPTS_MAVEN
......................................................................
build: support quotes in BUILD_JAVA_OPTS_MAVEN
Change-Id: Ie3c795b7f57dca050ce880e172a5ff7ade86d060
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37020
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3c795b7f57dca050ce880e172a5ff7ade86d060
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Fix storage allocation check for LSM
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix storage allocation check for LSM
......................................................................
core: Fix storage allocation check for LSM
During LiveMigrateVmDisksCommand , a snapshot is taken on the source domain
before actual migration.
Validation should be for a new, empty AI (COW, SPARSE), but was done according
to the actual disk data, which is not necessarily the above.
Change-Id: I6417039be6c1e892b9d908f118a04f1a980e6702
Bug-Url: https://bugzilla.redhat.com/1099894
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/37039
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6417039be6c1e892b9d908f118a04f1a980e6702
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Fix storage allocation check when creating a VM snapshot
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix storage allocation check when creating a VM snapshot
......................................................................
core: Fix storage allocation check when creating a VM snapshot
Allocation checks for memory and data volumes were done either way -
whether the VM is running or not. This patch takes these volumes into
consideration only when the VM is running.
Change-Id: I085d49dc90053e375f829900c75d2fe72c263161
Bug-Url: https://bugzilla.redhat.com/1053752
Bug-Url: https://bugzilla.redhat.com/1119022
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java
4 files changed, 68 insertions(+), 37 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/37038
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I085d49dc90053e375f829900c75d2fe72c263161
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: userportal/webadmin: Remove tooltip from host tab under VM w...
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal/webadmin: Remove tooltip from host tab under VM window
......................................................................
userportal/webadmin: Remove tooltip from host tab under VM window
Tooltip was removed from "Start Running On" label as it was no longer true.
Change-Id: I20c00e560b0f6666f9dcc52e388a23266a102e45
Bug-Url: https://bugzilla.redhat.com/1124432
Signed-off-by: Eldan Shachar <eshachar(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
3 files changed, 0 insertions(+), 10 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Eldan Shachar: Verified
--
To view, visit http://gerrit.ovirt.org/32736
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20c00e560b0f6666f9dcc52e388a23266a102e45
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-iso-uploader[ovirt-iso-uploader-3.5]: storage: fix nfs uploading
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: storage: fix nfs uploading
......................................................................
storage: fix nfs uploading
Bug-Url: https://bugzilla.redhat.com/1183095
Change-Id: Ie443e260a2773b5cc68512a6c2247dd00e99f368
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit 24f679c0eb09f8d7545303fb6c0099424b7a73e3)
---
M src/__main__.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/37013
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie443e260a2773b5cc68512a6c2247dd00e99f368
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: ovirt-iso-uploader-3.5
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: frontend: display correct provider's certificate fingerprint
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: frontend: display correct provider's certificate fingerprint
......................................................................
frontend: display correct provider's certificate fingerprint
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1182756
Change-Id: I37d8801c57bc6090614a7d014f150b18b99119c4
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36975
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37d8801c57bc6090614a7d014f150b18b99119c4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: Fix storage allocation check when creating a VM snapshot
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix storage allocation check when creating a VM snapshot
......................................................................
core: Fix storage allocation check when creating a VM snapshot
Allocation checks for memory and data volumes were done either way -
whether the VM is running or not. This patch takes these volumes into
consideration only when the VM is running.
Change-Id: I085d49dc90053e375f829900c75d2fe72c263161
Bug-Url: https://bugzilla.redhat.com/1053752
Bug-Url: https://bugzilla.redhat.com/1119022
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java
4 files changed, 68 insertions(+), 37 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/36889
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I085d49dc90053e375f829900c75d2fe72c263161
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months