Change in ovirt-engine[master]: core: Set storagePoolId when fetching Existing Storage Domains.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Set storagePoolId when fetching Existing Storage Domains.
......................................................................
core: Set storagePoolId when fetching Existing Storage Domains.
Setting also the storage pool id to the Storage Domains, when fetched
from VDSM.
Change-Id: I86dda5cd86b296fcb79dc797cc952c93ed0991ef
Bug-Url: https://bugzilla.redhat.com/1138115
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetExistingStorageDomainListQuery.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/36449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I86dda5cd86b296fcb79dc797cc952c93ed0991ef
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: Add vdc query for import Block Storage Domain
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add vdc query for import Block Storage Domain
......................................................................
core: Add vdc query for import Block Storage Domain
Add vdc query for validating that the block Storage Domain is not
attached to another Data Center.
The validation is being done on the Storage Domain metadata which
contains the storage pool id.
The Query only fetches the storage domain info and does not perform
connect or disconnect, to prevent a scenario of disconnecting an exisitng
Storage Domains.
Change-Id: Id93a96ad7fdad3305f3f2254f67f476c1e989b6f
Bug-Url: https://bugzilla.redhat.com/1138115
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetBlockStorageDomainsWithAttachedStoragePoolGuidQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetBlockStorageDomainsWithAttachedStoragePoolGuidQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
3 files changed, 211 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/36478
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id93a96ad7fdad3305f3f2254f67f476c1e989b6f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: Add vdc query for import File Storage Domain
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add vdc query for import File Storage Domain
......................................................................
core: Add vdc query for import File Storage Domain
Add vdc query for validating that the file Storage Domain is not
attached
to another Data Center.
The validation is being done on the Storage Domain metadata which
contains the storage pool id.
The Query only fetches the storage domain info and does not perform
connect or disconnect, to prevent a scenario of disconnecting exisitng
Storage Domains.
Change-Id: I63a90b86b8427bd6128becccf83be7204637e611
Bug-Url: https://bugzilla.redhat.com/1138115
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetFileStorageDomainsWithAttachedStoragePoolGuidQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetFileStorageDomainsWithAttachedStoragePoolGuidQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
3 files changed, 326 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/36448
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63a90b86b8427bd6128becccf83be7204637e611
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: Add vdc query for attached Storage Domain
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add vdc query for attached Storage Domain
......................................................................
core: Add vdc query for attached Storage Domain
Add vdc query for validating that the Storage Domain is not attached to
another Data Center.
The validation is being done on the Storage Domain metadata which
contains the storage pool id.
The query uses connect and disconnect operations for the Storage Domain
to fetch the storage domain info.
Change-Id: I749cad223d90dcc8d193765ed842d7e062ad566c
Bug-Url: https://bugzilla.redhat.com/1138115
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsWithAttachedStoragePoolGuidQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsWithAttachedStoragePoolGuidQueryTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StorageDomainsAndStoragePoolIdQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
4 files changed, 503 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/36447
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I749cad223d90dcc8d193765ed842d7e062ad566c
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: Add a CDA on attach to an uninitialized Data Center
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add a CDA on attach to an uninitialized Data Center
......................................................................
core: Add a CDA on attach to an uninitialized Data Center
Adding a validation message when trying to attach a Storage Domain which
already have a storage pool id initiliazed in its meta data.
Storage Domain which have storage pool id already initialized in its
meta data (For example after disaster), needs to be detached first and
then to be attached to the relevant Data Center, since the detach
operation is an SPM operation, an un-initialized Data Center can't
perform this operation since it does not have an SPM yet.
Change-Id: I13ec66cc7ff4773221cc994cb4f0be1886ed9a6b
Bug-Url: https://bugzilla.redhat.com/1138126
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 44 insertions(+), 5 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/36454
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13ec66cc7ff4773221cc994cb4f0be1886ed9a6b
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: change storage_domain_static update policy
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: change storage_domain_static update policy
......................................................................
core: change storage_domain_static update policy
The storage domain's name can only be changed if the storage domain is
Active. Comment and description have the same policy, though this
shouldn't be so. Comment and Description are only a DB change, and
should be allowed unless the storage domain is locked.
Change-Id: I2dfa97b1dbe047d98f9f1e7f7ec2d53ae5c8a16b
Bug-Url: https://bugzilla.redhat.com/1174108
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommandTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
4 files changed, 50 insertions(+), 30 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36151
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2dfa97b1dbe047d98f9f1e7f7ec2d53ae5c8a16b
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: webadmin: fix typos in HelpTag file
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: fix typos in HelpTag file
......................................................................
webadmin: fix typos in HelpTag file
Change-Id: I7c56b35410704d2a99c2b1533637a41167ec9bfd
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Dudi Maroshi: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36513
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c56b35410704d2a99c2b1533637a41167ec9bfd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-engine[master]: webadmin: fix typo in audit messages
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: fix typo in audit messages
......................................................................
webadmin: fix typo in audit messages
Description of problem:
There is a typographic error in the messages which prints/logs
'Clsuter' instead of 'Cluster'. multiple paragraphs if necessary.
Diagnotics and cause:
Gui team renamed 'Cluster Policy' to 'Scheduling Policy'.
Due to typo error in log messages, skipped the rename in log reports.
Solution:
Rename 'Clsuter Policy' with 'Scheduling Policy' in
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Change-Id: Ia6dea56c9b63548bcc095aa253f463e2cc646ece
Bug-Url: https://bugzilla.redhat.com/1159181
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Dudi Maroshi: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36457
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6dea56c9b63548bcc095aa253f463e2cc646ece
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: core: add engine support for VDSM 4.16
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: add engine support for VDSM 4.16
......................................................................
core: add engine support for VDSM 4.16
This patch adds support for VDSM 4.16 in engine configuration
settings.
Change-Id: I5ee2e6e550bedb698bbc1cbd22e6f4af41b47471
Bug-Url: https://bugzilla.redhat.com/1177997
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ee2e6e550bedb698bbc1cbd22e6f4af41b47471
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
10 years, 3 months
Change in ovirt-engine[master]: core: add engine support for VDSM 4.16
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: add engine support for VDSM 4.16
......................................................................
core: add engine support for VDSM 4.16
This patch adds support for VDSM 4.16 in engine configuration
settings.
Change-Id: I5ee2e6e550bedb698bbc1cbd22e6f4af41b47471
Bug-Url: https://bugzilla.redhat.com/1177997
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36511
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ee2e6e550bedb698bbc1cbd22e6f4af41b47471
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months