Change in ovirt-engine[ovirt-engine-3.5]: core: Add vdc query for import Block Storage Domain
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add vdc query for import Block Storage Domain
......................................................................
core: Add vdc query for import Block Storage Domain
Add vdc query for validating that the block Storage Domain is not
attached to another Data Center.
The validation is being done on the Storage Domain metadata which
contains the storage pool id.
The Query only fetches the storage domain info and does not perform
connect or disconnect, to prevent a scenario of disconnecting an exisitng
Storage Domains.
Change-Id: Id93a96ad7fdad3305f3f2254f67f476c1e989b6f
Bug-Url: https://bugzilla.redhat.com/1176552
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetBlockStorageDomainsWithAttachedStoragePoolGuidQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetBlockStorageDomainsWithAttachedStoragePoolGuidQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
3 files changed, 211 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/36542
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id93a96ad7fdad3305f3f2254f67f476c1e989b6f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Add vdc query for import File Storage Domain
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add vdc query for import File Storage Domain
......................................................................
core: Add vdc query for import File Storage Domain
Add vdc query for validating that the file Storage Domain is not
attached
to another Data Center.
The validation is being done on the Storage Domain metadata which
contains the storage pool id.
The Query only fetches the storage domain info and does not perform
connect or disconnect, to prevent a scenario of disconnecting exisitng
Storage Domains.
Change-Id: I63a90b86b8427bd6128becccf83be7204637e611
Bug-Url: https://bugzilla.redhat.com/1176552
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetFileStorageDomainsWithAttachedStoragePoolGuidQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetFileStorageDomainsWithAttachedStoragePoolGuidQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
3 files changed, 326 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/36541
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63a90b86b8427bd6128becccf83be7204637e611
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Add vdc query for attached Storage Domain
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add vdc query for attached Storage Domain
......................................................................
core: Add vdc query for attached Storage Domain
Add vdc query for validating that the Storage Domain is not attached to
another Data Center.
The validation is being done on the Storage Domain metadata which
contains the storage pool id.
The query uses connect and disconnect operations for the Storage Domain
to fetch the storage domain info.
Change-Id: I749cad223d90dcc8d193765ed842d7e062ad566c
Bug-Url: https://bugzilla.redhat.com/1176552
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsWithAttachedStoragePoolGuidQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsWithAttachedStoragePoolGuidQueryTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StorageDomainsAndStoragePoolIdQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
4 files changed, 503 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/36540
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I749cad223d90dcc8d193765ed842d7e062ad566c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: move existing hibernation volumes to active snapshots
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: move existing hibernation volumes to active snapshots
......................................................................
core: move existing hibernation volumes to active snapshots
Move hibernation volumes representations of existing suspended VMs to
their active snapshots. This patch also removes the
hibernation_vol_handle from vm_dynamic which is no longer used after
that change.
Change-Id: If3ac558e2748b02939c0f74f95b60a9960363dd3
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_06_0700_move_hibernation_volumes_to_active_snapshots.sql
M packaging/dbscripts/vms_sp.sql
7 files changed, 16 insertions(+), 34 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/36523
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3ac558e2748b02939c0f74f95b60a9960363dd3
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: store hibernation volumes in active snapshots
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: store hibernation volumes in active snapshots
......................................................................
core: store hibernation volumes in active snapshots
Change hibernate command to save the memory volumes representation in
the active snapshot instead of in vm_dynamic, and all references to the
hibernation volumes in vm_dynamic are changed accordingly.
That way hibernation volumes are stored as memory which is part of
snapshot is stored and that will help us convert all the memory images
to disks.
Change-Id: I30890eb1a75132aa4f67f754c357edc847819908
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmHibernationVolumesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoDbFacadeImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java
M packaging/dbscripts/snapshots_sp.sql
9 files changed, 56 insertions(+), 31 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/36522
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30890eb1a75132aa4f67f754c357edc847819908
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Block import of storage domain if the storage contains...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Block import of storage domain if the storage contains hosted engine
......................................................................
core: Block import of storage domain if the storage contains hosted engine
Block an import of a storage domain that contains the hosted engine by the
storage name defined in the configuration value named
HOSTED_ENGINE_STORAGE_DOMAIN_NAME
Change-Id: I36db8c4a7a1d13be8874407c56596ecd9ab74333
Bug-Url: https://bugzilla.redhat.com/1177247
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/StorageConstants.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 43 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36554
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36db8c4a7a1d13be8874407c56596ecd9ab74333
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: userportal/webadmin: fix missing fields in cloner
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: userportal/webadmin: fix missing fields in cloner
......................................................................
userportal/webadmin: fix missing fields in cloner
Added fields which were missing in the cloneVM part.
The 'edit template-version' feature bypass part of the saving process of
a running edited vm with a different template version(code now ignores
the model data in this scenario because it represents the new
template data which won't be relevant till shutdown). This causes the
saving process to be based solely on VmListModel::preSave() which uses this
cloner as it's only source of vm data.
Change-Id: Id475341c0cb97612927627b0bd5dfca070e19d22
Bug-Url: https://bugzilla.redhat.com/1140569
Signed-off-by: Eldan Shachar <eshachar(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36506
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id475341c0cb97612927627b0bd5dfca070e19d22
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: Block import of storage domain if the storage contains...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Block import of storage domain if the storage contains hosted engine
......................................................................
core: Block import of storage domain if the storage contains hosted engine
Block an import of a storage domain that contains the hosted engine by the
storage name defined in the configuration value named
HOSTED_ENGINE_STORAGE_DOMAIN_NAME
Change-Id: I36db8c4a7a1d13be8874407c56596ecd9ab74333
Bug-Url: https://bugzilla.redhat.com/1177247
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/StorageConstants.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
13 files changed, 79 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36549
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36db8c4a7a1d13be8874407c56596ecd9ab74333
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: webadmin: Modify network dialog layout for QoS
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Modify network dialog layout for QoS
......................................................................
webadmin: Modify network dialog layout for QoS
The addition of the QoS field was too much for the previous height, so
removed some space from the dialog. It doesn't look worse.
Change-Id: Ib0eec7fb2c950e58d7279d7f56c4a44d81e9395e
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml
1 file changed, 3 insertions(+), 7 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/36218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0eec7fb2c950e58d7279d7f56c4a44d81e9395e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: engine, webadmin: Minimize usage of "new VdsNetworkInterface()"
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: engine,webadmin: Minimize usage of "new VdsNetworkInterface()"
......................................................................
engine,webadmin: Minimize usage of "new VdsNetworkInterface()"
Tried to replace existing calls with calls to the more specific
subclasses. Remaining invocations (excluding test code) are an edge
case that can't be ruled out in InterfaceDaoDbFacadeImpl, and some
code that should be removed in the not-so-distant future in
HostSetupNetworksModel.
Change-Id: Ie00542f8af75fa3a0a7fde599f4260d7835005a0
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java
3 files changed, 8 insertions(+), 31 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36214
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie00542f8af75fa3a0a7fde599f4260d7835005a0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months