Change in ovirt-live[master]: centos: Rebase toolchain on 7.2
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: centos: Rebase toolchain on 7.2
......................................................................
centos: Rebase toolchain on 7.2
Change-Id: I6d2ee922c13dfdf9332d681aaebe5e5026e1c46b
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/Makefile
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50534
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d2ee922c13dfdf9332d681aaebe5e5026e1c46b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: ignore noVm error for internal destroy ops
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: ignore noVm error for internal destroy ops
......................................................................
core: ignore noVm error for internal destroy ops
In Icd93048d78 we changed the engine to ignore errors of type noVm
when they arrive from the destination host after cancel migration.
Actually this is a particular instance of a more general problem -
if we ask to destroy the VM and it is not there anymore, does it
really mean that the opreation fails?
Sure, for user-initiated operations it makes some sense to report
these errors so users will know that the operation they asked for
failed (and this is also debateable), but for internal operations
- it is not interesting for anyone to know about this "problem".
Therefore, setting ignoreNoVm to true for all destroy operations
that are done from the monitoring.
Change-Id: Ibc43d294804b0dd4070c0a08af6bba40652e1281
Bug-Url: https://bugzilla.redhat.com/1290361
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DestroyVDSCommand.java
2 files changed, 3 insertions(+), 10 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Marek Libra: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/50529
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc43d294804b0dd4070c0a08af6bba40652e1281
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: core: remove memory and conf volumes on VM removal
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: remove memory and conf volumes on VM removal
......................................................................
core: remove memory and conf volumes on VM removal
When removing a VM, there's no case where we would not like to remove
the memory and configuration volumes of the VM. Thus, RemoveVmCommand
should always remove them using RemoveMemoryVolumesCommand.
This patch adds a flag named "forceRemove" to
RemoveMemoryVolumesParameters.
Setting "forceRemove" to true creates a bypass in
MemoryImageRemoverOnDataDomain.isMemoryStateRemovable, such that for
every memoryVolume, isMemoryStateRemovable returns true and the volume
is eventually removed.
Passing forceRemove = true by RemoveVmCommand does the trick.
Change-Id: Ieed64de46eb23e5677988b13828e97a5f3a873a1
Bug-Url: https://bugzilla.redhat.com/1282789
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMemoryVolumesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveMemoryVolumesParameters.java
4 files changed, 23 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/50527
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieed64de46eb23e5677988b13828e97a5f3a873a1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: add template with Cinder disks - failure flow
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: add template with Cinder disks - failure flow
......................................................................
core: add template with Cinder disks - failure flow
* Integrated ConcurrentChildCommandsExecutionCallback on AddVmTemplateCommand.
* Removing JsonIgnore from JsonAddVmTemplateParametersMixIn
is still required as 'MasterVm' is being used on failure flow.
Change-Id: I130071a5aed7f65b0f7072aa86e03575f5d44c81
Bug-Url: https://bugzilla.redhat.com/1287771
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CloneCinderDisksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonAddVmTemplateParametersMixIn.java
6 files changed, 36 insertions(+), 20 deletions(-)
Approvals:
Daniel Erez: Verified
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49956
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I130071a5aed7f65b0f7072aa86e03575f5d44c81
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: frontend: removed incorrect localized messages
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: removed incorrect localized messages
......................................................................
frontend: removed incorrect localized messages
The num of parameters in the UIMessages changed so it needs to be removed also
from the property files.
Change-Id: I5cf9ef87ebdb0628f7d7a47d9326de2fc034d2ea
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_de_DE.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_es_ES.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_fr_FR.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_it_IT.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_ja_JP.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_ko_KR.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_pt_BR.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_zh_CN.properties
8 files changed, 0 insertions(+), 8 deletions(-)
Approvals:
Tomas Jelinek: Verified
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Marek Libra: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/50506
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5cf9ef87ebdb0628f7d7a47d9326de2fc034d2ea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: remove memory and conf volumes on VM removal
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: remove memory and conf volumes on VM removal
......................................................................
core: remove memory and conf volumes on VM removal
When removing a VM, there's no case where we would not like to remove
the memory and configuration volumes of the VM. Thus, RemoveVmCommand
should always remove them using RemoveMemoryVolumesCommand.
This patch adds a flag named "forceRemove" to
RemoveMemoryVolumesParameters.
Setting "forceRemove" to true creates a bypass in
MemoryImageRemoverOnDataDomain.isMemoryStateRemovable, such that for
every memoryVolume, isMemoryStateRemovable returns true and the volume
is eventually removed.
Passing forceRemove = true by RemoveVmCommand does the trick.
Change-Id: Ieed64de46eb23e5677988b13828e97a5f3a873a1
Bug-Url: https://bugzilla.redhat.com/1282789
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMemoryVolumesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveMemoryVolumesParameters.java
4 files changed, 23 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Idan Shaby: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50478
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieed64de46eb23e5677988b13828e97a5f3a873a1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3.1.z]: build: ovirt-hosted-engine-setup-1.3.1.3
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: ovirt-hosted-engine-setup-1.3.1.3
......................................................................
build: ovirt-hosted-engine-setup-1.3.1.3
Change-Id: Ic393eee1ae2a6f6c160e7d631f4c8ecd128d1b04
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-setup.spec.in
2 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50510
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic393eee1ae2a6f6c160e7d631f4c8ecd128d1b04
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.3.1.z
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3.1.z]: packaging: setup: fixing _storagePoolConnection on additiona...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: fixing _storagePoolConnection on additional hosts
......................................................................
packaging: setup: fixing _storagePoolConnection on additional hosts
Before 3.6.1 _storagePoolConnection was not required on additional
hosts since the hosted-engine storage domain wasn't connected
to any storage pool.
With 3.6.1 the engine is able to import the hosted-engine
storage domain and attach it to its datacenter storagePool.
So _storagePoolConnection is needed again on additional hosts
and unfortunately we have to fix it.
Change-Id: I44389c06c2d2611bcead7b250f2d9f262d2ffce8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1291234
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
(cherry picked from commit 25b97ca5b2682449995f395782475e2548fb3a04)
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50509
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44389c06c2d2611bcead7b250f2d9f262d2ffce8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.3.1.z
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
8 years, 11 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: setup: fixing _storagePoolConnection on additiona...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: fixing _storagePoolConnection on additional hosts
......................................................................
packaging: setup: fixing _storagePoolConnection on additional hosts
Before 3.6.1 _storagePoolConnection was not required on additional
hosts since the hosted-engine storage domain wasn't connected
to any storage pool.
With 3.6.1 the engine is able to import the hosted-engine
storage domain and attach it to its datacenter storagePool.
So _storagePoolConnection is needed again on additional hosts
and unfortunately we have to fix it.
Change-Id: I44389c06c2d2611bcead7b250f2d9f262d2ffce8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1291234
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/50417
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44389c06c2d2611bcead7b250f2d9f262d2ffce8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: fixing _storagePoolConnection on additiona...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: fixing _storagePoolConnection on additional hosts
......................................................................
packaging: setup: fixing _storagePoolConnection on additional hosts
Before 3.6.1 _storagePoolConnection was not required on additional
hosts since the hosted-engine storage domain wasn't connected
to any storage pool.
With 3.6.1 the engine is able to import the hosted-engine
storage domain and attach it to its datacenter storagePool.
So _storagePoolConnection is needed again on additional hosts
and unfortunately we have to fix it.
Change-Id: I44389c06c2d2611bcead7b250f2d9f262d2ffce8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1291234
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/50415
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44389c06c2d2611bcead7b250f2d9f262d2ffce8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months