Change in ovirt-engine[master]: core: DI for MAC Pools.
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: DI for MAC Pools.
......................................................................
core: DI for MAC Pools.
removed MacPoolPerDcSingleton singleton, replaced with @Singleton
annotation and let inject dependency where MacPoolPerDcSingleton was
formerly used.
Change-Id: I04cd600132251d7cc4931507e20b40b1fa8d7355
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddMacPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateMacPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolPerDc.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolPerDcSingleton.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolPerDcTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/SnapshotVmConfigurationHelperTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommandTest.java
16 files changed, 103 insertions(+), 59 deletions(-)
Approvals:
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/30505
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04cd600132251d7cc4931507e20b40b1fa8d7355
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core, vdsbroker: Refresh volume after extension during Live ...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core, vdsbroker: Refresh volume after extension during Live Merge
......................................................................
core, vdsbroker: Refresh volume after extension during Live Merge
When merging a larger (extended) volume into a smaller base volume, the
ExtendImageSize command may be run on a different host than the Merge
command. In this case the host running Merge may be unaware of the size
change, resulting in a failure.
To prevent this, ExtendImageSize will now send a RefreshVolume request
if a base volume is extended. The refresh is done on all hosts with the
volume in use because they otherwise have no way of knowing about the
new size.
In addition, we will send a refresh request during live merge recovery
to allow recovery from a failure due to the above size discrepancy when
a merge is retried.
Change-Id: I043c7f14359d1befb3e442958760d2a0dc4c9882
Bug-Url: https://bugzilla.redhat.com/1274323
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RefreshVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ExtendImageSizeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RefreshVolumeParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/RefreshVolumeVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/RefreshVolumeVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
15 files changed, 308 insertions(+), 33 deletions(-)
Approvals:
Greg Padgett: Verified
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, but someone else must approve
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47671
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I043c7f14359d1befb3e442958760d2a0dc4c9882
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: RsdlBuilder comparator
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RsdlBuilder comparator
......................................................................
core: RsdlBuilder comparator
Clean up the code by using Comparator's function references instead of
re-implementing this logic inline.
Change-Id: I9723dbf7c1d8ac0e6605c70517d361dee4d40677
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java
1 file changed, 2 insertions(+), 7 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50446
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9723dbf7c1d8ac0e6605c70517d361dee4d40677
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: ReorderVmNicsCommand NameableComparator
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ReorderVmNicsCommand NameableComparator
......................................................................
core: ReorderVmNicsCommand NameableComparator
Use NameableComparator instead of reimplementing it.
Change-Id: Ib44f8ba070ce830bb3256219d507da954a512eef
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ReorderVmNicsCommand.java
1 file changed, 2 insertions(+), 7 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/50444
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib44f8ba070ce830bb3256219d507da954a512eef
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: RemoveStoragePoolCommand comparator
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RemoveStoragePoolCommand comparator
......................................................................
core: RemoveStoragePoolCommand comparator
Clean up the code by using Comparator's function references instead of
re-implementing this logic inline.
Change-Id: Id99d41ca46b00f0f6e4b3b49d281f5dd738c431c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java
1 file changed, 2 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50439
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id99d41ca46b00f0f6e4b3b49d281f5dd738c431c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: ProcessOvfUpdateForStorageDomainCommand collections
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ProcessOvfUpdateForStorageDomainCommand collections
......................................................................
core: ProcessOvfUpdateForStorageDomainCommand collections
Use Collections.singletonList instead of Arrays.asList for single-item
arrays, as it has a slighter better performance (and saves another
import).
Change-Id: I01d04bf984f3e6b6ca1a4c291903e8ee7f91c6be
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStorageDomainCommand.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50437
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I01d04bf984f3e6b6ca1a4c291903e8ee7f91c6be
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: ProcessOvfUpdateForStorageDomainCommand generics
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ProcessOvfUpdateForStorageDomainCommand generics
......................................................................
core: ProcessOvfUpdateForStorageDomainCommand generics
Use generics instead of raw types, as per Java's best practices.
Change-Id: I46bfb219c9a3d60f22d5f04657f7b22e22906937
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStorageDomainCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50436
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46bfb219c9a3d60f22d5f04657f7b22e22906937
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: VdsBrokerObjectsBuilder#numaNodeComparator
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VdsBrokerObjectsBuilder#numaNodeComparator
......................................................................
core: VdsBrokerObjectsBuilder#numaNodeComparator
Clean up the code by using Comparator's function references instead of
re-implementing this logic inline.
As a side effect, this patch fixes a theoretical bug where the previous
comparator violates java's contract for two VdsNumaNodes with the same
index.
Change-Id: Ifc834c26915cc1e7c3a8b3c103acfe8e1d6bd698
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 1 insertion(+), 8 deletions(-)
Approvals:
Allon Mureinik: Verified; Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50448
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc834c26915cc1e7c3a8b3c103acfe8e1d6bd698
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: webadmin: Inconsistent use of placeholders in login form
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Inconsistent use of placeholders in login form
......................................................................
webadmin: Inconsistent use of placeholders in login form
In login form there is no place holder for
username.
Change-Id: I806f9855005c3263e874bf99244d9d655bb45dfb
Bug-Url: https://bugzilla.redhat.com/1286752
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ravi Nori: Verified
Alexander Wels: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50006
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I806f9855005c3263e874bf99244d9d655bb45dfb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: VmStatistics methods naming conventions
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VmStatistics methods naming conventions
......................................................................
core: VmStatistics methods naming conventions
Fixed naming conventions of the VmStatistics and VmStatisticsTest
classes' methods as per the recommended Java naming conventions.
Change-Id: Id9d28ef56fd492bdb4f0053936ca4f9fd079271d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/VmStatisticsTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStatisticsDaoTest.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/VmStatisticalQuery.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
10 files changed, 74 insertions(+), 74 deletions(-)
Approvals:
Allon Mureinik: Verified; Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49849
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9d28ef56fd492bdb4f0053936ca4f9fd079271d
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months