Change in ovirt-engine[master]: core: Spring asserts
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Spring asserts
......................................................................
core: Spring asserts
Removed usages of org.springframework.util.Assert.isTrue and replaced
with the standard org.junit.Assert.assertTure.
Change-Id: Ib470a90191e629642690026a86f2c59f2e15dfca
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50083
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib470a90191e629642690026a86f2c59f2e15dfca
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: adding 4.0 support
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: adding 4.0 support
......................................................................
core: adding 4.0 support
Adding support for 4.0
This patch needs review and ack from all relevant verticals
Change-Id: I9ef73bfd954bbcad8042d35112968f28bbbaed2d
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtil.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
M packaging/dbscripts/common_sp.sql
M packaging/dbscripts/data/00300_insert_storage_pool.sql
M packaging/dbscripts/data/00400_insert_vds_groups.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/setup/plugins/ovirt-engine-common/base/core/misc.py
10 files changed, 122 insertions(+), 33 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/48802
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ef73bfd954bbcad8042d35112968f28bbbaed2d
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5]: core: update cluster upgrade warning message
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: update cluster upgrade warning message
......................................................................
core: update cluster upgrade warning message
We want to make a message, which is displayed when there are still hosts
using unsupported protocol and we upgrade it to 3.6, more descriptive.
Change-Id: I55f5f0882a7be2cceed7f211a270f3f6d186eee1
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1289119
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50005
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I55f5f0882a7be2cceed7f211a270f3f6d186eee1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: pki: Do not fail if pkcs12 unreadable
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: setup: pki: Do not fail if pkcs12 unreadable
......................................................................
packaging: setup: pki: Do not fail if pkcs12 unreadable
During upgrade, we check several pkcs12 files to see if they expired or
are close to expire. Do not fail upgrade if we failed to read them. This
can happen e.g. if some of them were replaced with ones signed by a 3rd
party CA, changed their passphrase, etc.
Change-Id: Ibe88e38b073433a357ee7ac09f6ead159e22baa4
Bug-Url: https://bugzilla.redhat.com/1286607
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
1 file changed, 30 insertions(+), 7 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/49409
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe88e38b073433a357ee7ac09f6ead159e22baa4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6.1]: webadmin: improve robustness of import-VM dialog
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: improve robustness of import-VM dialog
......................................................................
webadmin: improve robustness of import-VM dialog
This patch fixes the import-VM dialog to handle errors properly
when either timeouts or other errors occur. The progress is
stopped and proper error message is displayed.
Change-Id: I1b41f61050ef0a73b8b4493c5e3aa962daa0dd3f
Bug-Url: https://bugzilla.redhat.com/1284412
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
2 files changed, 27 insertions(+), 16 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Tal Nisan: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/50074
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b41f61050ef0a73b8b4493c5e3aa962daa0dd3f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6.1]: webadmin: support vmware provider without data-center
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: support vmware provider without data-center
......................................................................
webadmin: support vmware provider without data-center
Fix NPE that was thrown when adding external provider of
type VMware with no data center defined.
This patch also fixes the import-VM dialog to support
import from external provider that is not defined for
a particular data center (but with 'any data center').
Change-Id: I32aef8081e4f52cf95348735a743f41c2cbfb1c6
Bug-Url: https://bugzilla.redhat.com/1284260
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Tal Nisan: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/50073
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32aef8081e4f52cf95348735a743f41c2cbfb1c6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6.1]: webadmin: support vmware provider without proxy
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: support vmware provider without proxy
......................................................................
webadmin: support vmware provider without proxy
Fix NPE that was thrown when adding external provider of
type VMware with no proxy host set.
Change-Id: I8357b4f23fb74cd83d1474f9e892cb5f31cb40e8
Bug-Url: https://bugzilla.redhat.com/1284260
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/VmwarePropertiesModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/50072
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8357b4f23fb74cd83d1474f9e892cb5f31cb40e8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: bll: Remove unnecessary overridden methods from storage classes
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: bll: Remove unnecessary overridden methods from storage classes
......................................................................
bll: Remove unnecessary overridden methods from storage classes
Remove unnecessary overridden CommandBase methods which didn't add
any logic and just called super method.
Change-Id: I66086ddd4c3447f41488ee32a5cc3007ceec4c40
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommand.java
5 files changed, 0 insertions(+), 47 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Martin Peřina: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/49646
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66086ddd4c3447f41488ee32a5cc3007ceec4c40
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6.1]: dbutils: Clean jobs when steps are cleaned
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: dbutils: Clean jobs when steps are cleaned
......................................................................
dbutils: Clean jobs when steps are cleaned
This patch insures that when the taskcleaner util deletes steps, the
corresponding jobs of those steps will be cleared as well.
Prior to this fix steps were cleared by taskcleaner while the related
job remains in STARTED status and actually without any steps.
This leads to Orphan jobs stuck in the system and not cleared forever.
Change-Id: I9c2f775a93208d667b11b4d32a93277f44d11776
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1283944
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/setup/dbutils/taskcleaner.sh
M packaging/setup/dbutils/taskcleaner_sp.sql
2 files changed, 13 insertions(+), 2 deletions(-)
Approvals:
Eli Mesika: Verified
Oved Ourfali: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49573
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c2f775a93208d667b11b4d32a93277f44d11776
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: dbutils: Clean jobs when steps are cleaned
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: dbutils: Clean jobs when steps are cleaned
......................................................................
dbutils: Clean jobs when steps are cleaned
This patch insures that when the taskcleaner util deletes steps, the
corresponding jobs of those steps will be cleared as well.
Prior to this fix steps were cleared by taskcleaner while the related
job remains in STARTED status and actually without any steps.
This leads to Orphan jobs stuck in the system and not cleared forever.
Change-Id: I9c2f775a93208d667b11b4d32a93277f44d11776
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1283944
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/setup/dbutils/taskcleaner.sh
M packaging/setup/dbutils/taskcleaner_sp.sql
2 files changed, 13 insertions(+), 2 deletions(-)
Approvals:
Eli Mesika: Verified
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49572
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c2f775a93208d667b11b4d32a93277f44d11776
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months