Change in ovirt-engine[master]: core: Mark MultipleActionCommands as internal when appropriate
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: Mark MultipleActionCommands as internal when appropriate
......................................................................
core: Mark MultipleActionCommands as internal when appropriate
During refactoring a line got lost which marks commands as internal.
Change-Id: I0580a2af8bf058d0d18587ebeef11c0fa06b4771
Bug-Url: https://bugzilla.redhat.com/1329979
Bug-Url: https://bugzilla.redhat.com/1142880
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/NestedCommandFactory.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Roman Mohr: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56569
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0580a2af8bf058d0d18587ebeef11c0fa06b4771
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: engein: fix false log message when putting host in maintenance
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engein: fix false log message when putting host in maintenance
......................................................................
engein: fix false log message when putting host in maintenance
Now handling case when the host was taken down to maintenance
without a reason given by the admin.
Added an audit log type to support this usecase.
Change-Id: Ibeb94f6d7a3bbeed894e5bc817ee6ec946d53750
Bug-Url: https://bugzilla.redhat.com/1301031
Signed-off-by: Boris Od <bodnopoz(a)redhat.com>
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 19 insertions(+), 2 deletions(-)
Approvals:
Boris Odnopozov: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/56554
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibeb94f6d7a3bbeed894e5bc817ee6ec946d53750
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Boris Odnopozov <bodnopoz(a)redhat.com>
Gerrit-Reviewer: Boris Odnopozov <bodnopoz(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine-sdk-ruby[master]: Revoke access token at the end of session
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Revoke access token at the end of session
......................................................................
Revoke access token at the end of session
The SSO acess token needs to be revoked to
terminate the session on SSO and clean up
the engine session.
Change-Id: Iaa67d845783cd1e6c1fce57907702c80e76e3ff4
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M sdk/lib/ovirtsdk4/http.rb
M sdk/spec/spec_helper.rb
2 files changed, 94 insertions(+), 36 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55030
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa67d845783cd1e6c1fce57907702c80e76e3ff4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: webadmin: Spice Plugin deprecated in 4.0
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Spice Plugin deprecated in 4.0
......................................................................
webadmin: Spice Plugin deprecated in 4.0
Support of Spice Plugin is removed from UI.
The engine-setup updates vdc_options.ClientModeSpiceDefault
to 'Native' if 'Plugin' is set.
Spice Plugin related code will be removed in 4.1, including this workaround.
** Workaround for potential issues in production:
To reenable the Spice Plugin in the UI, set
vdc_options.EnableDeprecatedClientModeSpicePlugin to 'true'.
The EnableDeprecatedClientModeSpicePlugin is not listed
by the engine-config.
Please note, this new vdc_option is deprecated and will be
removed in 4.1.
Change-Id: Ib4c7e303da3741a5d2ae65febd0e6dfcc1b05b23
Bug-Url: https://bugzilla.redhat.com/1316560
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseUiCommonModule.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpicePlugin.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
16 files changed, 69 insertions(+), 26 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Marek Libra: Verified
--
To view, visit https://gerrit.ovirt.org/55811
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4c7e303da3741a5d2ae65febd0e6dfcc1b05b23
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in jenkins[master]: lago:Updated ssh credentials to new jenkins
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: lago:Updated ssh credentials to new jenkins
......................................................................
lago:Updated ssh credentials to new jenkins
Change-Id: I6b5e9623a8bd49a20e3f784a61a148efb9dd96c4
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/yaml/templates/standard-stage.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Nadav Goldin: Looks good to me
Eyal Edri: Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
David Caro: Verified; Ready for review
--
To view, visit https://gerrit.ovirt.org/55682
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b5e9623a8bd49a20e3f784a61a148efb9dd96c4
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: early return in VmAnalyzer#updateRepository
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: early return in VmAnalyzer#updateRepository
......................................................................
core: early return in VmAnalyzer#updateRepository
VmAnalyzer#updateRepository does nothing when the VM is in the last
phase of the migration (migrating-to). This patch changes the 'if'
case at its beginning to simply return and by that to reduce the
number of nested levels in that method.
Change-Id: I3efe0760c77177d4806c9c8bd9266a1550f2b08c
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 66 insertions(+), 64 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/56529
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3efe0760c77177d4806c9c8bd9266a1550f2b08c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: better logs for transition of vm to down
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: better logs for transition of vm to down
......................................................................
core: better logs for transition of vm to down
The ordinary transition logs were not applied for the case where
a VM goes to Down state. This patch adds 2 log messages for that.
Change-Id: I9867e2148f0cb2f8b2648811f0e8df31f89e474f
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/56528
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9867e2148f0cb2f8b2648811f0e8df31f89e474f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: better handling of migrating vm crush
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: better handling of migrating vm crush
......................................................................
core: better handling of migrating vm crush
Restructure the part that handles MIGRATING_FROM to DOWN in
proceedDownVm to switch-cast statement to simplify it.
Rename proceedVmBeforeDeletion to abortVmMigration since it
better describes its work and set moveToDown to true inside
this method - by that, the call to clearVm that was done
afterwards is unneeded anymore.
Change-Id: I3cc1333742d7ef0058fc754ea725d55064156484
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 22 insertions(+), 26 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/56256
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3cc1333742d7ef0058fc754ea725d55064156484
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: short cycle for monitoring down vm
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: short cycle for monitoring down vm
......................................................................
core: short cycle for monitoring down vm
Now that all the required handling is in proceedDownVm method
(in VmAnalyzer), we can stop the analysis of Down VM right
after this method.
Change-Id: I490d1ef40a19d8c3cf8ac4be278534fa91fc097f
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerTest.java
2 files changed, 16 insertions(+), 7 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/55785
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I490d1ef40a19d8c3cf8ac4be278534fa91fc097f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: Removed AddVmAndAttachToPoolCommand
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Removed AddVmAndAttachToPoolCommand
......................................................................
core: Removed AddVmAndAttachToPoolCommand
Merged AddVmAndAttachToPoolCommand into AddVmCommand.
Change-Id: I0f7e85f646eee1db142eae58234108fb54cf2cb5
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmAndAttachToPoolParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
8 files changed, 80 insertions(+), 230 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/56412
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f7e85f646eee1db142eae58234108fb54cf2cb5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months