Change in ovirt-engine[master]: restapi: Fix tests that use ParametersHelper
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Fix tests that use ParametersHelper
......................................................................
restapi: Fix tests that use ParametersHelper
Commit 39cf33a introduced a failure in the tests that use directly or
indirectly the ParametersHelper class, this patch fixes those failures
adding the required expectations.
Change-Id: Ic580ed297f1c434e338de6be3625b341489f6fa4
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/util/QueryHelperTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTagsResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmCdromResourceTest.java
4 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/56463
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic580ed297f1c434e338de6be3625b341489f6fa4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-dwh[master]: packaging: Added release notes
by Shirly Radco
Shirly Radco has submitted this change and it was merged.
Change subject: packaging: Added release notes
......................................................................
packaging: Added release notes
Change-Id: I6492e0c3b3e6868acd1541866963dd35c8ed1e18
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M ovirt-engine-dwh.spec.in
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56471
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6492e0c3b3e6868acd1541866963dd35c8ed1e18
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-dwh[master]: packaging: spec: Require java 8
by Shirly Radco
Shirly Radco has submitted this change and it was merged.
Change subject: packaging: spec: Require java 8
......................................................................
packaging: spec: Require java 8
Needed for talend open studio 6.1.1 .
Bug-Url: https://bugzilla.redhat.com/1302611
Change-Id: I74df64637f0628c5db1d65e70466f2cdaf61b60e
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ovirt-engine-dwh.spec.in
1 file changed, 2 insertions(+), 11 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56445
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74df64637f0628c5db1d65e70466f2cdaf61b60e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: engine: Remove use of Future in RemoveSnapshot
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: engine: Remove use of Future in RemoveSnapshot
......................................................................
engine: Remove use of Future in RemoveSnapshot
Remove the use of Future in handleCinderSnapshotDisks method
of RemoveSnapshotCommand.
Change-Id: I9253fc4dfbb9c14fc332b6988bdd3ad8993ff43b
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java
1 file changed, 2 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Freddy Rolland: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/54535
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9253fc4dfbb9c14fc332b6988bdd3ad8993ff43b
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: Remove redundant return value in HotPlugDiskToVmComman...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Remove redundant return value in HotPlugDiskToVmCommandTest
......................................................................
core: Remove redundant return value in HotPlugDiskToVmCommandTest
The return value in the createNotVirtIODisk method is never used so it can
safely be removed, also to make it more aligned with the createVirtIODisk
method
Change-Id: Iada9ed6bed0398019d8dc785351649ab916d1962
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/56453
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iada9ed6bed0398019d8dc785351649ab916d1962
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: Move common duplicate code to a method in HotPlugDiskT...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Move common duplicate code to a method in HotPlugDiskToVmCommandTest
......................................................................
core: Move common duplicate code to a method in HotPlugDiskToVmCommandTest
Also changed the method name to reflect better what it does and changed
access modifier to private
Change-Id: I93ccb91cc9d2db9d10b16155c77de709680cc632
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java
1 file changed, 8 insertions(+), 11 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/56454
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93ccb91cc9d2db9d10b16155c77de709680cc632
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6]: core: Make disk list of VM editable on HE update
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Make disk list of VM editable on HE update
......................................................................
core: Make disk list of VM editable on HE update
Disks are never updated by the UpdateVmCommand but the editable field
checks are checking the value if it changed. The UI will not send the
disk list with the VM when it updates a VM but the REST API does.
Mark the diskList field as editable to make updating the Hosted Engine
always work.
Change-Id: I1ed00104d929b71de0ceb6d6cce9482946a8f5ab
Bug-Url: https://bugzilla.redhat.com/1326810
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/56351
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ed00104d929b71de0ceb6d6cce9482946a8f5ab
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fixed remove storage qos error popup
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fixed remove storage qos error popup
......................................................................
webadmin: Fixed remove storage qos error popup
When removing storage QoSes(Quality Of Services) which had disk profiles
attached to them, together with QoSes that didn't, the confirmation
dialog would show only the QoSes with the disk profiles.
The fix changed that and now the confirmation dialog is showing all of
the QoSes that are about to be removed.
Also, Style can be added to the list items in the "Remove Qos Model"
using html tagging.
Change-Id: I66d7bd71ed736d61c72deb885b8a37c35e95f030
Bug-Url: https://bugzilla.redhat.com/1142865
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/RemoveQosModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/RemoveStorageQosModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DataCenterModule.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/StorageQosRemovePopupPresenterWidget.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/StorageQosRemovePopupView.java
8 files changed, 132 insertions(+), 36 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Tomer Saban: Verified
--
To view, visit https://gerrit.ovirt.org/46328
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66d7bd71ed736d61c72deb885b8a37c35e95f030
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6]: core: Refactored ProfileParametersBase constructor
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Refactored ProfileParametersBase constructor
......................................................................
core: Refactored ProfileParametersBase constructor
ProfileParametersBase accepted both Profile and Id. Id can be retrieved
from profile.getId() instead of as an argument in the constructor.
This is bad practice and has potential for problems. So, now the
constructor only accepts a profile and the id is taken from the profile
itself.
Methods that were using the constructor were changed inorder to comply
with the new constructor arguments.
Change-Id: I0b9fa9ff81422fa5a9782e847892d79f2e5e7b74
Bug-Url: https://bugzilla.redhat.com/1143869
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CpuProfileParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DiskProfileParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ProfileParametersBase.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCpuProfileResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDiskProfileResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDiskProfilesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCpuProfileResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskProfileResource.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/CpuProfileBaseModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/DiskProfileBaseModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/RemoveCpuProfileModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/RemoveDiskProfileModel.java
14 files changed, 22 insertions(+), 26 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Daniel Erez: Looks good to me, but someone else must approve
Tomer Saban: Verified
Roy Golan: Looks good to me, approved
Phillip Bailey: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/55947
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b9fa9ff81422fa5a9782e847892d79f2e5e7b74
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6]: core: Added permissions on AddProfileBase
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Added permissions on AddProfileBase
......................................................................
core: Added permissions on AddProfileBase
When adding Disk/Cpu Profile there is always a need to add permissions
on the profile. For that reason, I added an abstract method
addPermissions() that will run each time add profile command is
executed. This method will be implemented by the add Disk/CPU profile
commands with the necessary permissions.
The developer may cancel the automatic call of addPermissions by giving
false in the constructor.
Also, Create/Update/Remove and 'Assign' permissions are given to the
user that created the profile and 'Assign' permissions to everyone else.
Also, this patch changes the way the CPU Profile is added when running
the 'AddClusterCommand'. Instead of adding the CPU Profile directly to
the Database which bypasses all the necessary validations, this patch
uses the 'AddCpuProfileCommand'.
Change-Id: I6f65daf1e46be9521e8541932ce84710175a6c66
Bug-Url: https://bugzilla.redhat.com/1143869
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddDiskProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddProfileCommandBase.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsGroupCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelperTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CpuProfileParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ProfileParametersBase.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCpuProfilesResource.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/CpuProfileBaseModel.java
12 files changed, 435 insertions(+), 37 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Tomer Saban: Verified
--
To view, visit https://gerrit.ovirt.org/55946
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f65daf1e46be9521e8541932ce84710175a6c66
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years