Change in ovirt-engine[ovirt-engine-3.6.7]: webadmin: Forbid cluster version change if a VM is active
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Forbid cluster version change if a VM is active
......................................................................
webadmin: Forbid cluster version change if a VM is active
Cluster version change is not allowed when there is
an active VM in the cluster.
All VMs have to be restarted to allow reconfiguration after cluster
version change.
Check is performed on:
- UI: ClusterModel.validate()
- UpdateVdsGroupCommand.validate()
Change-Id: I5784d357879b7aa0e49041c13e76f57812cfb1e1
Bug-Url: https://bugzilla.redhat.com/1336527
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/ClusterVersionChangeValidation.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 64 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Marek Libra: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58276
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5784d357879b7aa0e49041c13e76f57812cfb1e1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.7
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Add support for V3 SD delete with body
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Add support for V3 SD delete with body
......................................................................
restapi: Add support for V3 SD delete with body
Version 3 of the API supported the use of a body in the operation that
deletes a storage domain. This has been removed from version 4 of the
API, as bodies are in general forbidden for delete operations. But we
still need to support it for version 3 of the API, as that is how the
"format", "destroy" and "host" parameters are handled. This patch
modifies the backwards compatibility layer so that it accepts a body in
this case, and transforms the parameters into query parameters.
Change-Id: I37746b316f284854aab19674c0f9ab4d74cfbf9f
Bug-Url: https://bugzilla.redhat.com/1340164
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 940c42cd3195d77bfe8bd99598cc9091abd2d922)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3StorageDomainServer.java
1 file changed, 31 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58281
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37746b316f284854aab19674c0f9ab4d74cfbf9f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Fix remove of template watchdog
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Fix remove of template watchdog
......................................................................
restapi: Fix remove of template watchdog
Currently the operation to remove a template watchdog works like the one
that deletes a VM watchdog, which is incorrect. This patch fixes that
issue.
Change-Id: I7d70b6df5d9a6f557f7dce8718a27f60be19654f
Bug-Url: https://bugzilla.redhat.com/1338503
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 3502665ba9b8e7fb84cc2c945e6436bdd5a10b50)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateWatchdogResource.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58282
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d70b6df5d9a6f557f7dce8718a27f60be19654f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Generate correctly V3 network label links
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Generate correctly V3 network label links
......................................................................
restapi: Generate correctly V3 network label links
Currently the links for network labels for version 3 of the API aren't
generated correctly, they miss one slash between the identifier of the
host NIC and the "labels" word. This patch fixes that.
Change-Id: I1e5706f26b5c1f4c4b32da87808f5a574aac6971
Bug-Url: https://bugzilla.redhat.com/1338522
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 859cc891d7c8dede492f62f22a85425104d948ca)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3HostNicOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3NetworkOutAdapter.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58283
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e5706f26b5c1f4c4b32da87808f5a574aac6971
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-hosted-engine-setup[master]: Add --json to --vm-status
by stirabos＠redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: Add --json to --vm-status
......................................................................
Add --json to --vm-status
Add a --json option to vm-status, to make the output easily
consumable by other utilities which cannot use the HAClient python
API.
Update the manpages and help messages to reflect this.
Tweak vm_status.py a little bit so errors are also output as JSON
if they're encountered.
Change-Id: I57da55eb7fecaf4bb2c202a50ab33a41af39c2ce
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1324923
Signed-off-by: Ryan Barry <rbarry(a)redhat.com>
---
M man/hosted-engine.8
M src/bin/hosted-engine.in
M src/ovirt_hosted_engine_setup/vm_status.py
3 files changed, 42 insertions(+), 14 deletions(-)
Approvals:
Simone Tiraboschi: Looks good to me, approved
Jenkins CI: Passed CI tests
Ryan Barry: Verified
--
To view, visit https://gerrit.ovirt.org/56721
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57da55eb7fecaf4bb2c202a50ab33a41af39c2ce
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-host-deploy[master]: build: ovirt-host-deploy-1.5.0
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: ovirt-host-deploy-1.5.0
......................................................................
build: ovirt-host-deploy-1.5.0
Change-Id: I89944bf6f52425907834748ba2771dfd298fb318
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ChangeLog
M automation/build-artifacts.sh
M configure.ac
M ovirt-host-deploy.spec.in
M po/pt_BR.po
5 files changed, 26 insertions(+), 15 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58289
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I89944bf6f52425907834748ba2771dfd298fb318
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: restapi: Generate correctly V3 network label links
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Generate correctly V3 network label links
......................................................................
restapi: Generate correctly V3 network label links
Currently the links for network labels for version 3 of the API aren't
generated correctly, they miss one slash between the identifier of the
host NIC and the "labels" word. This patch fixes that.
Change-Id: I1e5706f26b5c1f4c4b32da87808f5a574aac6971
Bug-Url: https://bugzilla.redhat.com/1338522
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3HostNicOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3NetworkOutAdapter.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ori Liel: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58252
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e5706f26b5c1f4c4b32da87808f5a574aac6971
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: restapi: Fix remove of template watchdog
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Fix remove of template watchdog
......................................................................
restapi: Fix remove of template watchdog
Currently the operation to remove a template watchdog works like the one
that deletes a VM watchdog, which is incorrect. This patch fixes that
issue.
Change-Id: I7d70b6df5d9a6f557f7dce8718a27f60be19654f
Bug-Url: https://bugzilla.redhat.com/1338503
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateWatchdogResource.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ori Liel: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58251
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d70b6df5d9a6f557f7dce8718a27f60be19654f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: restapi: Add support for V3 SD delete with body
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Add support for V3 SD delete with body
......................................................................
restapi: Add support for V3 SD delete with body
Version 3 of the API supported the use of a body in the operation that
deletes a storage domain. This has been removed from version 4 of the
API, as bodies are in general forbidden for delete operations. But we
still need to support it for version 3 of the API, as that is how the
"format", "destroy" and "host" parameters are handled. This patch
modifies the backwards compatibility layer so that it accepts a body in
this case, and transforms the parameters into query parameters.
Change-Id: I37746b316f284854aab19674c0f9ab4d74cfbf9f
Bug-Url: https://bugzilla.redhat.com/1340164
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3StorageDomainServer.java
1 file changed, 31 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58270
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37746b316f284854aab19674c0f9ab4d74cfbf9f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6.7]: webadmin: Fix of Import VMs dialog
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix of Import VMs dialog
......................................................................
webadmin: Fix of Import VMs dialog
* Previously when there was no Data Center in state up, it was still
possible to press "Load" button which caused FE exception. This
patch binds enabled/disabled state of load button to enabled/disabled
state of Data Center drop down to prevent that.
* Load button to import VMs from external domain is now disabled when
there is not external domain. Previously it was enabled all the time
and clicking it without export domain caused frontend exception.
* Error and warning panel shows relevant info right after opening the
dialog. Previously there were no message after the dialog was opened
and messages were updated when "Source" dropbox was changed.
Change-Id: I168b4c24ae3c75d30366561d9ea61941c827eae6
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1336828
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/UiCommandButton.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/ImportVmsPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java
4 files changed, 93 insertions(+), 14 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58268
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I168b4c24ae3c75d30366561d9ea61941c827eae6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.7
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months