Change in ovirt-engine[master]: core: Make the download size of HE config disk configurable
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Make the download size of HE config disk configurable
......................................................................
core: Make the download size of HE config disk configurable
The size of the config disk to download is configurable and can be
changed depending underlying storage infra. Since the config tar doesn't
occupy the 'real' disk size that is reported we can safely download the
exact section that holds the tar image.
TODO the size of the tar should be parsed from the description, much
like it is used today for OVF disks. See
https://bugzilla.redhat.com/show_bug.cgi?id=1336655
Change-Id: I7541c8372b044370346e20127ebca434a9245781
Bug-Url: https://bugzilla.redhat.com/1167262
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineConfigFetcher.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineConfigFetcherTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
5 files changed, 20 insertions(+), 2 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Roy Golan: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58230
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7541c8372b044370346e20127ebca434a9245781
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: core: StorageServerConnectionCommandBase type inference
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: StorageServerConnectionCommandBase type inference
......................................................................
core: StorageServerConnectionCommandBase type inference
Change-Id: I6c39abee889d28275c59a19d87b316527b4fdc74
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageServerConnectionCommandBase.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/58237
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c39abee889d28275c59a19d87b316527b4fdc74
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: core: StorageServerConnectionBaseCommand collections
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: StorageServerConnectionBaseCommand collections
......................................................................
core: StorageServerConnectionBaseCommand collections
Use Collections#singletonList instead of Arrays#asList with a single
element for better performance.
Change-Id: Icbaf170344eee198da47cc983361cb07fe6e89b6
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageServerConnectionCommandBase.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/58238
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbaf170344eee198da47cc983361cb07fe6e89b6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: core: extracted method from VmInterfaceManager
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: extracted method from VmInterfaceManager
......................................................................
core: extracted method from VmInterfaceManager
This method does not belong into this class — it's more like dao
method (or service class method). Anyways refactoring it out
simplifies testing and upcoming code.
Change-Id: Ibb39744bb6e0649d6e1a7ae00a36e47f04aeabb8
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/common/predicates/NicIsPluggedPredicate.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/FindActiveVmsUsingNetwork.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/common/predicates/NicIsPluggedPredicateTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/FindActiveVmsUsingNetworkTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java
10 files changed, 201 insertions(+), 123 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53443
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb39744bb6e0649d6e1a7ae00a36e47f04aeabb8
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: core: Import graphics devices from externally managed VMs
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Import graphics devices from externally managed VMs
......................................................................
core: Import graphics devices from externally managed VMs
When importing the hosted engine VM or other external VMs we now import
the Graphics device (SPICE, VNC). Previously they were ignored because
they never get an address property.
Change-Id: I3a405df759b4c2fc624e79deb62aa39c5ac4d8e5
Bug-Url: https://bugzilla.redhat.com/1326810
Bug-Url: https://bugzilla.redhat.com/1328921
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommandTest.java
A backend/manager/modules/bll/src/test/resources/external_vm.json
A backend/manager/modules/bll/src/test/resources/he_vm.json
4 files changed, 685 insertions(+), 28 deletions(-)
Approvals:
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58063
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a405df759b4c2fc624e79deb62aa39c5ac4d8e5
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: core: MacPool per Cluster; update db so that cluster referen...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: MacPool per Cluster; update db so that cluster references pool
......................................................................
core: MacPool per Cluster; update db so that cluster references pool
• added new column to cluster table
• migrated data from StoragePool table — since each cluster has
exactly one datacenter, it's straighforward to move pool reference
from DC to cluster.
• updated adding / modifying / querying of cluster so that mac_pool_id
is added / modified / returned respectively.
• added query to get pool by cluster id.
Bug-Url: https://bugzilla.redhat.com/994283
Change-Id: Id01a33276e3227d7e8bb4b1c8eabbc3af1cafe07
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Cluster.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNicDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNicDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ClusterDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/clusters_sp.sql
M packaging/dbscripts/mac_pools_sp.sql
M packaging/dbscripts/network_sp.sql
A packaging/dbscripts/upgrade/04_00_0720_add_mac_pool_id_to_vds_group.sql
11 files changed, 134 insertions(+), 16 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50755
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id01a33276e3227d7e8bb4b1c8eabbc3af1cafe07
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: core: Fix template import flow
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix template import flow
......................................................................
core: Fix template import flow
Change-Id: I2882f30db2d19e2768e71e429a382259b7dd24bd
Bug-Url: https://bugzilla.redhat.com/1339686
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58248
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2882f30db2d19e2768e71e429a382259b7dd24bd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: core: fixed typo in migration policy name
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: fixed typo in migration policy name
......................................................................
core: fixed typo in migration policy name
replaced 'not may not' to 'may not'
Change-Id: Ib49e6e29548507bdc57cd2637f7a30b0a3e1b715
Bug-Url: https://bugzilla.redhat.com/1338843
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58033
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib49e6e29548507bdc57cd2637f7a30b0a3e1b715
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in gerrit-admin[master]: Adapted set_MODIFIED hook to check the branch-milestone
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Adapted set_MODIFIED hook to check the branch-milestone
......................................................................
Adapted set_MODIFIED hook to check the branch-milestone
Change-Id: I092e22a632aab93bda8c47b1f32df8166867d916
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M hooks/custom_hooks/change-merged.set_MODIFIED
M hooks/lib/gerrit.sh
M hooks/lib/tools.sh
3 files changed, 115 insertions(+), 20 deletions(-)
Approvals:
Eyal Edri: Looks good to me, approved
Jenkins CI: Passed CI tests
David Caro: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57981
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I092e22a632aab93bda8c47b1f32df8166867d916
Gerrit-PatchSet: 7
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: core: Fix build failure
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Fix build failure
......................................................................
core: Fix build failure
Fixes build failure in GWT part, which was caused by patch
I535bdfeba41b03c86520408e72abfa914fe3e1be.
Change-Id: Ibfceb8b1e27555bdcf249d927c0f0ff74963956d
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Martin Peřina: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58242
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfceb8b1e27555bdcf249d927c0f0ff74963956d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months