Change in otopi[otopi-1.4]: packaging: otopi-1.4.2
by didi＠redhat.com
Yedidyah Bar David has submitted this change and it was merged.
Change subject: packaging: otopi-1.4.2
......................................................................
packaging: otopi-1.4.2
Change-Id: I25aa2965344fd21012a3844dd41836555041f823
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ChangeLog
M configure.ac
M otopi.spec.in
3 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58014
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25aa2965344fd21012a3844dd41836555041f823
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: otopi-1.4
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in otopi[otopi-1.4]: core: log: Support filtering regular expressions
by didi＠redhat.com
Yedidyah Bar David has submitted this change and it was merged.
Change subject: core: log: Support filtering regular expressions
......................................................................
core: log: Support filtering regular expressions
Change-Id: If27a19f7725dd53fd4bf2e420bd17135a2102d67
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M src/otopi/constants.py
M src/plugins/otopi/core/log.py
2 files changed, 32 insertions(+), 3 deletions(-)
Approvals:
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58013
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If27a19f7725dd53fd4bf2e420bd17135a2102d67
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: otopi-1.4
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: Add memory when creating/restoring from snapshot
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: Add memory when creating/restoring from snapshot
......................................................................
core: Add memory when creating/restoring from snapshot
Include memory to a snapshot by default when creating it or restoring
from it. This default is used, in the first place, by REST API when
memory option is not set in the request.
Change-Id: I3ad11a2802564842938325a11e9dffb8c68d34d3
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1058661
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllSnapshotsFromVmParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TryBackToAllSnapshotsOfVmParameters.java
5 files changed, 8 insertions(+), 3 deletions(-)
Approvals:
Shmuel Leib Melamud: Verified
Liron Aravot: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57307
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ad11a2802564842938325a11e9dffb8c68d34d3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-hosted-engine-setup[master]: setup: ask host address on additional hosts
by stirabos＠redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: setup: ask host address on additional hosts
......................................................................
setup: ask host address on additional hosts
Use hostname.getHostname from ovirt_setup_lib
to ask and validate the host address on additional
host.
On the first host we already ask the management
interface to create the management bridge on
and so we can only take the address that uniquely
resolves there.
On additional hosts we simply rely on host-deploy
to create the management bridge on the interface
where the address supplied to hosts.add resolves on
and so it's worth to ask the user with a reasonable
default.
Change-Id: Ic5ce041e47fef02d60aa46159ff56f9e0622d5fc
Bug-Url: https://bugzilla.redhat.com/1251968
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/gr-he-setup/network/bridge.py
1 file changed, 21 insertions(+), 3 deletions(-)
Approvals:
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49310
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5ce041e47fef02d60aa46159ff56f9e0622d5fc
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: CommandBase - endAction() lock release
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: CommandBase - endAction() lock release
......................................................................
core: CommandBase - endAction() lock release
When ending command action the commands locks are freed on
endActionInTransactionScope() which is wrong because the
transaction should be committed before the lock is released.
additionally, currently there is a duplicate call which is unneeded.
Change-Id: Ia1405b6010cfebc5cdbe4ac8c87822ea6fc0fd72
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Moti Asayag: Looks good to me, approved
Liron Aravot: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57688
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1405b6010cfebc5cdbe4ac8c87822ea6fc0fd72
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: fixes in cluster migration tab
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: fixes in cluster migration tab
......................................................................
webadmin: fixes in cluster migration tab
- moved the migration related properties to "migration" tab
- added disabling the additional properties when a policy is selected
- fixed the showing of the description of the policy (needs to be inited only
after the view)
- removed redundant setting of the changability of the additional properties
(leftover after the version cleanup)
Change-Id: Ib2ad3871baf5eebcd973f6bcc9c235e4a877d9e8
Bug-Url: https://bugzilla.redhat.com/1339538
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
5 files changed, 39 insertions(+), 19 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Marek Libra: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/58032
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2ad3871baf5eebcd973f6bcc9c235e4a877d9e8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Create vm_templates_view without other entity types
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Create vm_templates_view without other entity types
......................................................................
core: Create vm_templates_view without other entity types
The search query used currently for Templates view looks over
vm_templates_view that contains several different entity types and then
filters templates out of the result that was returned from SQL query.
But this works badly with limited queries - the query that is limited
to return one page of results (for example, 100 items) may return less.
>From Frontend point of view, the page that is not full should be the
last one.
To fix this, a new view must be created containing only template
entities. The post-filtering will not be needed and the query will
always return a full page of results for all pages except the last one.
Change-Id: I244c9a22fd3d8bd9e0b3ac2ebea717740fc030d9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1338816
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/vm_templates_sp.sql
M packaging/dbscripts/vms_sp.sql
4 files changed, 71 insertions(+), 73 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57986
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I244c9a22fd3d8bd9e0b3ac2ebea717740fc030d9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: webadmin: Fix UIException when creating a VM from template
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix UIException when creating a VM from template
......................................................................
webadmin: Fix UIException when creating a VM from template
Change-Id: Ia1fe1db6521bf4e0e3fdf4a19df5c4c13826f9de
Bug-Url: https://bugzilla.redhat.com/1339566
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesModel.java
1 file changed, 5 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58031
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1fe1db6521bf4e0e3fdf4a19df5c4c13826f9de
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: build: post ovirt-engine-4.0 branching
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: build: post ovirt-engine-4.0 branching
......................................................................
build: post ovirt-engine-4.0 branching
Change-Id: I9d0a5593e54d780074005fffd2e3a359ce74eb9e
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M backend/manager/dependencies/common/pom.xml
M backend/manager/dependencies/pom.xml
M backend/manager/dependencies/tools/pom.xml
M backend/manager/extensions-tool/pom.xml
M backend/manager/modules/aaa/pom.xml
M backend/manager/modules/auth-plugin/pom.xml
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/branding/pom.xml
M backend/manager/modules/builtin-extensions/pom.xml
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
M backend/manager/modules/dal/pom.xml
M backend/manager/modules/docs/pom.xml
M backend/manager/modules/enginesso/pom.xml
M backend/manager/modules/extensions-manager/pom.xml
M backend/manager/modules/logger/pom.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
M backend/manager/modules/restapi/interface/common/pom.xml
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/interface/pom.xml
M backend/manager/modules/restapi/jaxrs/pom.xml
M backend/manager/modules/restapi/pom.xml
M backend/manager/modules/restapi/types/pom.xml
M backend/manager/modules/restapi/webapp/pom.xml
M backend/manager/modules/root/pom.xml
M backend/manager/modules/scheduler/pom.xml
M backend/manager/modules/searchbackend/pom.xml
M backend/manager/modules/services/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/uutils/pom.xml
M backend/manager/modules/vdsbroker/pom.xml
M backend/manager/modules/welcome/pom.xml
M backend/manager/pom.xml
M backend/manager/tools/pom.xml
M backend/pom.xml
M build-tools-root/checkstyles/pom.xml
M build-tools-root/ovirt-checkstyle-extension/pom.xml
M build-tools-root/ovirt-findbugs-filters/pom.xml
M build-tools-root/pom.xml
M build/validations/pom.xml
M ear/pom.xml
M frontend/pom.xml
M frontend/webadmin/modules/frontend-symbols/pom.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/uicommonweb/pom.xml
M frontend/webadmin/modules/uicompat/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M frontend/webadmin/pom.xml
M mavenmake/pom.xml
M ovirt-engine.spec.in
M pom.xml
56 files changed, 59 insertions(+), 56 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58023
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d0a5593e54d780074005fffd2e3a359ce74eb9e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: core: ChildCommandsCallbackBase - setSucceeded(false)
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: ChildCommandsCallbackBase - setSucceeded(false)
......................................................................
core: ChildCommandsCallbackBase - setSucceeded(false)
When the command entity is persisted, its return value is persisted as well.
If the command execute() succeeded, getReturnValue().getSucceeded() will return
true.
The command object is built from the persisted command entity, which means
that the return value will be initiated to the persisted return value, when calling
endAction() having the return value returning true value when checking
getSucceeded() might lead to wrong results.
This patch is simple and sets the succeeded flag to false to avoid that issue.
Change-Id: I39fd64001b0ef5354853aa3e6433d478f8dbb74a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1339536
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/58020
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I39fd64001b0ef5354853aa3e6433d478f8dbb74a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months