May 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Forbid cluster version change if a VM is active
by tjelinek＠redhat.com 26 May '16

26 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Forbid cluster version change if a VM is active ...................................................................... webadmin: Forbid cluster version change if a VM is active Cluster version change is not allowed when there is an active VM in the cluster. All VMs have to be restarted to allow reconfiguration after cluster version change. Check is performed on: - UI: ClusterModel.validate() - UpdateClusterCommand.validate() Change-Id: I5784d357879b7aa0e49041c13e76f57812cfb1e1 Bug-Url: https://bugzilla.redhat.com/1336527 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/ClusterVersionChangeValidation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 66 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5784d357879b7aa0e49041c13e76f57812cfb1e1 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: added kernelArgs storing to vds_dynamic
by tnisan＠redhat.com 26 May '16

26 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: added kernelArgs storing to vds_dynamic ...................................................................... core: added kernelArgs storing to vds_dynamic VDSM started to report kernelArgs in caps - this patch adds the engine-side support to store it in the DB. Change-Id: Ib5f8ea42342b78c857a924d51c4f42a6cacd49db Bug-Url: https://bugzilla.redhat.com/1339539 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_00_0710_add_kernel_args_to_vds_dynamic.sql M packaging/dbscripts/vds_sp.sql 10 files changed, 45 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5f8ea42342b78c857a924d51c4f42a6cacd49db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Set up bootable property accordingly in new VM popup
by tnisan＠redhat.com 26 May '16

26 May '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Set up bootable property accordingly in new VM popup ...................................................................... webadmin: Set up bootable property accordingly in new VM popup Change-Id: I37640274e1e1198f0fbaf92dbccae0265ccb4b3c Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1338510 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 7 files changed, 64 insertions(+), 33 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37640274e1e1198f0fbaf92dbccae0265ccb4b3c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.7]: core: Create vm_templates_view without other entity types
by tnisan＠redhat.com 26 May '16

26 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Create vm_templates_view without other entity types ...................................................................... core: Create vm_templates_view without other entity types The search query used currently for Templates view looks over vm_templates_view that contains several different entity types and then filters templates out of the result that was returned from SQL query. But this works badly with limited queries - the query that is limited to return one page of results (for example, 100 items) may return less. >From Frontend point of view, the page that is not full should be the last one. To fix this, a new view must be created containing only template entities. The post-filtering will not be needed and the query will always return a full page of results for all pages except the last one. Change-Id: I244c9a22fd3d8bd9e0b3ac2ebea717740fc030d9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1338816 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/vm_templates_sp.sql M packaging/dbscripts/vms_sp.sql 4 files changed, 71 insertions(+), 73 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I244c9a22fd3d8bd9e0b3ac2ebea717740fc030d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.7 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: aaa-ldap: Add 1.1 branch
by dcaro＠redhat.com 26 May '16

26 May '16

David Caro has submitted this change and it was merged. Change subject: aaa-ldap: Add 1.1 branch ...................................................................... aaa-ldap: Add 1.1 branch Adds ovirt-engine-extension-aaa-ldap-1.1 branch which will be used for 3.6.z updates. Change-Id: Ibf906bb0ad3223e576da8b5f6f6450da44ec7ba5 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-extension-aaa-ldap/ovirt-engine-extension-aaa-ldap_create-rpms.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Ready for review Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/58079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf906bb0ad3223e576da8b5f6f6450da44ec7ba5 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: build: otopi-1.5.0_rc1
by didi＠redhat.com 26 May '16

26 May '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: build: otopi-1.5.0_rc1 ...................................................................... build: otopi-1.5.0_rc1 Change-Id: I56bbddbdb54121eb0deea9c02c68f391146b78d6 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M configure.ac 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56bbddbdb54121eb0deea9c02c68f391146b78d6 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: 4.0: enable snapshot repos
by sbonazzo＠redhat.com 26 May '16

26 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: 4.0: enable snapshot repos ...................................................................... 4.0: enable snapshot repos Change-Id: Iaa19532a5216dd5d947a29a07ef642df6c6c4be2 --- M .gitignore M Makefile.am M automation/build-artifacts.sh M automation/check-patch.repos M automation/check-patch.sh M configure.ac A ovirt-pre.repo.in M ovirt-release40.spec.in M ovirt-snapshot.repo.in M ovirt.repo.in 10 files changed, 87 insertions(+), 19 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58024 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa19532a5216dd5d947a29a07ef642df6c6c4be2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: machine_dialog: provide some metadata for queryString
by didi＠redhat.com 26 May '16

26 May '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: machine_dialog: provide some metadata for queryString ...................................................................... machine_dialog: provide some metadata for queryString In machine dialog, provide default and valid values if available, and whether the answer should be hidden (e.g. a password), for queryString. Change-Id: I04e103bfb4dae77483291252cbb2213c0911e511 Bug-Url: https://bugzilla.redhat.com/1337445 Bug-Url: https://bugzilla.redhat.com/1336250 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M README.dialog M src/java/MachineDialogParser.java M src/plugins/otopi/dialog/constants.py M src/plugins/otopi/dialog/machine.py 4 files changed, 125 insertions(+), 28 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56955 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04e103bfb4dae77483291252cbb2213c0911e511 Gerrit-PatchSet: 16 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lukas Bednar <lbednar(a)redhat.com> Gerrit-Reviewer: Lukas Bednar <lukyn17(a)gmail.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: build: bump to 4.1 on master
by sbonazzo＠redhat.com 26 May '16

26 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: bump to 4.1 on master ...................................................................... build: bump to 4.1 on master Change-Id: I3dd14fe50d4b29bfa423aba8db7b6852358f8ec7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in M ovirt-engine-setup-plugin-live/configure.ac 3 files changed, 3 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58027 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3dd14fe50d4b29bfa423aba8db7b6852358f8ec7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-live: add 4.0 branch
by sbonazzo＠redhat.com 26 May '16

26 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-live: add 4.0 branch ...................................................................... ovirt-live: add 4.0 branch Change-Id: I97ef62a41c5bf6d7b43102084b7fff5a210217ef Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-live/ovirt-live_build-artifacts.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58026 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97ef62a41c5bf6d7b43102084b7fff5a210217ef Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0