Change in ovirt-engine[master]: core: fix edit-vm
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix edit-vm
......................................................................
core: fix edit-vm
Change I71725d3 broke update-VM flow.
The disks returned by DiskDao#getAllForVm don't include
the required VM-data for the validation of disabling
virtio-scsi.
This is a simple fix - to populate the required data when
querying the disks in VmValidator#canDisableVirtioScsi.
Change-Id: I83479c5bb7a7b4286fe1b1352cd1f01a649ec085
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java
1 file changed, 17 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/57860
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I83479c5bb7a7b4286fe1b1352cd1f01a649ec085
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-dwh[master]: history:remove collection of vm_disk_interface
by Shirly Radco
Shirly Radco has submitted this change and it was merged.
Change subject: history:remove collection of vm_disk_interface
......................................................................
history:remove collection of vm_disk_interface
Remove collection of vm_disk_interface from
vm_disk_configuration table.
It was moved in the engine db to disk_vm_element table.
Change-Id: Ie86d84c100fe1f41ec6f5bc14ae231085c65712b
Bug-Url: https://bugzilla.redhat.com/1338495
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M etl_export/src/main/java/ovirt_engine_dwh/configurationsync_4_0/ConfigurationSync.java
M packaging/dbscripts/create_views_3_6.sql
M packaging/dbscripts/create_views_4_0.sql
M tos_project/process/ConfigurationSync_4.0.item
M tos_project/process/ConfigurationSync_4.0.properties
5 files changed, 82 insertions(+), 270 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57864
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie86d84c100fe1f41ec6f5bc14ae231085c65712b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: fix leftovers of rename vds group to cluster
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: core: fix leftovers of rename vds group to cluster
......................................................................
core: fix leftovers of rename vds group to cluster
This patch fixes some leftovers related to the renaming of vds group to
cluster (commit 80c7d4d)
Change-Id: I65013a2925b597ba6e04e628361c70e625be2bc2
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Cluster.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ClusterDaoTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java
5 files changed, 73 insertions(+), 73 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57830
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65013a2925b597ba6e04e628361c70e625be2bc2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: Remove VdcCommandBase#executeWithReturnValue
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Remove VdcCommandBase#executeWithReturnValue
......................................................................
core: Remove VdcCommandBase#executeWithReturnValue
Removed the unused VdcCommandBase#executeWithReturnValue method.
Change-Id: I02d3a65306eba69cdf7a66c48759cd184fb7b66b
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcCommandBase.java
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57859
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02d3a65306eba69cdf7a66c48759cd184fb7b66b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: tools: Add AlertOnNumberOfLVs to engine-config
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: tools: Add AlertOnNumberOfLVs to engine-config
......................................................................
tools: Add AlertOnNumberOfLVs to engine-config
Add the ability to control this config value via engine-config.sh, as
different storage arrays in different users' environments may be less or
more susceptible to the slowness associated with a large number of LVs.
This patch does not introduce a limitation on the maximal value for this
config value (setting it to Integer.MAX_INT) as to not introduce any
behavior changes in upgraded systems where a user may have set it to
some arbitrary large value manually and would not be able to use the
tool to achieve the same behavior.
It does, however, impose a minimum value of 6. This is the number of
special LVs created when a block storage domain is created, and setting
the config value to anything lower than that would be pointless.
Change-Id: I302d99dc09ba8fce81e8b6ff6bd040bfc14fd8d0
Bug-Url: https://bugzilla.redhat.com/1338545
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M packaging/etc/engine-config/engine-config.properties
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/57852
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I302d99dc09ba8fce81e8b6ff6bd040bfc14fd8d0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: RunVm - do not pass compensation context
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: RunVm - do not pass compensation context
......................................................................
core: RunVm - do not pass compensation context
When running stateless vm, the RunVm command first creates a snapshot for the vm.
When running the create snapshot command, the command context is passed to the child
command - which means that the command compensation context is passed as well.
The compensation in use is NoOp compensation context it causes the
executed child command to use that compensation context as well, on case
of failure the db changes won't be reverted which will leave us with
inconsistent db state.
Change-Id: I93a6035b3a0691a0b1640444e49ef92b128d1122
Bug-Url: https://bugzilla.redhat.com/1334105
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, but someone else must approve
Arik Hadas: Looks good to me, approved
Liron Aravot: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57823
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93a6035b3a0691a0b1640444e49ef92b128d1122
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: RunVmCommand - always use callback when running stateless
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: RunVmCommand - always use callback when running stateless
......................................................................
core: RunVmCommand - always use callback when running stateless
CreateAllSnapshotsFromVmCommand was changed to use callback always
in patch I1d4f29657eb09a4b19ba930acaad1c6d84db0895, but the run vm
as stateless flow depends on the task when running stateless vm without
cinder disks.
This patch changes the run vm command to use callback always when running
stateless vm.
Change-Id: Icdb3ee7aa54a5f0631754478d9781dc899bf408e
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 4 insertions(+), 12 deletions(-)
Approvals:
Arik Hadas: Looks good to me, approved
Liron Aravot: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57826
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icdb3ee7aa54a5f0631754478d9781dc899bf408e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: engine: Set the vfsType glusterfs when importing HE domain
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: engine: Set the vfsType glusterfs when importing HE domain
......................................................................
engine: Set the vfsType glusterfs when importing HE domain
In HE flow, when importing a gluster domain we must set explicitly the
domain type otherwise the mount will fail.
This problem discovered when non HE hosts where connecting to that
domain. HE hosts have the right mount options in a configuration file
(they are connecting before there is an engine live)
Change-Id: Ic2383047d5033818ae2c2227e9fd6e756db10eaa
Bug-Url: https://bugzilla.redhat.com/1317699
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommand.java
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/56455
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2383047d5033818ae2c2227e9fd6e756db10eaa
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: Don't send existingConnAction in VM ticket
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Don't send existingConnAction in VM ticket
......................................................................
core: Don't send existingConnAction in VM ticket
We currently send existingConnAction parameter in each VM ticket, which
prevents the user from overriding this parameter (e.g. in Vdsm hooks).
This is not what we want. Additionally, sending the parameter is
unnecessary, so we should stop sending it. If we don't send the
parameter, libvirt/QEMU should behave in the same way as with
"disconnect" value, while we don't prevent the user from altering the
value in Vdsm hooks.
An even better solution would be to allow using different values for
existingConnAction ("disconnect" and "keep") in Engine and send them to
Vdsm in the creation path. However, this is a bit complicated on the
Vdsm side as using "keep" requires setting qemu-cmdline options in
domain XML, which is not what we want to do now. So we just implement
this workaround and let the user play with multiple SPICE screens using
means such as Vdsm hooks.
Change-Id: I800d31bc5a28b7cb896cbb11ea0441e07cfbf26e
Bug-Url: https://bugzilla.redhat.com/1060573
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVmTicketVDSCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java
3 files changed, 17 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit https://gerrit.ovirt.org/57660
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I800d31bc5a28b7cb896cbb11ea0441e07cfbf26e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: webadmin: PermissionListModel Disk checking
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: PermissionListModel Disk checking
......................................................................
webadmin: PermissionListModel Disk checking
Instead of a series of checks for every concrete subclass of Disk, it's
sufficient to check once for the base type.
Change-Id: I9825262b5811c584cbdb9bdb30504e87520c4b43
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/57839
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9825262b5811c584cbdb9bdb30504e87520c4b43
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months