May 2016 - Engine-commits - Ovirt List Archives

Change in jenkins[master]: Publish version 3.6 of the Java SDK to master

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: Publish version 3.6 of the Java SDK to master ...................................................................... Publish version 3.6 of the Java SDK to master Version 4 of the engine will need version 3 and version 4 of the Java SDKs. This patch changes the master publisher job so that it publishes version 3 of the Java SDK. Change-Id: I1724bcc217ac95c7f3cf02367ebdbd01be7f188c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Juan Hernandez: Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1724bcc217ac95c7f3cf02367ebdbd01be7f188c Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Fix of Import VMs dialog

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Fix of Import VMs dialog ...................................................................... webadmin: Fix of Import VMs dialog * Previously when there was no Data Center in state up, it was still possible to press "Load" button which caused FE exception. This patch binds enabled/disabled state of load button to enabled/disabled state of Data Center drop down to prevent that. * Load button to import VMs from external domain is now disabled when there is not external domain. Previously it was enabled all the time and clicking it without export domain caused frontend exception. * Error and warning panel shows relevant info right after opening the dialog. Previously there were no message after the dialog was opened and messages were updated when "Source" dropbox was changed. Change-Id: I168b4c24ae3c75d30366561d9ea61941c827eae6 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1336828 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/UiCommandButton.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/ImportVmsPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java 4 files changed, 109 insertions(+), 14 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57772 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I168b4c24ae3c75d30366561d9ea61941c827eae6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: update ovirt-host-deploy to 1.5.0-beta1

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: update ovirt-host-deploy to 1.5.0-beta1 ...................................................................... packaging: update ovirt-host-deploy to 1.5.0-beta1 Require newest ovirt-host-deploy in order to get new VdsDeployUnit setting two environment variables KernelEnv#CMDLINE_NEW and KernelEnv#CMDLINE_OLD to current and last applied kernel command line. Change-Id: I7d8b26300a01f082830aabac7e7afeb9cb53e28f Related-To: https://bugzilla.redhat.com/1301104 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57789 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d8b26300a01f082830aabac7e7afeb9cb53e28f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

Change in ovirt-host-deploy[master]: build: post ovirt-host-deploy-1.5.0_beta1

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-host-deploy-1.5.0_beta1 ...................................................................... build: post ovirt-host-deploy-1.5.0_beta1 Change-Id: Ib6ff7762655fd617dc734666e1d144c1b40b7b4c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57783 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6ff7762655fd617dc734666e1d144c1b40b7b4c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

Change in ovirt-host-deploy[master]: build: ovirt-host-deploy-1.5.0_beta1

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-host-deploy-1.5.0_beta1 ...................................................................... build: ovirt-host-deploy-1.5.0_beta1 Change-Id: I8cf11c2b54402c2d36f6b8b5d6b24d22085b4c9e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cf11c2b54402c2d36f6b8b5d6b24d22085b4c9e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: engine : SSO Conf file should reference ENGINE_FQDN

by mperina＠redhat.com

Martin Peřina has submitted this change and it was merged. Change subject: engine : SSO Conf file should reference ENGINE_FQDN ...................................................................... engine : SSO Conf file should reference ENGINE_FQDN The sso conf file should refernce the conf variable ENGINE_FQDN instead of the actual FQDN entered during setup. Change-Id: I6bc27cfb657956ef77547cf2ac4fb666e6d536cd Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/sso.py 1 file changed, 1 insertion(+), 10 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bc27cfb657956ef77547cf2ac4fb666e6d536cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

Change in ovirt-engine-sdk[master]: Update to model 4.0.19 and metamodel 1.0.13

by omachace＠redhat.com

Ondra Machacek has submitted this change and it was merged. Change subject: Update to model 4.0.19 and metamodel 1.0.13 ...................................................................... Update to model 4.0.19 and metamodel 1.0.13 The more relevant changes in this new version of the model are the following: * Added new `diskattachments` collection to virtual machines. * Renamed the `Label` type to `NetworkLabel`. The new version of the metamodel isn't really needed, as the changes only affect the Java code generators, but it is anyhow convenient to use the same version that the other SDKs and the engine. Change-Id: Id04cc14343770c136230042a1bb2484aa58a066d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id04cc14343770c136230042a1bb2484aa58a066d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

Change in ovirt-engine-sdk-java[master]: Update to model 4.0.19 and metamodel 1.0.13

by omachace＠redhat.com

Ondra Machacek has submitted this change and it was merged. Change subject: Update to model 4.0.19 and metamodel 1.0.13 ...................................................................... Update to model 4.0.19 and metamodel 1.0.13 The more relevant changes in this new version of the model are the following: * Added new `diskattachments` collection to virtual machines. * Renamed the `Label` type to `NetworkLabel`. The new version of the metamodel is needed in order to generate correctly the error messages produced when incorrect enum values are detected (currently it produces 'host-model', for example, when it should produce 'hotst_model'). Change-Id: Iccd2be2b88d7bce497a4c0b1745e955590105b61 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccd2be2b88d7bce497a4c0b1745e955590105b61 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: Use DiskMapper.map static method instead of constru...

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use DiskMapper.map static method instead of constructor ...................................................................... restapi: Use DiskMapper.map static method instead of constructor This is needed to avoid the following findbugs complaint: Return value of method without side effect is ignored This code calls a method and ignores the return value. However our analysis shows that the method (including its implementations in subclasses if any) does not produce any effect other than return value. Thus this call can be removed. We are trying to reduce the false positives as much as possible, but in some cases this warning might be wrong. Common false-positive cases include: - The method is designed to be overridden and produce a side effect in other projects which are out of the scope of the analysis. - The method is called to trigger the class loading which may have a side effect. - The method is called just to get some exception. If you feel that our assumption is incorrect, you can use a @CheckReturnValue annotation to instruct FindBugs that ignoring the return value of this method is acceptable. Bug kind and pattern: RV - RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT Change-Id: Iaa35254aa8030baef4a3b7b48afeb699993ac606 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskAttachmentsResource.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57778 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa35254aa8030baef4a3b7b48afeb699993ac606 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

Change in ovirt-engine-sdk-ruby[master]: Update to model 4.0.19 and metamodel 1.0.13

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: Update to model 4.0.19 and metamodel 1.0.13 ...................................................................... Update to model 4.0.19 and metamodel 1.0.13 The more relevant changes in this new version of the model are the following: * Added new `diskattachments` collection to virtual machines. * Renamed the `Label` type to `NetworkLabel`. The new version of the metamodel isn't really needed, as the changes only affect the Java code generators, but it is anyhow convenient to use the same version that the other SDKs and the engine. Change-Id: I482bec43d71d593cc21afefdd4d8413c4696db61 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I482bec43d71d593cc21afefdd4d8413c4696db61 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits May 2016