May 2016 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: Move loading of VMs from ctor to init in UpdateVmDiskC...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Move loading of VMs from ctor to init in UpdateVmDiskCommand ...................................................................... core: Move loading of VMs from ctor to init in UpdateVmDiskCommand The list of VMs the disk to be updated is plugged to was loaded in the constructor of the command since it was used by the getExclusiveLocks() method, having a DAO call in the constructor is considered bad practice due to that the DAO call was moved to the init() method which is invoked before getExclusiveLocks() thus not changing the original behavior Change-Id: I2c8795bccd649ea972ccd6b6fa27913366856041 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57219 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c8795bccd649ea972ccd6b6fa27913366856041 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Remove VmDiskOperationParameterBase instantiations w/o...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove VmDiskOperationParameterBase instantiations w/o DiskVmElement ...................................................................... core: Remove VmDiskOperationParameterBase instantiations w/o DiskVmElement The last constructor of VmDiskOperationParameterBase without DiskVmElement was removed Change-Id: I8b5b1dde7eb4319f18ece421edb75a448ea6fb23 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmDiskOperationParameterBase.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java 5 files changed, 11 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b5b1dde7eb4319f18ece421edb75a448ea6fb23 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: UI: v2v - add support for Kvm via Libvirt

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: UI: v2v - add support for Kvm via Libvirt ...................................................................... UI: v2v - add support for Kvm via Libvirt Support for importing and listing Kvm VMs in import VMs dialog Change-Id: Idab1cc70fe5b4363d170bb7d16df64fc69dcf496 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OriginType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportSource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalSourceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.ui.xml 9 files changed, 153 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idab1cc70fe5b4363d170bb7d16df64fc69dcf496 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: Engine: KVM v2v - no need to ask for ovf for KVM vms

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: Engine: KVM v2v - no need to ask for ovf for KVM vms ...................................................................... Engine: KVM v2v - no need to ask for ovf for KVM vms since virt-v2v is not working here there is no convert done. Change-Id: I7be9038e45135fbf173600e85e65f113dfc8d809 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ConvertVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 6 files changed, 77 insertions(+), 16 deletions(-) Approvals: Shahar Havivi: Verified; Passed CI tests Arik Hadas: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/56531 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7be9038e45135fbf173600e85e65f113dfc8d809 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: Engine: clear guest tools needed flag if the VM is up to date

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: Engine: clear guest tools needed flag if the VM is up to date ...................................................................... Engine: clear guest tools needed flag if the VM is up to date Change-Id: I1dad8c0757e9d87e35b09073a3ca38cbeca1bfd5 Bug-Url: https://bugzilla.redhat.com/1332101 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 15 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57189 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1dad8c0757e9d87e35b09073a3ca38cbeca1bfd5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix permissions for profiles created for new domain

by rgolan＠redhat.com

Roy Golan has submitted this change and it was merged. Change subject: core: Fix permissions for profiles created for new domain ...................................................................... core: Fix permissions for profiles created for new domain The AddDiskProfileCommand takes care of the permissions for newly added disk profiles and gives the users in Everyone group the DiskProfileUser role. AddStorageDomain command added the created disk profile directly to the DB without calling the command and so this role was not assigned. The fix was to call AddDiskProfileCommand directly from AddStorageDomain and also from AddStorageDomainToPoolCommand which creates a disk profile in case one doesn't exist for the storage domain. Change-Id: Ia6dd5483489b65285cbd5905865c07b9446f6459 Bug-Url: https://bugzilla.redhat.com/1209505 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DiskProfileParameters.java 4 files changed, 30 insertions(+), 25 deletions(-) Approvals: Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Phillip Bailey: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, but someone else must approve Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/56573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6dd5483489b65285cbd5905865c07b9446f6459 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin:add event msg for VM_MIGRATION_TO_SERVER_FAILED

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin:add event msg for VM_MIGRATION_TO_SERVER_FAILED ...................................................................... webadmin:add event msg for VM_MIGRATION_TO_SERVER_FAILED Add missing event message string for event VM_MIGRATION_TO_SERVER_FAILED , so that it will be displayed in UI properly. Change-Id: I13781b601c5551046fdb34695297490a1e054bda Bug-Url: https://bugzilla.redhat.com/1288089 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/57287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13781b601c5551046fdb34695297490a1e054bda Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

Change in ovirt-engine[sonar]: core: Build and analyze the project on travis

by rmohr＠redhat.com

Roman Mohr has submitted this change and it was merged. Change subject: core: Build and analyze the project on travis ...................................................................... core: Build and analyze the project on travis Do sonar code analysis on travis then uploads evertyhing to https://nemo.sonarqube.org/overview?id=org.ovirt.engine%3Aroot. Change-Id: I942f40c3d7597a6d417d5e44d1be4a0cb41e61ae Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- A .travis.yml 1 file changed, 15 insertions(+), 0 deletions(-) -- To view, visit https://gerrit.ovirt.org/57299 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I942f40c3d7597a6d417d5e44d1be4a0cb41e61ae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: sonar Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>

8 years, 6 months

1
0
0 / 0

Change in ovirt-hosted-engine-setup[master]: Adapt to netinfo namespace change under network

by stirabos＠redhat.com

Simone Tiraboschi has submitted this change and it was merged. Change subject: Adapt to netinfo namespace change under network ...................................................................... Adapt to netinfo namespace change under network netinfo library from vdsm was moved under network directory and broke the setup. TODO In the future we need to establish an API or a stable library to work with. Change-Id: I0f4a99c8562e947baa27ef0447df0b317a0b1e08 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/ovirt_hosted_engine_setup/vds_info.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Verified Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/57228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f4a99c8562e947baa27ef0447df0b317a0b1e08 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

Change in ovirt-release[ovirt-3.6]: node: Temporarily disable cockpit-ovirt

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: Temporarily disable cockpit-ovirt ...................................................................... node: Temporarily disable cockpit-ovirt Until the dependency and naming issues of cockpit-ovirt are solved, disable it. Change-Id: I89da60514b5b60c8feea8f0d1371e84b5601f369 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M ovirt-release36.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Fabian Deutsch: Verified; Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Anatoly Litovsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89da60514b5b60c8feea8f0d1371e84b5601f369 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 6 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits May 2016