Change in ovirt-engine[master]: engine: Adjusting the value of binding:host_id during openst...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Adjusting the value of binding:host_id during openstack port allocation
......................................................................
engine: Adjusting the value of binding:host_id during openstack port allocation
The value of binding:host_id must be the same value as was set
during the automated neutron agent during host installation, or
just the host name if the agent was installed manually.
If the neutron agent was installed automatically during host
deployment, the vds static data will contain the provider id.
Based on this the value the host_id is determined.
Change-Id: I6f0fd4c2398112c189b853c1294bf535b82dca9b
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56396
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f0fd4c2398112c189b853c1294bf535b82dca9b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: engine: Moving network provider id from paramters to paramte...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Moving network provider id from paramters to paramters.vdsstaticdata
......................................................................
engine: Moving network provider id from paramters to paramters.vdsstaticdata
The openstack network provider is moved from parameters to
parameters.vdsstaticdata. This will alow to persist
the openstack network provider as part of VdsStatic data.
This is required to distinguish hosts which have the
neutron agent configured during host installation.
In this case the neutron agent has the property
binding:host_id set to a custom value, and this
needs to be reflected during openstack port allocation.
In case the agent is installed manually, the property
value must not be customized.
Change-Id: I71c6ac97486a210d80da6e5b6e23386b32e538ff
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/hostdeploy/InstallVdsParameters.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
5 files changed, 17 insertions(+), 18 deletions(-)
Approvals:
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56395
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71c6ac97486a210d80da6e5b6e23386b32e538ff
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: webadmin: Display only openstack providers when adding host
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Display only openstack providers when adding host
......................................................................
webadmin: Display only openstack providers when adding host
Only openstack providers should be displayed in the Network Provider
tab during host installation.
External network provider installation is not ready yet.
Change-Id: I4a775fa0f60e713cd40739224bae2ace01e63d1d
Bug-Url: https://bugzilla.redhat.com/1314375
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/HostNetworkProviderModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57093
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a775fa0f60e713cd40739224bae2ace01e63d1d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: engine: Apply tenant id for all networks providers
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Apply tenant id for all networks providers
......................................................................
engine: Apply tenant id for all networks providers
Tenant id should be set for entities of both
Openstack and external providers.
Change-Id: Ib4cc5a4b538cab4b1c24f3635a599f45e7ba3c5f
Bug-Url: https://bugzilla.redhat.com/1314375
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java
2 files changed, 5 insertions(+), 36 deletions(-)
Approvals:
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57092
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4cc5a4b538cab4b1c24f3635a599f45e7ba3c5f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: webadmin: Changing network provider read-only default value ...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Changing network provider read-only default value to true
......................................................................
webadmin: Changing network provider read-only default value to true
The read only checkbox for network providers should be true
for new providers.
Change-Id: Ibc1fbc582440aebecaf8a19fa9fe4d604be73532
Bug-Url: https://bugzilla.redhat.com/1314375
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57082
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc1fbc582440aebecaf8a19fa9fe4d604be73532
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: engine: Changing OpenstackNetworkProviderProperties read-onl...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Changing OpenstackNetworkProviderProperties read-only from Boolean to boolean
......................................................................
engine: Changing OpenstackNetworkProviderProperties read-only from Boolean to boolean
The value can either be true/false, and not undeterminded (null)
Change-Id: I1830ac6cf51bb988852fde2f0cd5555989f0359b
Bug-Url: https://bugzilla.redhat.com/1314375
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56591
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1830ac6cf51bb988852fde2f0cd5555989f0359b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: webadmin: Adding read only option to openstack providers
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Adding read only option to openstack providers
......................................................................
webadmin: Adding read only option to openstack providers
Openstack provider should also have the read only option,
just like the external provider.
Change-Id: Iba2a7e3232d14ef6462ee80273d9782ca701bab3
Bug-Url: https://bugzilla.redhat.com/1314375
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ProviderType.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/RemoveNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkExternalSubnetListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
5 files changed, 14 insertions(+), 22 deletions(-)
Approvals:
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56595
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba2a7e3232d14ef6462ee80273d9782ca701bab3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: restapi: Adding readOnly property to NetworkProvider
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: restapi: Adding readOnly property to NetworkProvider
......................................................................
restapi: Adding readOnly property to NetworkProvider
Change-Id: I0267f5818c7a47436ff02c9907a74592cdf72c62
Bug-Url: https://bugzilla.redhat.com/1314375
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/openstack/OpenStackNetworkProviderMapper.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Marcin Mirecki: Verified
Alona Kaplan: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56612
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0267f5818c7a47436ff02c9907a74592cdf72c62
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: engine: Add query fetching providers by multiple provider types
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Add query fetching providers by multiple provider types
......................................................................
engine: Add query fetching providers by multiple provider types
Change-Id: Idf5c9745d9fec15cd06b2db73e93e1fdc078aee7
Bug-Url: https://bugzilla.redhat.com/1314375
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/EngineForemanProviderFinder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/GetAllProvidersQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/CinderProviderValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllProvidersParameters.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDaoImpl.java
M packaging/dbscripts/providers_sp.sql
7 files changed, 26 insertions(+), 24 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56594
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf5c9745d9fec15cd06b2db73e93e1fdc078aee7
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-release[ovirt-4.0]: Require cockpit-ovirt-dashboard, not cockpit-ovirt
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Require cockpit-ovirt-dashboard, not cockpit-ovirt
......................................................................
Require cockpit-ovirt-dashboard, not cockpit-ovirt
The package was renamed. Require the new package name instead
Change-Id: I23d3b14d09680f1f57c1140bd8f6c0f2289e0505
Signed-off-by: Ryan Barry <rbarry(a)redhat.com>
---
M ovirt-release40.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57281
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1958977cc241a96ffaa9800e22cfb7325ec87529
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months