Change in jenkins[master]: Fix typos in vdsm and vdsm-jsonrpc-java projects
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Fix typos in vdsm and vdsm-jsonrpc-java projects
......................................................................
Fix typos in vdsm and vdsm-jsonrpc-java projects
stardard -> standard
Change-Id: I57ec82408f7e7c53c785d3b2c8044c9953dc2b3d
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M jobs/confs/projects/vdsm-jsonrpc-java/vdsm-jsonrpc-java_standard.yaml
M jobs/confs/projects/vdsm/vdsm_standard.yaml
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me; Ready for merge
Nir Soffer: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57220
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57ec82408f7e7c53c785d3b2c8044c9953dc2b3d
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in jenkins[master]: ioprocess: switch 3.6 to 0.15.1 branch
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ioprocess: switch 3.6 to 0.15.1 branch
......................................................................
ioprocess: switch 3.6 to 0.15.1 branch
Change-Id: I1e82f9029019fad79f61db6087f75b25e67e605d
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ioprocess/ioprocess_create-rpms.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml
2 files changed, 4 insertions(+), 12 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Ready for merge
Gil Shinar: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57158
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e82f9029019fad79f61db6087f75b25e67e605d
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: packaging: setup: getDBConfig: Allow overriding host
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: getDBConfig: Allow overriding host
......................................................................
packaging: setup: getDBConfig: Allow overriding host
So that if db is at localhost, when generating conf for a remote
machine, can put instead our fqdn.
Change-Id: I83ab0f3140629b3f842842f15d8ccdf7910e6d3e
Bug-Url: https://bugzilla.redhat.com/1318665
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine_common/database.py
1 file changed, 15 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/56462
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I83ab0f3140629b3f842842f15d8ccdf7910e6d3e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: webadmin: PermissionList - correct VdcObjectType for LunDisk
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: PermissionList - correct VdcObjectType for LunDisk
......................................................................
webadmin: PermissionList - correct VdcObjectType for LunDisk
PermissionListModel:
Returning an appropriate VdcObjectType for LunDisk/CinderDisk.
Needed for proper display/creation of permissions.
Change-Id: I1f66ef6a98947420543686bd566ea3c26e06f1e6
Bug-Url: https://bugzilla.redhat.com/1325785
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/57196
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f66ef6a98947420543686bd566ea3c26e06f1e6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: Fix findbugs DLS issue in BondPanel class
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix findbugs DLS issue in BondPanel class
......................................................................
core: Fix findbugs DLS issue in BondPanel class
Commit eb86f8a219e5e99f71462d1478c1db5a6680f7db introduced a dead local
store in BondPanel, this patch removes this DLS
Change-Id: Iaed1beedaa9ca77a5304fadbb10229aa3404529e
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57209
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaed1beedaa9ca77a5304fadbb10229aa3404529e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: webadmin: "VmWare" should be changed to "VMware"
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: "VmWare" should be changed to "VMware"
......................................................................
webadmin: "VmWare" should be changed to "VMware"
Fix typo in Enums file for property key: OriginType___VMWARE
Change-Id: I2936111c152e472f780ec7080b13a6b7d70a35ed
Bug-Url: https://bugzilla.redhat.com/1331940
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/57187
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2936111c152e472f780ec7080b13a6b7d70a35ed
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: enginei: simplify awkward ternary expression
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: enginei: simplify awkward ternary expression
......................................................................
enginei: simplify awkward ternary expression
Change-Id: I80480e282c688343af4ca24597c2fa13796a2eb2
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/57180
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80480e282c688343af4ca24597c2fa13796a2eb2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-3.6.6]: core: Disable Pass-Through Host CPU for PPC Arch
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Disable Pass-Through Host CPU for PPC Arch
......................................................................
core: Disable Pass-Through Host CPU for PPC Arch
Disable the checkbox for "Pass-through Host CPU" in the Add and Edit
VM dialog popups and the ability to enable the setting via the REST
API when on a cluster with a PPC-based architecture.
As PPC doesn't allow for Host CPU pass-through, these options shouldn't
be available.
Change-Id: I76941ecf63988ff55380760765cb8a6bc12bb58f
Bug-Url: https://bugzilla.redhat.com/1291063
Signed-off-by: Phillip Bailey <phbailey(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ArchitectureType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
12 files changed, 123 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, but someone else must approve
Phillip Bailey: Verified
--
To view, visit https://gerrit.ovirt.org/57183
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76941ecf63988ff55380760765cb8a6bc12bb58f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.6
Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: engine: fix nic's source ip configuration
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: fix nic's source ip configuration
......................................................................
engine: fix nic's source ip configuration
In case no vlan tag exist, take the base nic as the source of the ip
configuration.
Change-Id: Ib476ebe86102dfe69db413a7e57debae42a5c231
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/HostSetupNetworksParametersBuilder.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51595
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib476ebe86102dfe69db413a7e57debae42a5c231
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: engine: fix Covertity warning CID 1354710
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: fix Covertity warning CID 1354710
......................................................................
engine: fix Covertity warning CID 1354710
CID 1354710
If the function actually returns a null value,
a NullPointerException will be throw.
Change-Id: Ibb328ffe5a7610e8676b7e5374f61ce27bb2caef
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java
A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommandTest.java
2 files changed, 57 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/57117
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb328ffe5a7610e8676b7e5374f61ce27bb2caef
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months