Change in jenkins[master]: move artifactory-ovirt-org-settings.xml to jenkins repo
by eedri@redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: move artifactory-ovirt-org-settings.xml to jenkins repo
......................................................................
move artifactory-ovirt-org-settings.xml to jenkins repo
until now, this file was served staticly on the Jenkins master,
and each job that required it copied it. Few weeks ago it was added
to infra-puppet repositry. However, I think it better fits here, as this
is actually a job configuration and it will allow us better versioning
and visibility.
Each none standard-ci job that needs this file can clone it.
Change-Id: I917ec8d705f27f9525c564b6c38ac856a5711089
Signed-off-by: ngoldin <ngoldin(a)redhat.com>
---
A xml/artifactory-ovirt-org-settings.xml
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Nadav Goldin: Verified; Ready for review
Sharon Naftaly: Looks good to me
Barak Korren: Looks good to me
Eyal Edri: Looks good to me; Passed CI tests; Ready for merge
--
To view, visit https://gerrit.ovirt.org/59843
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I917ec8d705f27f9525c564b6c38ac856a5711089
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: aaa: Empty keystore passwd should be passed as null to KeySt...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: Empty keystore passwd should be passed as null to KeyStore.load
......................................................................
aaa: Empty keystore passwd should be passed as null to KeyStore.load
If the keystore password is empty then
java.security.KeyStore.load whuld be invoked
with password value set to null.
Change-Id: I0f9c3706ffe150f848f231ace3ec5995d3ee2d85
Bug-Url: https://bugzilla.redhat.com/1336838
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
(cherry picked from commit 450ddf268096a6210acbff8f6e448cb0819b3e15)
---
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/net/HttpURLConnectionBuilder.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59857
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f9c3706ffe150f848f231ace3ec5995d3ee2d85
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Fix error in hot-attaching disk to VM as Virtio-ISCSI/...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix error in hot-attaching disk to VM as Virtio-ISCSI/SPAPR-SCSI
......................................................................
core: Fix error in hot-attaching disk to VM as Virtio-ISCSI/SPAPR-SCSI
Change-Id: I4a25487876c9b2481324e300d850123dc725c67a
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1350226
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59837
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a25487876c9b2481324e300d850123dc725c67a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Fix NPE when importing a registered VM
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix NPE when importing a registered VM
......................................................................
webadmin: Fix NPE when importing a registered VM
Change-Id: I7a0bc2057c7a3f96b6642df9037010371857f231
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1350203
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterEntityPopupView.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59836
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a0bc2057c7a3f96b6642df9037010371857f231
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Fix ClassCastException when importing a registered VM
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix ClassCastException when importing a registered VM
......................................................................
webadmin: Fix ClassCastException when importing a registered VM
When a VM applications list was empty a bug in the process of the app list
caused the list of application to be created as a list of lists as opposed
to a list of strings
Change-Id: I52b798d94750b086f9571de88a4cc36d06e71a74
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1350200
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmInfoPanel.java
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59835
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52b798d94750b086f9571de88a4cc36d06e71a74
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in jenkins[master]: fix email address alerts for ovirt-system-tests
by eedri@redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: fix email address alerts for ovirt-system-tests
......................................................................
fix email address alerts for ovirt-system-tests
Change-Id: Ic6bb3184667a0d964e2445d7cd805da90fde8538
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/projects/ovirt/system-tests.yaml
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Looks good to me
Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59770
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6bb3184667a0d964e2445d7cd805da90fde8538
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: restapi: Remove unused field from V3 disks server
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Remove unused field from V3 disks server
......................................................................
restapi: Remove unused field from V3 disks server
The "vmId" field is no longer required, and its pressence generates a
findbugs failure.
Change-Id: Ifa3e6f5a5bcb166d9e0f470442135bb6f7fa9854
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDiskServer.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java
2 files changed, 2 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59828
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa3e6f5a5bcb166d9e0f470442135bb6f7fa9854
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: aaa: Empty keystore passwd should be passed as null to KeySt...
by mperina@redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: aaa: Empty keystore passwd should be passed as null to KeyStore.load
......................................................................
aaa: Empty keystore passwd should be passed as null to KeyStore.load
If the keystore password is empty then
java.security.KeyStore.load whuld be invoked
with password value set to null.
Change-Id: I0f9c3706ffe150f848f231ace3ec5995d3ee2d85
Bug-Url: https://bugzilla.redhat.com/1336838
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/net/HttpURLConnectionBuilder.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59839
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f9c3706ffe150f848f231ace3ec5995d3ee2d85
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Return added affinity label
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Return added affinity label
......................................................................
restapi: Return added affinity label
Currently when an affinity label is added to a host or to a virtual
machine, the doesn't return the added label, like all the other "add"
operations of the API do. This patch changes the relevant resource so
that it will fetch and return the added affinity label.
Change-Id: I8d8c9de6b87424706faf7643924790ba08200c4b
Bug-Url: https://bugzilla.redhat.com/1350228
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 57b26e6e4abd81389937fe931a0cfdb5af879cca)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedAffinityLabelsResource.java
1 file changed, 14 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59840
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d8c9de6b87424706faf7643924790ba08200c4b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: restapi: Return added affinity label
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Return added affinity label
......................................................................
restapi: Return added affinity label
Currently when an affinity label is added to a host or to a virtual
machine, the doesn't return the added label, like all the other "add"
operations of the API do. This patch changes the relevant resource so
that it will fetch and return the added affinity label.
Change-Id: I8d8c9de6b87424706faf7643924790ba08200c4b
Bug-Url: https://bugzilla.redhat.com/1350228
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedAffinityLabelsResource.java
1 file changed, 14 insertions(+), 1 deletion(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59821
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d8c9de6b87424706faf7643924790ba08200c4b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months