June 2016 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: VmDevicesMonitoring empty collections

by ahadas＠redhat.com

Arik Hadas has submitted this change and it was merged. Change subject: core: VmDevicesMonitoring empty collections ...................................................................... core: VmDevicesMonitoring empty collections Use the proper generic Collections.emptyList() and Collections.emptyMap() instead of Collections.EMPTY_LIST and Collections.EMPTY_MAP, which return raw collections. Change-Id: I78585800976d91bf07635f886e13001f38d1e38e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoringTest.java 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78585800976d91bf07635f886e13001f38d1e38e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: buildNewVmDevice variable scope

by ahadas＠redhat.com

Arik Hadas has submitted this change and it was merged. Change subject: core: buildNewVmDevice variable scope ...................................................................... core: buildNewVmDevice variable scope Reduced the scope of newDeviceId to only be declared where its used. Change-Id: I0ced0ce46b3a842a855d2d122942144f3ada88a4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ced0ce46b3a842a855d2d122942144f3ada88a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: rm VmDevicesMonitoringTest#SERIAL_DEVICE_ID

by ahadas＠redhat.com

Arik Hadas has submitted this change and it was merged. Change subject: core: rm VmDevicesMonitoringTest#SERIAL_DEVICE_ID ...................................................................... core: rm VmDevicesMonitoringTest#SERIAL_DEVICE_ID Removed unused constant. Change-Id: I9272a33300a1d93ed1fc92d378b68ce1060d9071 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoringTest.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9272a33300a1d93ed1fc92d378b68ce1060d9071 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in gerrit-admin[master]: set_MODIFIED:don't ignore -rc/beta... milestones

by dcaro＠redhat.com

David Caro has submitted this change and it was merged. Change subject: set_MODIFIED:don't ignore -rc/beta... milestones ...................................................................... set_MODIFIED:don't ignore -rc/beta... milestones Change-Id: I4766f585f98d9d2e089adb120d2dd5ae69bcff98 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M hooks/custom_hooks/change-merged.set_MODIFIED 1 file changed, 16 insertions(+), 7 deletions(-) Approvals: Eyal Edri: Looks good to me, approved Jenkins CI: Passed CI tests David Caro: Verified -- To view, visit https://gerrit.ovirt.org/58785 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4766f585f98d9d2e089adb120d2dd5ae69bcff98 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: UpdateStoragePoolCommandTest type inference

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateStoragePoolCommandTest type inference ...................................................................... core: UpdateStoragePoolCommandTest type inference Change-Id: Ie99f9e63c36a0c75ae6a112a0513e817746c4f91 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59292 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie99f9e63c36a0c75ae6a112a0513e817746c4f91 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6.7]: core: Remove redundant else when calling registerOvfStoreDisks

by piotr.kliczewski＠gmail.com

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Remove redundant else when calling registerOvfStoreDisks ...................................................................... core: Remove redundant else when calling registerOvfStoreDisks Since a false result will cause throwing new exception there is no reason to keep the else in the if statement. Change-Id: Iacab6439ec3783924e82cfd292a511ebc3a76e5a Bug-Url: https://bugzilla.redhat.com/1344314 Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/59274 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacab6439ec3783924e82cfd292a511ebc3a76e5a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.7 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6.7]: core: Connect all hosts on adding storage pool.

by piotr.kliczewski＠gmail.com

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Connect all hosts on adding storage pool. ...................................................................... core: Connect all hosts on adding storage pool. Once we create a storage pool with multiple hosts, we connect the first host to all the storage domains and create a storage pool. After the create succeeded, the flow continues, and tries to fetch all the unregistered disks before all the hosts in the Data Center are connected to all the storage domains. As part of the query of getting the unregistered disks, the engine uses the getImagesList query. This vds command uses IrsProxyData which executes ConnectStoragePoolVDSCommand, and the host that execute this method uses a random host which might not be connected. To avoid this problem, once we have a host which successfully created a storage pool we keep connect all the rest of the storage domains since they are already being connected when getting activated. Change-Id: I57ca7d7495410da6caada1c08d2ed95d467a464c Bug-Url: https://bugzilla.redhat.com/1344314 Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java 1 file changed, 17 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/59273 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57ca7d7495410da6caada1c08d2ed95d467a464c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.7 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6.7]: core: Remove redundant else

by piotr.kliczewski＠gmail.com

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Remove redundant else ...................................................................... core: Remove redundant else Change-Id: If7fcfb05dd148a9471772882a3a1e9a30fb2a488 Bug-Url: https://bugzilla.redhat.com/1344314 Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/59272 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7fcfb05dd148a9471772882a3a1e9a30fb2a488 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.7 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: User setting of FullScreen propagated to .vv

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: User setting of FullScreen propagated to .vv ...................................................................... webadmin: User setting of FullScreen propagated to .vv Fix: User setting of 'Open in Full Screen' is propagated to console.vv Change-Id: Id294c4fb4e7ee40d89a8ab2bd6cb739b7dce0275 Bug-Url: https://bugzilla.redhat.com/1345791 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/59152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id294c4fb4e7ee40d89a8ab2bd6cb739b7dce0275 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Connect all hosts on adding storage pool.

by piotr.kliczewski＠gmail.com

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Connect all hosts on adding storage pool. ...................................................................... core: Connect all hosts on adding storage pool. Once we create a storage pool with multiple hosts, we connect the first host to all the storage domains and create a storage pool. After the create succeeded, the flow continues, and tries to fetch all the unregistered disks before all the hosts in the Data Center are connected to all the storage domains. As part of the query of getting the unregistered disks, the engine uses the getImagesList query. This vds command uses IrsProxyData which executes ConnectStoragePoolVDSCommand, and the host that execute this method uses a random host which might not be connected. To avoid this problem, once we have a host which successfully created a storage pool we keep connect all the rest of the storage domains since they are already being connected when getting activated. Change-Id: I57ca7d7495410da6caada1c08d2ed95d467a464c Bug-Url: https://bugzilla.redhat.com/1344314 Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java 1 file changed, 17 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/59270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57ca7d7495410da6caada1c08d2ed95d467a464c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits June 2016