Change in ovirt-engine[master]: webadmin: AlertPanel close exception
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: AlertPanel close exception
......................................................................
webadmin: AlertPanel close exception
- When closing the AlertPanel after an exception the console
would show 'Parent does is not a HasWidgets' exception. This
patch fixes the code to not generate that message.
Change-Id: I65490a7850ef86d5f54d051acdef33699918f509
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/panel/AlertPanel.ui.xml
2 files changed, 19 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/61354
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65490a7850ef86d5f54d051acdef33699918f509
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: Fix MaxImagesInChain config value mocks
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix MaxImagesInChain config value mocks
......................................................................
core: Fix MaxImagesInChain config value mocks
The mocks were in version 'General' instead of 'general' which caused the
class to ignore it when trying to fetch the value, this was changed to
the correct version and since now the class is fetching the value it's
also necessary to have it as an Integer rather than an empty String to
avoid ClassCastException
Change-Id: I7fad34ac6e9ecddda51d2c00613a5084a6bba14f
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidatorTest.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/62938
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fad34ac6e9ecddda51d2c00613a5084a6bba14f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: Fix test failure in RemoveDiskSnapshotsCommandTest
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix test failure in RemoveDiskSnapshotsCommandTest
......................................................................
core: Fix test failure in RemoveDiskSnapshotsCommandTest
Change-Id: I846ddd9b57d8b740798aa329581f8b3a222830dd
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommandTest.java
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/62934
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I846ddd9b57d8b740798aa329581f8b3a222830dd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in jenkins[master]: Backup job template and Jenkins backup job
by eedri@redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Backup job template and Jenkins backup job
......................................................................
Backup job template and Jenkins backup job
This patch includes:
1. a bash script wrapping duplicity
2. yaml template for creating backup jobs
3. jobs realization for {jenkins,jenkins-old}.ovirt.org
backup
bug-url: https://ovirt-jira.atlassian.net/browse/OVIRT-477
Change-Id: Icaa28d9233057ee54bf1c311569321d4f1444209
Signed-off-by: ngoldin <ngoldin(a)redhat.com>
---
D backup/backup-jenkins.sh
A backup/duplicity-backup.sh
A jobs/confs/projects/system/system_backup.yaml
A jobs/confs/yaml/templates/system_backup.yaml
4 files changed, 262 insertions(+), 33 deletions(-)
Approvals:
Nadav Goldin: Verified; Looks good to me; Ready for review
Eyal Edri: Ready for merge
Gil Shinar: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56916
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icaa28d9233057ee54bf1c311569321d4f1444209
Gerrit-PatchSet: 22
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: GetExistingStorageDomainListQuery DbFacade
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: GetExistingStorageDomainListQuery DbFacade
......................................................................
core: GetExistingStorageDomainListQuery DbFacade
Use the existing DbFacade instead of using the deprecated getInstance()
method.
Change-Id: Ifb7255b056aa05adc619d2441bfff7ed478410ed
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetExistingStorageDomainListQuery.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/62932
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb7255b056aa05adc619d2441bfff7ed478410ed
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine-sdk[sdk_3.6]: sdk: Prepare for next development iteration
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Prepare for next development iteration
......................................................................
sdk: Prepare for next development iteration
In preparation for the next development iteration this patch increases
the version number and sets the RPM relase number to 0.1.
Change-Id: I3a967442368115ed6eed5711dfd03c2ea3b6e58a
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M setup.py
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62940
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a967442368115ed6eed5711dfd03c2ea3b6e58a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.6
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine-sdk[sdk_3.6]: sdk: Release 3.6.9.1
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Release 3.6.9.1
......................................................................
sdk: Release 3.6.9.1
Change-Id: I7bafd19542638cc838cdba7aedb2e3a94c08f2ef
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M ovirt-engine-sdk-python.spec.in
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62939
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bafd19542638cc838cdba7aedb2e3a94c08f2ef
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.6
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine-sdk[sdk_3.6]: Support to pass username and password as unicode
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Support to pass username and password as unicode
......................................................................
Support to pass username and password as unicode
Change-Id: I46f897523206959685f0161086f88a4fd4501989
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1365910
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M src/ovirtsdk/infrastructure/connectionspool.py
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Ondra Machacek: Verified
Juan Hernandez: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62228
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46f897523206959685f0161086f88a4fd4501989
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.6
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-live[ovirt-live-4.0]: ovirt-live-4.0.3
by lveyde@redhat.com
Lev Veyde has submitted this change and it was merged.
Change subject: ovirt-live-4.0.3
......................................................................
ovirt-live-4.0.3
Change-Id: I6f3fdcf9f7412053731410d867ad728aa9915860
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/Makefile
M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Lev Veyde: Looks good to me, approved; Passed CI tests
Sandro Bonazzola: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62933
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f3fdcf9f7412053731410d867ad728aa9915860
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-4.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[ovirt-engine-4.0]: lsm: Prevent removing auto-gen snapshot if VM powered off du...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: lsm: Prevent removing auto-gen snapshot if VM powered off during LSM
......................................................................
lsm: Prevent removing auto-gen snapshot if VM powered off during LSM
If the VM is powered off during LSM, removing the auto-generated
snapshot will end up by a cold merge operation. Until BZ 1246114 is
fixed, cold merge copies data from base volume to top and removes the
base volume. This behavior isn't desired during LSM hence, it is
prevented in this patch.
Once BZ 1246114 is fixed, this limit can be removed.
This behavior is tracked by BZ 1369942.
Change-Id: I03e1b55e9812c369dbec1c0297c6d2ee781412a6
Bug-Url: https://bugzilla.redhat.com/1368203
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java
1 file changed, 14 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/62923
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03e1b55e9812c369dbec1c0297c6d2ee781412a6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months