Change in ovirt-engine-sdk[sdk_4.0]: Use relative imports for test utilities
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Use relative imports for test utilities
......................................................................
Use relative imports for test utilities
In Python 3 the "server" tests module can't be imported with "import server"
because the tests directory isn't in the Python path. To avoid that issue this
patch changes the tests so that they import it using an explicit relative
import.
Change-Id: I7baa886f08310f040f62c897f964e8e2407e8e0a
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit cd6a6bdbd4851c9ab3f64b5341d4cf727d4535d1)
---
M sdk/tests/test_cluster_service.py
M sdk/tests/test_connection_create.py
M sdk/tests/test_datacenter_service.py
M sdk/tests/test_setupnetworks.py
M sdk/tests/test_storage_domain_service.py
M sdk/tests/test_vm_service.py
6 files changed, 8 insertions(+), 8 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62964
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7baa886f08310f040f62c897f964e8e2407e8e0a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine-sdk[sdk_4.0]: Encode/decode test data using UTF-8
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Encode/decode test data using UTF-8
......................................................................
Encode/decode test data using UTF-8
Currently the data sent and received by the tests isn't converted from strings
to arrays of bytes. As a result the tests don't work with Python 3 because the
HTTP server used by the tests requires bytes, not strings. This patch changes
the tests so that they explicitly encode/decode the data.
Change-Id: If7aad9db77ad12ebcd1d995060f4fddf820bcdfb
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 9281aabfc61a620be5cef5d1691ba2878a586340)
---
M sdk/tests/server.py
M sdk/tests/test_reader.py
2 files changed, 7 insertions(+), 5 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62963
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If7aad9db77ad12ebcd1d995060f4fddf820bcdfb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine-sdk-java[sdk_4.0]: [maven-release-plugin] prepare for next development iteration
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: [maven-release-plugin] prepare for next development iteration
......................................................................
[maven-release-plugin] prepare for next development iteration
Change-Id: I5943df70a5d6190ccee7c3367de6fba0d9a83b16
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M automation/build-artifacts.sh
M generator/pom.xml
M pom.xml
M sdk/pom.xml
4 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62960
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5943df70a5d6190ccee7c3367de6fba0d9a83b16
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine-sdk[sdk_4.0]: Use HTTPMessage.get instead of HTTPMessage.getheader
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Use HTTPMessage.get instead of HTTPMessage.getheader
......................................................................
Use HTTPMessage.get instead of HTTPMessage.getheader
In Python 3 the 'getheader' method doesn't work, but 'get' works in both
Python 2 and Python 3.
Change-Id: I7a7d6599dcc31cfc56f62e605229854aaab17dcd
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 86e15e5ec3955b29d488f16ea53113d451c150b1)
---
M sdk/tests/server.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62962
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a7d6599dcc31cfc56f62e605229854aaab17dcd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine-sdk-java[sdk_4.0]: [maven-release-plugin] prepare release 4.0.0
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: [maven-release-plugin] prepare release 4.0.0
......................................................................
[maven-release-plugin] prepare release 4.0.0
Change-Id: Id66a0882640dfdb8889dbd3ecb2ef07b2b161556
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M automation/build-artifacts.sh
M generator/pom.xml
M packaging/build.sh
M pom.xml
A sdk/CHANGES.adoc
M sdk/pom.xml
6 files changed, 17 insertions(+), 8 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62959
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id66a0882640dfdb8889dbd3ecb2ef07b2b161556
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine-sdk[sdk_4.0]: Use alternative test imports for Python 3
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Use alternative test imports for Python 3
......................................................................
Use alternative test imports for Python 3
Some of the dependencies used in the tests don't work in Python 3. This patch
changes the corresponding 'import' statements so that they work with Python 2
and Python 3.
Change-Id: If5049cd7ac445a56ebc4ac459961d0bfd112787b
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 8068ae31d49ba1d50ca7f6e1b57fa3c1a6b3fd9a)
---
M sdk/tests/server.py
1 file changed, 12 insertions(+), 3 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62961
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5049cd7ac445a56ebc4ac459961d0bfd112787b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine-sdk[sdk_4.0]: Catch Unicode encode and decode exceptions
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Catch Unicode encode and decode exceptions
......................................................................
Catch Unicode encode and decode exceptions
When an incorrect ASCII string is passed to the 'encode' method it generates an
'UnicodeDecodeError' exception and we catch it. But in Python 3 it generates
'UnicodeEncodeError', and we don't catch it. As a result we don't handle this
situation correctly in Python 3. This patch changes the SDK so that it catches
both exceptions, so that it will work with Python 2 and 3.
Change-Id: I9d5da5fcd9a6e8de51acd1aaa00a63797700617f
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/lib/ovirtsdk4/__init__.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62956
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d5da5fcd9a6e8de51acd1aaa00a63797700617f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine-sdk[sdk_4.0]: Make sure that query parameters are always sorted
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Make sure that query parameters are always sorted
......................................................................
Make sure that query parameters are always sorted
Currently when we format query parameters we depend on the internal sorting of
the Python 'dict' type. This isn't convenient, specially for tets, as it isn't
possible to predict what will be the query string generated. To avoid that this
patch changes the SDK so that it sorts the query parameters by name before
creating the query string.
Change-Id: I19028dad41872633a82d8cfece9625e782b9d222
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 8ea58337e7ed54711c2eca2d3540a7b0952ac686)
---
M sdk/lib/ovirtsdk4/__init__.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62957
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19028dad41872633a82d8cfece9625e782b9d222
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine-sdk[master]: Build and run the tests using Python 2 and 3
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Build and run the tests using Python 2 and 3
......................................................................
Build and run the tests using Python 2 and 3
This patch changes the build scripts so that the builds can and do run with
both Python 2 and Python 3, if they are available.
Change-Id: Id454e8f7705bffa7c6f14aecf4d8c2ff4c6b1417
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M README.adoc
M automation/build-artifacts.sh
M automation/check-patch.sh
M pom.xml
M sdk/pom.xml
5 files changed, 27 insertions(+), 6 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62936
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id454e8f7705bffa7c6f14aecf4d8c2ff4c6b1417
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine-sdk[master]: Use relative imports for test utilities
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Use relative imports for test utilities
......................................................................
Use relative imports for test utilities
In Python 3 the "server" tests module can't be imported with "import server"
because the tests directory isn't in the Python path. To avoid that issue this
patch changes the tests so that they import it using an explicit relative
import.
Change-Id: I7baa886f08310f040f62c897f964e8e2407e8e0a
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/tests/test_cluster_service.py
M sdk/tests/test_connection_create.py
M sdk/tests/test_datacenter_service.py
M sdk/tests/test_setupnetworks.py
M sdk/tests/test_storage_domain_service.py
M sdk/tests/test_vm_service.py
6 files changed, 8 insertions(+), 8 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62935
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7baa886f08310f040f62c897f964e8e2407e8e0a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months