Change in ovirt-engine[master]: core: scheduling: Log exception instead of printStackTrace
by dfediuck@redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: scheduling: Log exception instead of printStackTrace
......................................................................
core: scheduling: Log exception instead of printStackTrace
Change-Id: I79eb8f152e649f6515d0c6a1e0ffbfccbac07457
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalPolicyUnits.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Roman Mohr: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Roy Golan: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/60312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79eb8f152e649f6515d0c6a1e0ffbfccbac07457
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: webadmin: Rephrase Running VMs notification for Cluster Upgrade
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Rephrase Running VMs notification for Cluster Upgrade
......................................................................
webadmin: Rephrase Running VMs notification for Cluster Upgrade
Text of notification regarding running VMs after Cluster Version Change
is changed.
Change-Id: I363dd54f88abe13bb901bc04039a8e8d8e42f06c
Bug-Url: https://bugzilla.redhat.com/1356027
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Marek Libra: Verified
--
To view, visit https://gerrit.ovirt.org/62437
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I363dd54f88abe13bb901bc04039a8e8d8e42f06c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk[sdk_4.0]: Release 4.0.0.a6
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Release 4.0.0.a6
......................................................................
Release 4.0.0.a6
Change-Id: Ife6ec61e2ad59c62fca40b1c1b0cd5d436e34ab0
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M automation/build-artifacts.sh
M packaging/build.sh
M sdk/lib/ovirtsdk4/version.py
M sdk/setup.py
4 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62658
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife6ec61e2ad59c62fca40b1c1b0cd5d436e34ab0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: core: fix monitoring of guest agent nics
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: fix monitoring of guest agent nics
......................................................................
core: fix monitoring of guest agent nics
We used to to compare the hash that is being calculated by the engine (of
network interfaces reported by the guest agent) with the hash in the
dynamic VM data reported by VDSM. The problem is that VDSM doesn't report
this hash, therefore it is always zero and therefore we update the dynamic
data of a VM that is installed with guest agent on each monitoring cycle.
This patch fixes this by changing the mentioned check so the computed
hash will be compared to the one that was calculated previously.
Change-Id: I38533ac778ffef528340d33cfbb64589d5d49fe8
Bug-Url: https://bugzilla.redhat.com/1366786
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/62372
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38533ac778ffef528340d33cfbb64589d5d49fe8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: core: determine the order of vm statistics updates
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: determine the order of vm statistics updates
......................................................................
core: determine the order of vm statistics updates
Update VM statistics data according to the order of the
VM analyzers in VmsMonitoring.
Change-Id: Ie8d8a7f423121e7ee9876099f261a403abc5c016
Bug-Url: https://bugzilla.redhat.com/1366786
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/62516
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8d8a7f423121e7ee9876099f261a403abc5c016
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: core: make VmBase comparable
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: make VmBase comparable
......................................................................
core: make VmBase comparable
The comparison is done according to the ID of the VM.
Change-Id: Ief0d9dc0decc51ad7150d017ed2fd3bb8279c25f
Bug-Url: https://bugzilla.redhat.com/1366786
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/62514
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief0d9dc0decc51ad7150d017ed2fd3bb8279c25f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: core: determine the order of guest agent nic updates
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: determine the order of guest agent nic updates
......................................................................
core: determine the order of guest agent nic updates
Update the guest agent NIC information according to the
order of the VM analyzers in VmsMonitoring.
Change-Id: I8b3bdd11b97c133d3cfe09fe6f5c332031ae4e1c
Bug-Url: https://bugzilla.redhat.com/1366786
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java
1 file changed, 17 insertions(+), 20 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/62517
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b3bdd11b97c133d3cfe09fe6f5c332031ae4e1c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: core: update cluster to query only static vm data
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: update cluster to query only static vm data
......................................................................
core: update cluster to query only static vm data
In order to update VM, we need only its static data so
no need to use the costly query of whole VM.
Change-Id: If31cd57110eb73574ce2eb6e8e63e232c7c06dc9
Bug-Url: https://bugzilla.redhat.com/1366786
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Jakub Niedermertl: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/62515
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If31cd57110eb73574ce2eb6e8e63e232c7c06dc9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: core: fix possible deadlock on update cluster version
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: fix possible deadlock on update cluster version
......................................................................
core: fix possible deadlock on update cluster version
Sort the VMs that are being updated according to the order that
the monitoring updates VM related data to prevent a possible
race when both are done within a transaction (with postgres
lower or equal to 9.2 where updates of entries with foreign
key locks the row of the foreign entity in the transaction
scope).
Change-Id: Iedceef969c8823200bbdb27a332831e9305aebcf
Bug-Url: https://bugzilla.redhat.com/1366786
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterOperationCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java
4 files changed, 33 insertions(+), 17 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/62518
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iedceef969c8823200bbdb27a332831e9305aebcf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-java[sdk_4.0]: [maven-release-plugin] prepare release 4.0.0.alpha15
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: [maven-release-plugin] prepare release 4.0.0.alpha15
......................................................................
[maven-release-plugin] prepare release 4.0.0.alpha15
Change-Id: I884ed9547e4c0868a1daeeac7fcb8ad776d4142a
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M automation/build-artifacts.sh
M generator/pom.xml
M packaging/build.sh
M pom.xml
M sdk/pom.xml
5 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62659
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I884ed9547e4c0868a1daeeac7fcb8ad776d4142a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months