Change in ovirt-engine-sdk-ruby[sdk_4.0]: Fix typo in CHANGES.adoc
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Fix typo in CHANGES.adoc
......................................................................
Fix typo in CHANGES.adoc
This patch fixes a typo in the CHANGES.adoc file.
Change-Id: I549a3ba19a715bd38a96309010da15896cdfbfc9
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/CHANGES.adoc
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62661
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I549a3ba19a715bd38a96309010da15896cdfbfc9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-java[sdk_4.0]: Use POST method
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Use POST method
......................................................................
Use POST method
This patch changes the method GET to POST to send data.
Change-Id: I720e45918fa401a57dae3d52b35b74a784a1977b
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit a337f06170f739fc4e322f8d1f76a6c9419f2489)
---
M sdk/src/main/java/org/ovirt/engine/sdk4/internal/HttpConnection.java
M sdk/src/main/java/org/ovirt/engine/sdk4/internal/SsoUtils.java
2 files changed, 33 insertions(+), 23 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62657
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I720e45918fa401a57dae3d52b35b74a784a1977b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk[sdk_4.0]: Use POST method
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Use POST method
......................................................................
Use POST method
This patch changes the method GET to POST to send data.
Change-Id: I27c717e9d94e0371ca98c595c5525b676a355728
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit ec889f70c36b06a2a4257a68c293dbf0b61234eb)
---
M sdk/lib/ovirtsdk4/__init__.py
1 file changed, 26 insertions(+), 30 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I27c717e9d94e0371ca98c595c5525b676a355728
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-java[master]: Use POST method
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Use POST method
......................................................................
Use POST method
This patch changes the method GET to POST to send data.
Change-Id: I720e45918fa401a57dae3d52b35b74a784a1977b
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M sdk/src/main/java/org/ovirt/engine/sdk4/internal/HttpConnection.java
M sdk/src/main/java/org/ovirt/engine/sdk4/internal/SsoUtils.java
2 files changed, 33 insertions(+), 23 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62655
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I720e45918fa401a57dae3d52b35b74a784a1977b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk[master]: Use POST method
by omachace@redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Use POST method
......................................................................
Use POST method
This patch changes the method GET to POST to send data.
Change-Id: I27c717e9d94e0371ca98c595c5525b676a355728
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M sdk/lib/ovirtsdk4/__init__.py
1 file changed, 26 insertions(+), 30 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62651
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I27c717e9d94e0371ca98c595c5525b676a355728
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: fix possible deadlock on update cluster version
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix possible deadlock on update cluster version
......................................................................
core: fix possible deadlock on update cluster version
Sort the VMs that are being updated according to the order that
the monitoring updates VM related data to prevent a possible
race when both are done within a transaction (with postgres
lower or equal to 9.2 where updates of entries with foreign
key locks the row of the foreign entity in the transaction
scope).
Change-Id: Iedceef969c8823200bbdb27a332831e9305aebcf
Bug-Url: https://bugzilla.redhat.com/1366786
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterOperationCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java
4 files changed, 36 insertions(+), 17 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Arik Hadas: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62525
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iedceef969c8823200bbdb27a332831e9305aebcf
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-ruby[sdk_4.0]: [maven-release-plugin] prepare for next development iteration
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: [maven-release-plugin] prepare for next development iteration
......................................................................
[maven-release-plugin] prepare for next development iteration
Change-Id: I5c8cb4be4387240b1b56674af52a633220554056
---
M generator/pom.xml
M pom.xml
M sdk/pom.xml
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62654
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c8cb4be4387240b1b56674af52a633220554056
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-ruby[sdk_4.0]: [maven-release-plugin] prepare release 4.0.0.alpha21
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: [maven-release-plugin] prepare release 4.0.0.alpha21
......................................................................
[maven-release-plugin] prepare release 4.0.0.alpha21
Change-Id: I9798912eb03dedda8c65b2d9d9e271bef1f0718c
---
M generator/pom.xml
M pom.xml
M sdk/pom.xml
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62653
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9798912eb03dedda8c65b2d9d9e271bef1f0718c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-ruby[sdk_4.0]: Update CHANGES.adoc for release 4.0.0.alpha21
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Update CHANGES.adoc for release 4.0.0.alpha21
......................................................................
Update CHANGES.adoc for release 4.0.0.alpha21
This patch updates the CHANGES.adoc file, documenting the relevant
changes in release 4.0.0.alpha21.
Change-Id: I1cd69df03ac00fa964c1fb7372fd67a248269fcd
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/CHANGES.adoc
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62652
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1cd69df03ac00fa964c1fb7372fd67a248269fcd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-ruby[sdk_4.0]: Don't send password using GET and query parameter
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Don't send password using GET and query parameter
......................................................................
Don't send password using GET and query parameter
Currently when the SDK requests the SSO token it does so using the HTTP
GET method, and passing the user name and password as URL parameters. As
a result this user name and password are likely stored in the web server
access logs. To avoid that issue this patch changes the SDK so that it
uses the HTTP POST will the user name and password in the request body.
This change isn't compatible with the support for external SSO servers.
As the engine doesn't support that at the moment this patch also removes
it. It will be re-added in the future, when the engine supports it.
Change-Id: I2d18ea2c91ec2ececaab1c6fb2e4da4e50005a4d
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
D sdk/examples/external_authentication.rb
M sdk/lib/ovirtsdk4/http.rb
M sdk/spec/spec_helper.rb
3 files changed, 194 insertions(+), 220 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62650
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d18ea2c91ec2ececaab1c6fb2e4da4e50005a4d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months