Change in ovirt-host-deploy[master]: packaging: spec: explicit implicit deps
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: explicit implicit deps
......................................................................
packaging: spec: explicit implicit deps
Explicited implicit deps on javapackage-tool and
sonatype-parent since they won't be pulled in automatically
in next version of Fedora
Change-Id: I945718746cda57a49c9602736edc00e780ac9c74
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-host-deploy.spec.in
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62611
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I945718746cda57a49c9602736edc00e780ac9c74
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-host-deploy[master]: build: post ovirt-host-deploy-1.5 branching
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: post ovirt-host-deploy-1.5 branching
......................................................................
build: post ovirt-host-deploy-1.5 branching
Change-Id: I1109b161fa4865c06732690033512e17176f1e52
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ChangeLog
M configure.ac
M po/pt_BR.po
3 files changed, 14 insertions(+), 14 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62610
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1109b161fa4865c06732690033512e17176f1e52
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-hosted-engine-setup[master]: answerfile: emit a clear message on parsing errors
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: answerfile: emit a clear message on parsing errors
......................................................................
answerfile: emit a clear message on parsing errors
Emit a clear error if ConfigParser fails parsing the content
of the answer file on the shared storage.
Change-Id: Id8f34a793de4af95ae3c2fe6e48a4df90c342594
Bug-Url: https://bugzilla.redhat.com/1366879
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/gr-he-common/core/remote_answerfile.py
1 file changed, 10 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/62538
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8f34a793de4af95ae3c2fe6e48a4df90c342594
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: aaa: Request state does not match session state after succes...
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: Request state does not match session state after successful login
......................................................................
aaa: Request state does not match session state after successful login
Fix the usability issues with mismatched
session state when the login screen session
has expired.
The client id and client secret with the
redirect uri check should be sufficient
security check, session "state" which is
a random string and was passed between sso
and engine as an additional level of security
can be dropped with out any security threats.
Change-Id: I9874c007e2d3382bbcdc8a280302306e2e6dc601
Bug-Url: https://bugzilla.redhat.com/1367921
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoUtils.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoLoginServlet.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoPostLoginServlet.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthAuthorizeServlet.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoSession.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java
M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/LoginServlet.java
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/OAuthCallbackServlet.java
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeServlet.java
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeUtils.java
12 files changed, 9 insertions(+), 60 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62582
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9874c007e2d3382bbcdc8a280302306e2e6dc601
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: aaa: Cleanup login.jsp
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: aaa: Cleanup login.jsp
......................................................................
aaa: Cleanup login.jsp
Remove parameter state from login.jsp
Change-Id: Ic5f3ca6964893f462adb9b169cef9e4726e8cd3f
Bug-Url: https://bugzilla.redhat.com/1367921
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62581
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5f3ca6964893f462adb9b169cef9e4726e8cd3f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-live[master]: fedora: add trailing slash to output directory
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: fedora: add trailing slash to output directory
......................................................................
fedora: add trailing slash to output directory
Change-Id: If1e88eea169dd4879d597358a9a2cb54dd7f6889
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M fedora-24/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62586
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1e88eea169dd4879d597358a9a2cb54dd7f6889
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0.3]: aaa: Kerberos negotiation for RESTAPI should be enabled by d...
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: Kerberos negotiation for RESTAPI should be enabled by default to maintain SDK v3 compatibility
......................................................................
aaa: Kerberos negotiation for RESTAPI should be enabled by default to maintain SDK v3 compatibility
The restapi negotiate should be enabled by
default, ENGINE_RESTAPI_NEGO=true. This
maintains compatibilty with v3 restapi
clients.
Change-Id: I2da5a99a9dc58c4ca896e8bcf9bee7c1bb80ad10
Bug-Url: https://bugzilla.redhat.com/1367513
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M packaging/services/ovirt-engine/ovirt-engine.conf.in
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Verified; Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62535
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2da5a99a9dc58c4ca896e8bcf9bee7c1bb80ad10
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.3
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: aaa: Request state does not match session state after succes...
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: aaa: Request state does not match session state after successful login
......................................................................
aaa: Request state does not match session state after successful login
Fix the usability issues with mismatched
session state when the login screen session
has expired.
The client id and client secret with the
redirect uri check should be sufficient
security check, session "state" which is
a random string and was passed between sso
and engine as an additional level of security
can be dropped with out any security threats.
Change-Id: I9874c007e2d3382bbcdc8a280302306e2e6dc601
Bug-Url: https://bugzilla.redhat.com/1367921
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoUtils.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoLoginServlet.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoPostLoginServlet.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthAuthorizeServlet.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoSession.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/LoginServlet.java
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/OAuthCallbackServlet.java
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeServlet.java
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeUtils.java
11 files changed, 8 insertions(+), 59 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62470
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9874c007e2d3382bbcdc8a280302306e2e6dc601
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-live[master]: fedora: result dir must not exist for lorax
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: fedora: result dir must not exist for lorax
......................................................................
fedora: result dir must not exist for lorax
livemedia-creator need a non existent result dir
Change-Id: I3be078334134bc649b8ebd73f7a8ce13fc0de234
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M fedora-24/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62571
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3be078334134bc649b8ebd73f7a8ce13fc0de234
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-hosted-engine-setup[master]: Setup: Change the host nickname from host_ID to host_name. r...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Setup: Change the host nickname from host_ID to host_name. remove hosted_engine_ prefix from nickname.
......................................................................
Setup: Change the host nickname from host_ID to host_name.
remove hosted_engine_ prefix from nickname.
this is a fix for previous change id Ia77cb1e46c214cd27efff6b6463dadcbdde04105 which was reverted
Change-Id: I629f9ea514c55bc6c4e2f9d56bd8d44de93d4b2f
Bug-Url: https://bugzilla.redhat.com/1313916
Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com>
---
M src/plugins/gr-he-setup/engine/add_host.py
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Simone Tiraboschi: Looks good to me, approved
Ido Rosenzwig: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61729
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I629f9ea514c55bc6c4e2f9d56bd8d44de93d4b2f
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months