Change in ovirt-engine[master]: gluster: fix enumtranslater issue in SizeConverter
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: fix enumtranslater issue in SizeConverter
......................................................................
gluster: fix enumtranslater issue in SizeConverter
LocalizedEnums are not defined correctly for
SizeConverter.SizeUnit. As a result enum translation
was not working correctly.
Correcting the definitions in LocalizedEnums.
Note: since EnumTranslator gives the enum name when the
localization key is missing, it is not visible in the UI.
Change-Id: I85846470dbf10752fc89c9c5a79f353441f4f2da
Bug-Url: https://bugzilla.redhat.com/1358837
Bug-Url: https://bugzilla.redhat.com/1269132
Bug-Url: https://bugzilla.redhat.com/1353289
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
2 files changed, 18 insertions(+), 18 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/62274
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85846470dbf10752fc89c9c5a79f353441f4f2da
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: add a link to fence agents help page
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: add a link to fence agents help page
......................................................................
core: add a link to fence agents help page
This patch adds a link to a help page that displayed the various
available parameters per fence agent.
The patch use branding in order to enable a different URL for upstream
and downstream.
Change-Id: Ia7db339c656dcc3e9e9e1bf8f7fb314971d4c9c1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1286632
Signed-off-by: emesika <emesika(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/BaseDynamicMessages.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DynamicMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/HostFenceAgentPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostFenceAgentPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostFenceAgentPopupView.ui.xml
M packaging/branding/ovirt.brand/external_resources.properties
M packaging/branding/ovirt.brand/messages.properties
7 files changed, 91 insertions(+), 4 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62336
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7db339c656dcc3e9e9e1bf8f7fb314971d4c9c1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: Temporal VM Custom Compat Version after Cluster Versio...
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Temporal VM Custom Compat Version after Cluster Version change
......................................................................
core: Temporal VM Custom Compat Version after Cluster Version change
During Cluster Version change, temporarily set the VM Custom Compatibility
Version. This change is reverted when the VM is rebooted and so the NextRun
configuration is applied.
Change-Id: I36d4131ccc41fabaac48ed1f21fecbd1fd1a2f43
Bug-Url: https://bugzilla.redhat.com/1356027
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
3 files changed, 13 insertions(+), 8 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/61079
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36d4131ccc41fabaac48ed1f21fecbd1fd1a2f43
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: Kernel cmdline 'on' -> '1'
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Kernel cmdline 'on' -> '1'
......................................................................
core: Kernel cmdline 'on' -> '1'
Enabled kernel command line option is indicated by '1' instead of 'on'
for 'kvm-(intel|amd).nested' and
'vfio_iommu_type1.allow_unsafe_interrupts' option
since RHEL supports both ('1', 'on') whereas CentOS only '1'.
This CentOS problem doesn't apply to '(amd|intel)_iommu' option thus it
is left with more standard 'on'.
Change-Id: I2c0a19fb8906c588120abc5c398e1b1b9ac8f57d
Bug-Url: https://bugzilla.redhat.com/1360397
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/KernelCmdlineUtil.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
Martin Polednik: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/61959
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c0a19fb8906c588120abc5c398e1b1b9ac8f57d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: ui: [RFE] Allocate VmPools disks to multiple storage domains
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: ui: [RFE] Allocate VmPools disks to multiple storage domains
......................................................................
ui: [RFE] Allocate VmPools disks to multiple storage domains
Change-Id: I7253327cd6a5f9f6cbc407e46ca7370c1f994017
Bug-Url: https://bugzilla.redhat.com/1081536
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java
8 files changed, 61 insertions(+), 4 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61275
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7253327cd6a5f9f6cbc407e46ca7370c1f994017
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: [RFE] Allocate VmPools disks to multiple storage domains
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: core: [RFE] Allocate VmPools disks to multiple storage domains
......................................................................
core: [RFE] Allocate VmPools disks to multiple storage domains
Pools are allocating the VMs on a single domain (per disk),
This feature add automatic balance for allocation VMs disks by examine
where the template disks raised and allocated the pools VMs in the
domain that have more space.
Bug-Url: https://bugzilla.redhat.com/1081536
Change-Id: I7d078e07066676eca86e5bd81bee4ee46d6de56d
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDaoImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/04_01_0230_automatic_storage_select.sql
M packaging/dbscripts/vm_pools_sp.sql
7 files changed, 134 insertions(+), 26 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61274
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d078e07066676eca86e5bd81bee4ee46d6de56d
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: backend: Make VdsArchitectureHelper a CDI singleton
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: backend: Make VdsArchitectureHelper a CDI singleton
......................................................................
backend: Make VdsArchitectureHelper a CDI singleton
Change-Id: I4cdca46c04943204d7ebda1069f6a5f7ea095d10
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsArchitectureHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceAgentExecutor.java
2 files changed, 20 insertions(+), 6 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Martin Betak: Verified; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/62261
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4cdca46c04943204d7ebda1069f6a5f7ea095d10
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: backend: Default method for ClusterEditChecker#getDetailedMe...
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: backend: Default method for ClusterEditChecker#getDetailedMessage
......................................................................
backend: Default method for ClusterEditChecker#getDetailedMessage
Used Java 8 remove a bit of boilerplate.
Also added missing @Singleton annotation to SuspendedVMClusterEditChecker.
Change-Id: I6d06817556c5ddab7f33fc53c9e23aae148681bf
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractRngDeviceClusterEditChecker.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterEditChecker.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SuspendedVMClusterEditChecker.java
3 files changed, 6 insertions(+), 11 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Martin Betak: Verified; Passed CI tests
Arik Hadas: Looks good to me, approved
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/62247
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d06817556c5ddab7f33fc53c9e23aae148681bf
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: backend: Use CDI in FenceAgentExecutor
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: backend: Use CDI in FenceAgentExecutor
......................................................................
backend: Use CDI in FenceAgentExecutor
Change-Id: I57840f665c3b8618d3aa1514e841b13777e87909
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceAgentExecutor.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentFenceActionExecutor.java
2 files changed, 24 insertions(+), 18 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/62260
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57840f665c3b8618d3aa1514e841b13777e87909
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Fix checking for libvirt upgrade
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix checking for libvirt upgrade
......................................................................
core: Fix checking for libvirt upgrade
VDSM does not depend directly on libvirt, but it depends on following
subpackages:
libvirt-client
libvirt-daemon-config-nwfilter
libvirt-daemon-kvm
libvirt-lock-sanlock
libvirt-python
This patch replace libvirt with above subpackages in package list which
we use for host upgrades.
Change-Id: Ia605636957cdbe7381b0ddf42525f6db77b8870e
Bug-Url: https://bugzilla.redhat.com/1344020
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified; Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62332
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia605636957cdbe7381b0ddf42525f6db77b8870e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months